From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794817252; b=yEw5+xVixwvEU50gZ/w0hDoJ/BZkUxgjQtSZb4M7Ftd40GdaEWhsHEh321gQ5hRr9/qR fbX/zzF/fXUWSetPPCyNi/7OYFndyRg9WTX2ynXEQUe95CPyFhQ0KZ51/0IsBNm3pGFVM bMvMN1YximtiFepC9N99FGqyZZyBQt2RYCOr42iKD6uxfimOfsZhSvnC2bregHdjhHUzn zGAm0ipxoOckedDp2vOGdMM/wd6TuPWtr61xkdq4y3m8hRshgT900OY8ve8te7a5k7p/I DGXqXm5Xy2OL+6FPcOVXnXpc/sGtE+SOcKSsD6HNlzOXSBnm4GREW+2l1Pp/fEI4TqA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794817252; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=hgE96IQn5QV5Y7Wq0sDn3xiqmoFBGOL3DF1W/ekXQNk=; b=OeI9l95uhgNXIkZyMssYHLXVvmo1uLo1N7GzYdS6kCeeT88hDoIH+MTpWAVY2lBS/h9E MeCy/itjiMOUnbIlhjnHu99q5xGNv/VTz2OOB/kSuQYDsJY3LvFRSaYN8v72kTgc6onDm 9mv1/7xmOEbzkWXlKyMNKJQM6h/H8ov+K0XDYKi2qccx1vYZf/i0SRVGIXQOFd5IY96YK G8hAJqeUS0vgBZkAZyBmnX+piQRFNXLKOyfh6W2sB4IvgxC52w4Jb/Lc3MFzlGjzNrp34 +gP7VHnlVeQri5kjubuy8ainSz0uBAkQ6Kn/2XR3Yda/mUedX597ErL/Vg9unRHjIfw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="I3f/CUAu"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70F84606A31C; Mon, 16 Nov 2026 08:20:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=I3f/CUAu Received: by smtp.kernel.org (Postfix) with ESMTPSA id 770431F000C8; Mon, 16 Nov 2026 08:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794817252; bh=hgE96IQn5QV5Y7Wq0sDn3xiqmoFBGOL3DF1W/ekXQNk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=I3f/CUAu5iU3YH1te+ZeTvMye+GIiH6FNwQaoiJb8B5GKj4IzNtL7UpjbZBBZU0B0 tMT5n/8eQN5AlQ3xWore5euPmn/mM/j4RSfv45c6jRjPiLFY43jEBou1MAwS6Uy6Pu Cddm28uvBgTtzr/eGsQNZSp9vYkXRuefSr3UnPkCtn50bnCl/+cqEegHDDSM/EZV6T wa7ZU3xCSbjakPSKXM3wRUATvo8tWcqlFotzxqgDMEfha/xKKAGl09RANgsITVMIJ/ D+3X2JiDQarLlnc72DEQdMsjqLrXjbiijPSix2CEFvtlnCaSlef90saL3dAQtwtqk9 OakKe8tJkVFPA== From: "Aneesh Kumar K.V (Arm)" To: linux-coco@lists.linux.dev Cc: "Aneesh Kumar K.V (Arm)" , Alex Williamson , Alexey Kardashevskiy , Bjorn Helgaas , Catalin Marinas , Jacob Pan , Jason Gunthorpe , Joerg Roedel , Jonathan Cameron , Jonathan Hunter , Kevin Tian , Krishna Reddy , Lukas Wunner , Nicolin Chen , Robin Murphy , Samuel Ortiz , Shameer Kolothum , Steven Price , Suravee Suthikulpanit , Suzuki K Poulose , Thierry Reding , Vasant Hegde , Will Deacon , Xu Yilun , Ashish Kalra , Herbert Xu , iommu@lists.linux.dev, Jonathan Cameron , Tom Lendacky , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org, patches@lists.linux.dev Subject: [PATCH v9 06/13] iommufd: Add a vDEVICE operation ioctl framework Date: Mon, 16 Nov 2026 13:49:28 +0530 Message-ID: <20261116081935.85372-7-aneesh.kumar@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261116081935.85372-1-aneesh.kumar@kernel.org> References: <20261116081935.85372-1-aneesh.kumar@kernel.org> X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add IOMMU_VDEVICE_OP to execute operations on a vDEVICE using separate request and response buffers. Each operation defines its request and response formats, with response capacity checked before changing device state. Look up the vDEVICE and check its supported_ops mask before dispatching an operation. Reject out-of-range operation numbers before testing the corresponding bit. Backends set the mask during vdevice_init(). This patch defines no operations. The default dispatch returns -EOPNOTSUPP; later patches can add operations independently. Cc: Jason Gunthorpe Cc: Kevin Tian Cc: Joerg Roedel Cc: Will Deacon Cc: Robin Murphy Cc: Alexey Kardashevskiy Cc: Lukas Wunner Cc: iommu@lists.linux.dev Signed-off-by: Aneesh Kumar K.V (Arm) --- drivers/iommu/iommufd/iommufd_private.h | 1 + drivers/iommu/iommufd/main.c | 3 +++ drivers/iommu/iommufd/viommu.c | 36 +++++++++++++++++++++++++ include/linux/iommufd.h | 3 +++ include/linux/tsm.h | 1 + include/uapi/linux/iommufd.h | 33 +++++++++++++++++++++++ 6 files changed, 77 insertions(+) diff --git a/drivers/iommu/iommufd/iommufd_private.h b/drivers/iommu/iommufd/iommufd_private.h index 25236caf554a..b9a804adb594 100644 --- a/drivers/iommu/iommufd/iommufd_private.h +++ b/drivers/iommu/iommufd/iommufd_private.h @@ -730,6 +730,7 @@ void iommufd_vdevice_destroy(struct iommufd_object *obj); void iommufd_vdevice_abort(struct iommufd_object *obj); int iommufd_hw_queue_alloc_ioctl(struct iommufd_ucmd *ucmd); void iommufd_hw_queue_destroy(struct iommufd_object *obj); +int iommufd_vdevice_op_ioctl(struct iommufd_ucmd *ucmd); #ifdef CONFIG_IOMMUFD_TEST int iommufd_test(struct iommufd_ucmd *ucmd); diff --git a/drivers/iommu/iommufd/main.c b/drivers/iommu/iommufd/main.c index 9a921b153162..44ac819b3f4e 100644 --- a/drivers/iommu/iommufd/main.c +++ b/drivers/iommu/iommufd/main.c @@ -450,6 +450,7 @@ union ucmd_buffer { struct iommu_ioas_unmap unmap; struct iommu_option option; struct iommu_vdevice_alloc vdev; + struct iommu_vdevice_op vdevice_op; struct iommu_veventq_alloc veventq; struct iommu_vfio_ioas vfio_ioas; struct iommu_viommu_alloc viommu; @@ -510,6 +511,8 @@ static const struct iommufd_ioctl_op iommufd_ioctl_ops[] = { IOCTL_OP(IOMMU_OPTION, iommufd_option, struct iommu_option, val64), IOCTL_OP(IOMMU_VDEVICE_ALLOC, iommufd_vdevice_alloc_ioctl, struct iommu_vdevice_alloc, virt_id), + IOCTL_OP(IOMMU_VDEVICE_OP, iommufd_vdevice_op_ioctl, + struct iommu_vdevice_op, resp_uptr), IOCTL_OP(IOMMU_VEVENTQ_ALLOC, iommufd_veventq_alloc, struct iommu_veventq_alloc, out_veventq_fd), IOCTL_OP(IOMMU_VFIO_IOAS, iommufd_vfio_ioas, struct iommu_vfio_ioas, diff --git a/drivers/iommu/iommufd/viommu.c b/drivers/iommu/iommufd/viommu.c index 0dbd382eeb98..0d162a3fdc98 100644 --- a/drivers/iommu/iommufd/viommu.c +++ b/drivers/iommu/iommufd/viommu.c @@ -1,7 +1,11 @@ // SPDX-License-Identifier: GPL-2.0-only /* Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES */ +#include #include +#include +#include + #include "iommufd_private.h" void iommufd_viommu_destroy(struct iommufd_object *obj) @@ -121,6 +125,38 @@ int iommufd_viommu_alloc_ioctl(struct iommufd_ucmd *ucmd) return rc; } +int iommufd_vdevice_op_ioctl(struct iommufd_ucmd *ucmd) +{ + struct iommu_vdevice_op *cmd = ucmd->cmd; + struct iommufd_object *obj; + struct iommufd_vdevice *vdev; + int ret; + + if (cmd->__reserved) + return -EOPNOTSUPP; + + obj = iommufd_get_object(ucmd->ictx, cmd->vdevice_id, + IOMMUFD_OBJ_VDEVICE); + if (IS_ERR(obj)) + return PTR_ERR(obj); + vdev = container_of(obj, struct iommufd_vdevice, obj); + + if (cmd->op >= BITS_PER_TYPE(vdev->supported_ops) || + !(vdev->supported_ops & BIT_ULL(cmd->op))) { + ret = -EOPNOTSUPP; + goto out_put_object; + } + + switch (cmd->op) { + default: + ret = -EOPNOTSUPP; + } + +out_put_object: + iommufd_put_object(ucmd->ictx, obj); + return ret; +} + void iommufd_vdevice_abort(struct iommufd_object *obj) { struct iommufd_vdevice *vdev = diff --git a/include/linux/iommufd.h b/include/linux/iommufd.h index c15d80f611b9..d1fd7888fc91 100644 --- a/include/linux/iommufd.h +++ b/include/linux/iommufd.h @@ -125,6 +125,9 @@ struct iommufd_vdevice { */ u64 virt_id; + /* Supported vDEVICE operations; set by vdevice_init(). */ + u64 supported_ops; + /* Clean up all driver-specific parts of an iommufd_vdevice */ void (*destroy)(struct iommufd_vdevice *vdev); }; diff --git a/include/linux/tsm.h b/include/linux/tsm.h index 381c53244c83..19dedf971f14 100644 --- a/include/linux/tsm.h +++ b/include/linux/tsm.h @@ -6,6 +6,7 @@ #include #include #include +#include #define TSM_REPORT_INBLOB_MAX 64 #define TSM_REPORT_OUTBLOB_MAX SZ_16M diff --git a/include/uapi/linux/iommufd.h b/include/uapi/linux/iommufd.h index 010f47f7d3d2..b64f6330468e 100644 --- a/include/uapi/linux/iommufd.h +++ b/include/uapi/linux/iommufd.h @@ -58,6 +58,7 @@ enum { IOMMUFD_CMD_VEVENTQ_ALLOC = 0x93, IOMMUFD_CMD_HW_QUEUE_ALLOC = 0x94, IOMMUFD_CMD_IOAS_NOIOMMU_GET_PA = 0x95, + IOMMUFD_CMD_VDEVICE_OP = 0x96, }; /** @@ -1398,4 +1399,36 @@ struct iommu_hw_queue_alloc { __aligned_u64 length; }; #define IOMMU_HW_QUEUE_ALLOC _IO(IOMMUFD_TYPE, IOMMUFD_CMD_HW_QUEUE_ALLOC) + +/** + * struct iommu_vdevice_op - ioctl(IOMMU_VDEVICE_OP) + * @size: sizeof(struct iommu_vdevice_op) + * @vdevice_id: vDEVICE ID returned by IOMMU_VDEVICE_ALLOC + * @op: Operation number; no operations are currently defined + * @req_len: Size in bytes of the request at @req_uptr + * @resp_len: Response buffer capacity in bytes on input; bytes written on success + * @__reserved: Must be zero + * @req_uptr: Userspace pointer to the operation-specific request + * @resp_uptr: Userspace pointer to the operation-specific response buffer + * + * Execute an operation on a vDEVICE. Each operation defines its request and + * response formats. Requests may be extended by appending fields; bytes beyond + * the kernel's supported request size must be zero. Response capacity must be + * checked before changing device state. The ioctl returns 0 on success or a + * negative error code. + * + * No operations are currently supported; the ioctl returns -EOPNOTSUPP. + */ +struct iommu_vdevice_op { + __u32 size; + __u32 vdevice_id; + __u32 op; + __u32 req_len; + __u32 resp_len; + __u32 __reserved; + __aligned_u64 req_uptr; + __aligned_u64 resp_uptr; +}; + +#define IOMMU_VDEVICE_OP _IO(IOMMUFD_TYPE, IOMMUFD_CMD_VDEVICE_OP) #endif -- 2.43.0