Linux Confidential Computing Development
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@kernel.org>
Cc: linux-coco@lists.linux.dev, Alexey Kardashevskiy <aik@amd.com>,
	Lukas Wunner <lukas@wunner.de>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/2] PCI/TSM: Move core code into its own directory
Date: Mon, 16 Nov 2026 10:42:37 -0400	[thread overview]
Message-ID: <20261116144237.GB2245175@nvidia.com> (raw)
In-Reply-To: <yq5aecckyhdn.fsf@kernel.org>

On Mon, Nov 16, 2026 at 08:04:44PM +0530, Aneesh Kumar K.V wrote:
> Jason Gunthorpe <jgg@nvidia.com> writes:
> 
> > On Mon, Nov 16, 2026 at 06:45:03PM +0530, Aneesh Kumar K.V wrote:
> >
> >> The complete CCA patch series adds the following files:
> >> 
> >> attestation.c  core.c  ctlv_attestation_pci_gen.c  ctlv_attestation_pci_gen.h  internal.h  Makefile  spdm.c
> >
> > Why would any of this go under drivers/pci ?
> >
> > The whole point here is to make an 'attestation subsystem', so that
> > all belongs under
> >
> >   drivers/attestation/
> >
> 
> So the attestation evidence would be fetched via drivers/coco/tsm/

No.

The tsm code causes an attestation driver to start, it doesn't do any
attestation activties itself.

> and stored by drivers/pci/tsm.c:pci_tsm_evidence.

Why would we do that? Evidence is fetched, returned to userspace and
discarded by the kernel.

> I would expect drivers/attestation/ to provide helpers, like other
> core kernel components, allowing different subsystems to register as
> attestation backends, with PCI/TSM being one of them.

I expect the thing in drivers/attestation/ to provide the full end to
end driver. It calls the RMI/RSI/RHI's as directly as it can. Without
spreading stuff around all over the place.

Jason

      reply	other threads:[~2026-11-16 14:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  7:54 [PATCH 1/2] MAINTAINERS: Update TSM file coverage and repository Aneesh Kumar K.V (Arm)
2026-11-16  7:54 ` [PATCH 2/2] PCI/TSM: Move core code into its own directory Aneesh Kumar K.V (Arm)
2026-11-16 13:00   ` Jason Gunthorpe
2026-11-16 13:15     ` Aneesh Kumar K.V
2026-11-16 13:19       ` Jason Gunthorpe
2026-11-16 14:34         ` Aneesh Kumar K.V
2026-11-16 14:42           ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116144237.GB2245175@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=aik@amd.com \
    --cc=aneesh.kumar@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox