From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=192.198.163.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795074489; b=nCWwgPrPuDlCu+a7pACNWobEOOlo3OctzTVD0iWgPyUUEnNFQAtzryFpoAd/D451zoBE Mf80sO/WmN/1Atg1/8oNZ7FY1sDNWScCrBW4+ZroKQaqikkPQmLazNl6GAYOewFTogS+K giPx1VjZqKY76yWoKxb/1afnlaOSlrN0hNz1S0HzCXmA+sFE5DFCUz/bT2Xh655lcvKsH /mLz9O59jI8La6NWJFjaZXwJUvMIa8ZtJ6TcaO5seRHrqTZjN8fvGgv1JQwNw9CV4wXAM GVc6wmtbmDm4TgjsIzNTexEYO+i7TynDfsNuKqKv6DOZJ+GHUb84QJpJaT9Y3uibgPA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795074489; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:From:To:Cc:Subject: Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=p+W+nkV7IahZLhG90sl22pTY4rr0VDZilhazml71WH0=; b=w4LRMOTtk7wM/SWmcpSGkgCIa2v0ZtxzRkTvSMwJoQoNC6UQXOthN7C2jLYbFDU1+3EV i6Mb1fYtovKw7KBZ96Dl9DSW8+1gqTIlYzNhQ7P1heLZDTmS77Ur20FRR01U+5XqMaDwm m2dyzzpw+oDqVA21X7tnei3/t1MIXxRm/o3qGsAEBv6FjFCAVzmYXajWZXomkq7y0/V5A vP5Citc12PTM1MGxu7mnPxaFKOjglr8TKrUoRzJoTsry+KuBN4fmgWIBlEWmz7lto3kLf X11ySex0UhU1u1Blvr6aLSPdAip6pgWr6E3XSS77OkunGGWbREe3QZXSZyN4twSVkNA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=WPSjzp48; arc=none smtp.remote-ip=192.198.163.18 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6400160A2606 for ; Thu, 19 Nov 2026 07:48:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 6400160A2606 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=WPSjzp48 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1795074489; x=1826610489; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Ba6sfheeRgP/aP6WxF0hAJLgfESdlWbGDkAvNE2nhB4=; b=WPSjzp48S/KkK75FjTxrhIbULxojpCpvvq2vTjTs5F0kNoujuZ9lPNaV IeSb22kPj6xNkILPDW1qzte6LhRAwE9akkcrUJ7KZ8UU+vDnUrBb1CixI gXYZ5M7fyayYSu3focTkfzPzjoK2QaNR4y9xsldrvjglJ0SPQQzv+omUG QsvIZwfBT9+lOwlHlsjbzRZLiZH+nDSLVuzSUa9HEz9gaRAKgbxuuoG2X sxVu3KcvCiGfp1P3Vm+1Q4orQkP5G/ZfTgKUOHZoJYwb3eLoReDk+/Fs5 hap9JNVTCZ0orAPDSMD60kB4jPNjpYPhcDMaWEZR3+Ahp2bMVSbtiVyEj A==; X-CSE-ConnectionGUID: KwrXYS2tS8+ozCAei0pyaw== X-CSE-MsgGUID: 45c21H+oSH2MILm5wubvhA== X-IronPort-AV: E=McAfee;i="6800,10657,11970"; a="3941756" X-IronPort-AV: E=Sophos;i="6.27,220,1787036400"; d="scan'208";a="3941756" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2026 23:48:08 -0800 X-CSE-ConnectionGUID: 543kSmQdSDuoqi9M2Wbxgw== X-CSE-MsgGUID: YIF/MEsfRVKudmY8NOd+aQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,220,1787036400"; d="scan'208";a="10725817" Received: from 984fee019967.jf.intel.com ([10.23.153.244]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2026 23:48:09 -0800 From: Chao Gao To: linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org Cc: yilun.xu@intel.com, arjan.van.de.ven@intel.com, binbin.wu@linux.intel.com, Chao Gao , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Kiryl Shutsemau , Rick Edgecombe Subject: [PATCH v3 2/2] x86/virt/seamldr: Support multiple sigstruct pages Date: Wed, 18 Nov 2026 23:49:22 -0800 Message-ID: <20261119074925.3933804-3-chao.gao@intel.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20261119074925.3933804-1-chao.gao@intel.com> References: <20261119074925.3933804-1-chao.gao@intel.com> X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit TDX module sigstructs are limited to 4KB. Each update image carries a sigstruct, which is handed to P-SEAMLDR in 'struct seamldr_params' along with the module binary. The structure has room for the physical address of only one sigstruct page. TDX modules are moving to a post-quantum signature algorithm. Its signatures are far larger than the ones in use today, so the sigstruct no longer fits in 4KB. The P-SEAMLDR ABI was extended to take up to four sigstruct pages (16KB). Setting 'version' to 1 tells P-SEAMLDR to use this layout. Grow sigstruct_pages_pa_list[] to four entries to match. In anticipation of this change, the list is already filled in a loop, so filling the new entries needs no new code. Use version 1 only when the sigstruct spans more than one page. Old P-SEAMLDRs reject version 1, so this keeps today's modules working on them. Do not query P-SEAMLDR for version 1 support. Userspace selects the update image and is responsible for ensuring the module is compatible with P-SEAMLDR. Signed-off-by: Chao Gao --- v3: - Explain why sigstruct filling code is a loop already [Rick] - Drop the boilerplate AI usage note [Dave] v2: - drop macros for versions to keep the diff minimal - explain why the sigstruct filling code needs no change --- arch/x86/virt/vmx/tdx/seamldr.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/arch/x86/virt/vmx/tdx/seamldr.c b/arch/x86/virt/vmx/tdx/seamldr.c index 6b9657a28129..7c09c84df1aa 100644 --- a/arch/x86/virt/vmx/tdx/seamldr.c +++ b/arch/x86/virt/vmx/tdx/seamldr.c @@ -38,7 +38,7 @@ */ #define SEAMLDR_NR_MODULE_PA_ENTRIES ((SEAMLDR_PARAMS_NR_PAGES * PAGE_SIZE - 128) / sizeof(u64)) #define SEAMLDR_MAX_NR_MODULE_PAGES (SEAMLDR_NR_MODULE_PA_ENTRIES - SEAMLDR_PARAMS_NR_PAGES) -#define SEAMLDR_MAX_NR_SIG_PAGES 1 +#define SEAMLDR_MAX_NR_SIG_PAGES 4 /* * The seamldr_params "scenario" field specifies the operation mode: @@ -59,7 +59,7 @@ struct seamldr_params { u32 version; u32 scenario; u64 sigstruct_pages_pa_list[SEAMLDR_MAX_NR_SIG_PAGES]; - u8 reserved[104]; + u8 reserved[80]; u64 module_nr_pages; u64 module_pages_pa_list[SEAMLDR_NR_MODULE_PA_ENTRIES]; } __packed; @@ -173,6 +173,13 @@ static void populate_seamldr_params(struct seamldr_params *params, const u8 *mod, u32 mod_nr_pages) { params->version = 0; + /* + * Use version 1 only for multi-page sigstructs, to stay + * compatible with old P-SEAMLDRs that lack version 1 support. + */ + if (sig_nr_pages > 1) + params->version = 1; + params->scenario = SEAMLDR_SCENARIO_UPDATE; params->module_nr_pages = mod_nr_pages; -- 2.52.0