From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FBDC33C5 for ; Thu, 6 Apr 2023 10:35:30 +0000 (UTC) Received: by mail-ej1-f49.google.com with SMTP id qb20so228935ejc.6 for ; Thu, 06 Apr 2023 03:35:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680777329; x=1683369329; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VGuAgbNs5CTknDNOGrtLvzwspFWhgu5cW+fjK35Mz+s=; b=2tqO+PtgBpsq4gpaAV1DUgQwcGtNGwWgAy5aYQvh5UW7Cmit46KwL9M79601gd7aGf IqoZvLSFTMGwwklksXdNSqGiao15UzKyNPOxrdiyNcEV3cxe2OFLMTf38/TDcQc8vbkw DBaGMtvOidhFpLkAmtXDJeho6Ava2670mQf4xY4ednEKSR8XeNm/Jmc/DibRIlmypAcx AqSfbm9AncluaB6HuXNx80WRjQ9r0htxCieZb//GUJ1K+2/Kfa2hhXGwwwd5y5/bP96g eGS47PGAsJMpGtRHoQQhEYxis9vFyw183pJHda/P7jHUGljnsJWgYmNUy8F3SNjWKbK/ 7SrQ== X-Gm-Message-State: AAQBX9dBVkYBxBTuiG5+7Fzm09F3C6c/SP3GfVV4csel6M2rFdtfo/4N rSlUxd+tieW3I/oHLtWQ/+M= X-Google-Smtp-Source: AKy350YXHjg34fLflvR+ude6ubhzFwE7wJPF3+v9yxjWMV1do1zeoA+wLilXlgnXWp9IgtkblGlegg== X-Received: by 2002:a17:907:3201:b0:8b1:2eef:154c with SMTP id xg1-20020a170907320100b008b12eef154cmr6195530ejb.0.1680777328619; Thu, 06 Apr 2023 03:35:28 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:49? ([2a0b:e7c0:0:107::aaaa:49]) by smtp.gmail.com with ESMTPSA id xh8-20020a170906da8800b0094809142160sm642128ejb.55.2023.04.06.03.35.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 03:35:27 -0700 (PDT) Message-ID: <26be2c81-9431-6b43-e3e9-52d7d184750e@kernel.org> Date: Thu, 6 Apr 2023 12:35:24 +0200 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Content-Language: en-US To: Peter Zijlstra , Paolo Bonzini Cc: Lai Jiangshan , Dave Hansen , linux-kernel@vger.kernel.org, Lai Jiangshan , "H. Peter Anvin" , Andi Kleen , Andrew Cooper , Andy Lutomirski , Asit Mallick , Cfir Cohen , Dan Williams , David Kaplan , David Rientjes , Erdem Aktas , Jan Kiszka , Joerg Roedel , Juergen Gross , Kees Cook , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Linus Torvalds , Mike Stunes , Raj Ashok , Sean Christopherson , Thomas Gleixner , Tom Lendacky , Tony Luck , kvm@vger.kernel.org, linux-coco@lists.linux.dev, x86@kernel.org References: <20230403140605.540512-1-jiangshanlai@gmail.com> <19035c40-e756-6efd-1c02-b09109fb44c1@intel.com> <3591487f-96ae-3ab7-6ce7-e524a070c9e7@redhat.com> <20230406101254.GI386572@hirez.programming.kicks-ass.net> From: Jiri Slaby Subject: Re: [RFC PATCH 0/7] x86/entry: Atomic statck switching for IST In-Reply-To: <20230406101254.GI386572@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06. 04. 23, 12:12, Peter Zijlstra wrote: > On Tue, Apr 04, 2023 at 07:03:45PM +0200, Paolo Bonzini wrote: >> On 4/4/23 05:17, Lai Jiangshan wrote: >>> The cover letter has 800+ lines of comments. About 100-300 lines >>> of comments will be moved into the code which would make the diffstat >>> not so appealing. >> >> Removing assembly from arch/x86/entry/ and adding English to Documentation/? >> That's _even more_ appealing. :) > > I *much* prefer in-code comments to random gibberish that's instantly > out of date squirreled away somewhere in an unreadable format in > Documentation/ +1 as one can link comments in the code to Documentation easily nowadays. They are sourced and end up in the generated Documentation [1] then. One only needs to type the kernel-doc properly. [1] https://www.kernel.org/doc/html/latest -- js suse labs