From: Dave Hansen <dave.hansen@intel.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Nikolay Borisov <nik.borisov@suse.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCHv5 3/4] x86/tdx: Dynamically disable SEPT violations from causing #VEs
Date: Wed, 3 Jul 2024 07:49:48 -0700 [thread overview]
Message-ID: <3b164525-f797-478a-a75c-1c2bd83086af@intel.com> (raw)
In-Reply-To: <oujihwk2ghwpobsuivxlgflalwxigctjp6nld2jdtz4cbwoqnp@7v3s7ap4ul6u>
On 7/3/24 06:04, Kirill A. Shutemov wrote:
>>> -/* TDCS fields. To be used by TDG.VM.WR and TDG.VM.RD module calls */
>>> +/* TDX TD-Scope Metadata. To be used by TDG.VM.WR and TDG.VM.RD */
>>> +#define TDCS_CONFIG_FLAGS 0x1110000300000016
>> 0x9110000300000016
>>> +#define TDCS_TD_CTLS 0x11104800000017
>> 0x9110000300000017
> Setting bit 63 in these field id is regression in new TDX spec and TDX
> module. It is going to be fixed in next version. Both versions of field
> ids are going to be valid.
I kinda never liked the big ol' magic numbers approach here. But could
we please introduce some helpers here?
Then we'll end up with something like this (if the 0x111 can't be
decomposed):
#define _TDCS_CMD(c) ((0x1110UL << 48) | (c))
#define TDCS_CONFIG_FLAGS _TDCS_CMD(0x16)
#define TDCS_TD_CTLS _TDCS_CMD(0x17)
Then when folks change their mind about what should be in the TDX spec,
we have one place to go fix it up in addition to making this all more
readable.
next prev parent reply other threads:[~2024-07-03 14:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 11:41 [PATCHv5 0/4] x86/tdx: Adjust TD settings on boot Kirill A. Shutemov
2024-06-24 11:41 ` [PATCHv5 1/4] x86/tdx: Introduce wrappers to read and write TD metadata Kirill A. Shutemov
2024-06-24 11:41 ` [PATCHv5 2/4] x86/tdx: Rename tdx_parse_tdinfo() to tdx_setup() Kirill A. Shutemov
2024-06-24 11:41 ` [PATCHv5 3/4] x86/tdx: Dynamically disable SEPT violations from causing #VEs Kirill A. Shutemov
2024-07-03 11:39 ` Nikolay Borisov
2024-07-03 13:04 ` Kirill A. Shutemov
2024-07-03 14:49 ` Dave Hansen [this message]
2024-07-04 13:03 ` Kirill A. Shutemov
2024-07-03 12:22 ` Nikolay Borisov
2024-07-03 13:05 ` Kirill A. Shutemov
2024-06-24 11:41 ` [PATCHv5 4/4] x86/tdx: Enable CPU topology enumeration Kirill A. Shutemov
2024-07-02 16:17 ` Xiaoyao Li
2024-07-03 12:33 ` Kirill A. Shutemov
2024-07-04 10:17 ` [PATCHv5 0/4] x86/tdx: Adjust TD settings on boot Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b164525-f797-478a-a75c-1c2bd83086af@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).