linux-coco.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Vedashree Vidwans <vvidwans@nvidia.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: salman.nabi@arm.com, lpieralisi@kernel.org, mark.rutland@arm.com,
	andre.przywara@arm.com, ardb@kernel.org, chao.gao@intel.com,
	linux-arm-kernel@lists.infradead.org, linux-coco@lists.linux.dev,
	linux-kernel@vger.kernel.org, sdonthineni@nvidia.com,
	vsethi@nvidia.com, vwadekar@nvidia.com
Subject: Re: [RFC PATCH 2/3] firmware: smccc: LFA: refactor, add device node support
Date: Mon, 13 Oct 2025 13:09:58 -0700	[thread overview]
Message-ID: <42c53659-7d60-4f5b-93a6-d3074f72aedf@nvidia.com> (raw)
In-Reply-To: <20251009-calculating-glorious-oriole-ceccf6@sudeepholla>



On 10/9/25 01:13, Sudeep Holla wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Wed, Oct 08, 2025 at 07:09:06PM +0000, Vedashree Vidwans wrote:
>> - Add support for LFA device node in the kernel driver. Implement
>> probe() to register LFA interrupt and threaded interrupt service
>> function.
>> - CPUs will be rendezvoused during activation.
>> - On IRQ, driver will query FW components then triggers activation of
>> capable and pending components.
>> - Mutex synchronization is implemented to avoid concurrent LFA updates
>> through interrupt and sysfs interfaces.
>> - Refactor LFA CANCEL logic into independent lfa_cancel() function.
>> - Enhance PRIME/ACTIVATION functions to touch watchdog and implement
>> timeouts.
>>
>> Signed-off-by: Vedashree Vidwans <vvidwans@nvidia.com>
>> ---
>>   drivers/firmware/smccc/lfa_fw.c | 299 ++++++++++++++++++++++++++++----
> 
> I was expecting to the devicetree binding based on $subject but no.
> So this patch can't be reviewed without one.
> 
> --
> Regards,
> Sudeep

Thank you for your comments, I will include the devicetree binding
in the next iteration.

Regards,
Veda

  reply	other threads:[~2025-10-13 20:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-08 19:09 [RFC PATCH 0/3] Arm LFA: Improvements and interrupt support Vedashree Vidwans
2025-10-08 19:09 ` [RFC PATCH 1/3] firmware: smccc: LFA: use smcc 1.2 Vedashree Vidwans
2025-10-11  0:02   ` Andre Przywara
2025-10-13 20:59     ` Vedashree Vidwans
2025-10-08 19:09 ` [RFC PATCH 2/3] firmware: smccc: LFA: refactor, add device node support Vedashree Vidwans
2025-10-09  8:13   ` Sudeep Holla
2025-10-13 20:09     ` Vedashree Vidwans [this message]
2025-10-10 17:35   ` Salman Nabi
2025-10-13 20:47     ` Vedashree Vidwans
2025-10-14 10:58       ` Andre Przywara
2025-10-14 13:44       ` Salman Nabi
2025-10-11  0:03   ` Andre Przywara
2025-10-13 21:09     ` Vedashree Vidwans
2025-10-08 19:09 ` [RFC PATCH 3/3] firmware: smccc: LFA: modify activation approach Vedashree Vidwans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42c53659-7d60-4f5b-93a6-d3074f72aedf@nvidia.com \
    --to=vvidwans@nvidia.com \
    --cc=andre.przywara@arm.com \
    --cc=ardb@kernel.org \
    --cc=chao.gao@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=salman.nabi@arm.com \
    --cc=sdonthineni@nvidia.com \
    --cc=sudeep.holla@arm.com \
    --cc=vsethi@nvidia.com \
    --cc=vwadekar@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).