From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f33.google.com (mail-wr2-f33.google.com [74.125.225.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4485C282F34 for ; Fri, 18 Sep 2026 10:03:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.97 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789725832; cv=none; b=GA3We97osVLf15pGmGYWdwchtE2OmRGpRscgXe4QAW1d1DDaW/MufpHgQGhIOFBOzk6Hl1xCgy5wneFk6wIz4sNqPYnodRdfwunrx/5x05SPRCu7dL/y/QvqMX9pyULY6GYWAFZcSBwYnOhatTKgTV9hXOYKnchUSN4zba/0flw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789725832; c=relaxed/simple; bh=noKoDpx4dUuDSwuuZTUe91oT6baf4TQ4KDGaAG+Fhbg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l/D7pIPtrSF3fA+Hhh0IGRETWUuRdDMh1pKIkA/wy32x4cdEO5HQsNSzqT0JmngEe9Wf4jtBiFFZkoMFF9LpZL/syMk5pOwDSjfqmY682eY4klJlN2LXA8RHb0TvrLiDDw9JZ6CTF4pxogP3yTvcSXSLjEJF9fR13W+0AWnjO8c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=OYS7Y5av; arc=none smtp.client-ip=74.125.225.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="OYS7Y5av" Received: by mail-wr2-f33.google.com with SMTP id ffacd0b85a97d-482f6351831so265962f8f.1 for ; Fri, 18 Sep 2026 03:03:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1789725828; x=1790330628; darn=lists.linux.dev; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=C5qxAIhr/CpV8rdb7Qf23Nk2T66hiid2IOqRrMWFtsQ=; b=OYS7Y5avOUapYXlPjXH7H2jrHJhOcHS+gSYthKMUxiX5TZls0jDryXjKz8bJpk1fiO rO4Xoqchg68LToECU1B3EWGYGTyrk49k0uIFvV+5bA67NE9iIxOTPokCQ7PXxr4ATgCY J2NZcRff1zwBM2+FuqC1kgrGmWiwZWRa4IS7Kky4Ry0oFZON8plxfFHy0blHKKo6oSB7 ZIa6yicDyGVR+m6yrZcKsshMRIB5rPVJ7VX0yS7MM7Ylw4kFCVFChDCdpWtAqBw91eXE 0NXpEoZD2sjxMR119HHZknWtk5H9KYMZfMfnc0Hock1xo4xdnN4pnI94qvvsRi3X/7sf 9/Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789725828; x=1790330628; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=C5qxAIhr/CpV8rdb7Qf23Nk2T66hiid2IOqRrMWFtsQ=; b=04428J9kuFPnwSmogtCoJ9+pBgy5WZZ56A88FKDiDcfqq7ulrWIMykb/4jMIte8sNW CgjIAWmdjEpsP2m9fd2WsQALx8hcQmbYu52VzG+f5jZAO0siLFoiwqninfkze78+Mjhd UHI1YbfyfTpivIcvQpn/2oI9pivkicdnS2bQIc7yDH7RD/MB28NXO9e2C930yFAccaw6 zOWgHjB/JCq3C6ZJ93IqrFNLOJWN73BCABDogatGEOE+Y+8t4FlrzjEhGOwXy4aQVt+F pB5UWfPaWcYEtpmA6XFHWuid819ogrHmmQxbZDXfYqcLYCpSNVVk4nP/v7F+IZV4/Zlq uCbA== X-Forwarded-Encrypted: i=1; AKwUvBwSyTri832UF0ksAehMkr1Va5ZDjkI9dNQe/WidSpdfipHCvlxsbKo0Ri+Nt3frckdjXImLKsWzTNRE@lists.linux.dev X-Gm-Message-State: AFuF++mEoUd02LGuVqIVGFb/rCymzGwX1kjcRtlGW6/8XTKa6tL+P/Dv 6HgD17r5+UVybinNOcs1uzKptMSvAcxUXgfrBjvda9RQB/4UjWqJWtcKSqiuLqPRB08= X-Gm-Gg: AYBFou1qbIoj81x4bDeQ55FSaocEJ2GXbvqRB3fb2hCsVJGxthW4pmu8CnJYyLp34+K xNLk7a08P5X/Jta6u0ZNPBWa3GBuoXPbl+v2W4UCMY7MzBuSVSXijshcAFqtRcDtESxmiRfCZsB dXIz+9WRj7B/gkeW0GH8Q38hOO07Fb+ia7j5u8JUjm1Z4uwksbaFftE+pnwKXhOEMyF8ESo/6/+ 2lCkbOUdGiV3CR5dr6epcxXx0G9B18sqRLN7++ZIL/SB1zhkk4ynCUJXxSUyAV1eSy1DCDHpAHX rZEF2z19HU/DTtLFrA6hgeLKLSSI6l7QTUqSoO+Y7IfGLb0bop4U3Pb7SxvjLNQ6VIDFaKoNhBv R1BZM1ECCyb9tkgjQgftLwl1w7cJJUaoTvxCoFTq0LevYmTErOCHcYkgfX8WuCg0KjOY5zbsDA9 sHt6VpaL13le7PI/8j5AbiIXl7kYn3b2K10FeU5xWxYcAmEaooEYOen7GA+Odeo/jkbYU1O4Tps HIRM576p9Gj49l+lU3ZatVx X-Received: by 2002:a05:6000:2382:b0:487:c76:4d12 with SMTP id ffacd0b85a97d-4871e2132c3mr2748208f8f.11.1789725827685; Fri, 18 Sep 2026 03:03:47 -0700 (PDT) Received: from [192.168.0.20] (nborisov.ddns.nbis.net. [185.218.66.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4872008678bsm3025594f8f.35.2026.09.18.03.03.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Sep 2026 03:03:47 -0700 (PDT) Message-ID: <477fe308-0028-4ce6-a57e-fefa1a611126@suse.com> Date: Fri, 18 Sep 2026 13:03:46 +0300 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] x86/tdx: Harden exports To: Peter Fang Cc: dave.hansen@linux.intel.com, rick.p.edgecombe@intel.com, xiaoyao.li@intel.com, linux-coco@lists.linux.dev, kvm@vger.kernel.org, x86@kernel.org, =?UTF-8?Q?Michal_Koutn=C3=BD?= References: <20260917110714.1587301-1-nik.borisov@suse.com> From: Nikolay Borisov Content-Language: en-US Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 18.09.26 г. 12:36 ч., Peter Fang wrote: > On Thu, Sep 17, 2026 at 02:07:14PM +0300, Nikolay Borisov wrote: >> tdx_* function aren't supposed to be used by the kernel at large, rather >> they are mostly used by KVM and a very small number of them are exposed >> via the tdx-guest/tdx-host drivers. Reflect this fact in their > > "exposed via" sounds a bit off? Perhaps "exposed to"? What I meant was that the functionality of those functions is exposed via the tdx-guest/tdx-host drivers. I.e those drivers present interfaces to userspace to enable them to use the functionality of said functions. I.e those functions are only used by those drivers. > > And this patch only touches functions exported to tdx-guest... In fact > tdx-host only uses functions from arch/x86/virt/vmx/tdx/ (guest code vs > host code). Maybe the log could be a bit more precise. Fair point. > >> EXPORT_SYMBOL* declarations. >> >> Reported-by: Michal Koutný >> Signed-off-by: Nikolay Borisov >> --- >> >> V2: >> * Drop the change to tdx_kvm_hypercall >> >> arch/x86/coco/tdx/tdx.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >>