From: Dave Hansen <dave.hansen@intel.com>
To: Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"Kirill A . Shutemov" <kas@kernel.org>
Cc: Rick Edgecombe <rick.p.edgecombe@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-coco@lists.linux.dev
Subject: Re: [PATCH v5] virt: tdx-guest: Handle GetQuote request error code
Date: Tue, 2 Dec 2025 16:03:45 -0800 [thread overview]
Message-ID: <56c01575-c0e3-43f3-a6c6-bf62fcbe4f5d@intel.com> (raw)
In-Reply-To: <369b819c-5235-424d-a8c9-c7c45a9fd4db@linux.intel.com>
On 12/2/25 16:00, Kuppuswamy Sathyanarayanan wrote:
> The reason the kernel must parse the status field is that the failure
> code is only available in the header portion of the shared GPA buffer
> populated by the VMM. Userspace currently does not have access to this
> header since we only expose the Quote payload itself. Because userspace
> cannot directly interpret the VMM status codes, the kernel needs to parse
> them and return appropriate generic error codes.
That's kinda the key to this.
Users are poking at sysfs and expect (near) universal explicit errors.
Are they even doing this from shell scripts most of the time?
Also, please don't just keep tacking gunk onto the changelog. Start
cutting out the cruft, please.
next prev parent reply other threads:[~2025-12-03 0:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 22:22 [PATCH v5] virt: tdx-guest: Handle GetQuote request error code Kuppuswamy Sathyanarayanan
2025-12-02 22:46 ` Dave Hansen
2025-12-03 0:00 ` Kuppuswamy Sathyanarayanan
2025-12-03 0:03 ` Dave Hansen [this message]
2025-12-03 18:04 ` Sathyanarayanan Kuppuswamy
2025-12-03 18:16 ` Dave Hansen
2025-12-05 0:20 ` Sathyanarayanan Kuppuswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56c01575-c0e3-43f3-a6c6-bf62fcbe4f5d@intel.com \
--to=dave.hansen@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=kas@kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox