From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A3EE489FCD for ; Fri, 9 Oct 2026 08:02:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791532976; cv=none; b=W3/MRJZHKZFb5An4z3e2+F/Z1OPUxF/4huqXaXTyf53wbLvRAyK75Vw2TVnSj0kvRpWIVe3M9cX5p/9o1BAQL3u7V1jl9aQx0Onf4OD9EnTh8Iv2IVuTDrDfcs0LptYirlSFO1Y5AwV5zMUqt3i88ISTwl9lv6P+AehISpB/hpw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791532976; c=relaxed/simple; bh=K0Rujk12uAeKYeS3MopyyDkqIWwp9f+QzTngzNoCAWg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ftik23/UOr6Dya6r3l8EsHjotcaLUrceo/hK342dIyk5tDCTj4t0OtscSVSUIxutpQyoe9VKVgviDq/evCywej7gYNU2n2nAlRsBzSsW1WF2eQoWPTW95zHMW8+WLNamZnivcpHKcf2so8ECwN1M69z8FwjELSyFEpKXxr/HSHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=i3abN+T0; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="i3abN+T0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1791532975; x=1823068975; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=K0Rujk12uAeKYeS3MopyyDkqIWwp9f+QzTngzNoCAWg=; b=i3abN+T0AP3DhVLk2j8Ucw3hgI4VoVy7WBm/JZY5Afkx3xEJFTeqkteo mT3Y9901QrqM8u2LgfMlG0e7jViW2ZQWIfWzbDGdsj2f6Ur+4E+FehhUD oATVrXHEaagc1BdOtQ8aaAvaHT0vnp338L+YDKNVjbcm/5liBLZX0DNF/ jJ/jXyaZvmW02QAf2lBTe19jq9G9XTMGHVjkEOy3OuEHXdG5he4J+x9Rz qzcfKqVGf58L53xWMqxLozb0LKKGmibXDh3GrW/I/YJoLiA+5yiF9haw1 0lTX44I15okarMazyCJLJFjMTxAiK3d1+TrXnlDlRt8NohEJTaPmsZI+O g==; X-CSE-ConnectionGUID: oagEQxkgRSyHkfApmCgrtQ== X-CSE-MsgGUID: n8tBUt/gQJ6wYJgPcBsg3A== X-IronPort-AV: E=McAfee;i="6800,10657,11929"; a="224328" X-IronPort-AV: E=Sophos;i="6.27,147,1787036400"; d="scan'208";a="224328" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2026 01:02:54 -0700 X-CSE-ConnectionGUID: wSz6PIOQSKmk9kFJq0Hu6g== X-CSE-MsgGUID: EjOPerSgTzyC0rzXyiu/TQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,147,1787036400"; d="scan'208";a="201120" Received: from yizheliu-ivm.ccr.corp.intel.com (HELO [10.238.208.114]) ([10.238.208.114]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2026 01:02:46 -0700 Message-ID: <59ec42fd-56db-47e4-a4e1-632b692cf60e@intel.com> Date: Fri, 9 Oct 2026 16:02:40 +0800 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v15 15/23] KVM: selftests: Call KVM_TDX_INIT_VCPU when creating a new TDX vcpu To: Lisa Wang , Andrew Jones , Ackerley Tng , Binbin Wu , Chao Gao , Chenyi Qiang , Dave Hansen , Erdem Aktas , Ira Weiny , Isaku Yamahata , Kiryl Shutsemau , linux-kselftest@vger.kernel.org, Paolo Bonzini , "Pratik R. Sampat" , Reinette Chatre , Rick Edgecombe , Roger Wang , Ryan Afranji , Sagi Shahar , Sean Christopherson , Shuah Khan , Oliver Upton Cc: Jeremiah McReynolds , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, x86@kernel.org References: <20261001-tdx-selftests-v15-0-7c62a5d8a992@google.com> <20261001-tdx-selftests-v15-15-7c62a5d8a992@google.com> Content-Language: en-US From: Xiaoyao Li In-Reply-To: <20261001-tdx-selftests-v15-15-7c62a5d8a992@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/2/2026 3:37 AM, Lisa Wang wrote: > +struct kvm_vcpu *vm_arch_vcpu_add(struct kvm_vm *vm, u32 vcpu_id) > +{ > + struct kvm_mp_state mp_state; > + struct kvm_vcpu *vcpu; > + struct kvm_regs regs; > + rebase mess up due to the previous patch. > vcpu = __vm_vcpu_add(vm, vcpu_id); > - vcpu_init_cpuid(vcpu, kvm_get_supported_cpuid()); > - vcpu_init_sregs(vm, vcpu); > - vcpu_init_xcrs(vm, vcpu); > > - /* Setup guest general purpose registers */ > - vcpu_regs_get(vcpu, ®s); > - regs.rflags = regs.rflags | 0x2; > - regs.rsp = kvm_allocate_vcpu_stack(vm); > - vcpu_regs_set(vcpu, ®s); > + /* > + * Both kvm_get_supported_cpuid() (for legacy VMs) and KVM_TDX_GET_CPUID > + * (for TDX VMs) return VM-scoped CPUID. e.g. the APIC ID isn't > + * populated per vCPU. This is fine because KVM selftests don't > + * currently test CPUID topology enumeration. > + */ > + if (is_tdx_vm(vm)) { > + tdx_vcpu_init(vm, vcpu); > + } else { > + vcpu_init_cpuid(vcpu, kvm_get_supported_cpuid()); > + > + vcpu_init_sregs(vm, vcpu); > + vcpu_init_xcrs(vm, vcpu); > + > + /* Setup guest general purpose registers */ > + vcpu_regs_get(vcpu, ®s); > + regs.rflags = regs.rflags | 0x2; > + regs.rsp = kvm_allocate_vcpu_stack(vm); > + vcpu_regs_set(vcpu, ®s); > + } > > /* Setup the MP state */ > mp_state.mp_state = 0;