From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7154A328B70; Fri, 31 Oct 2025 08:59:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901153; cv=none; b=cHG72jr5l2CG349AdB0cReSAk3G2IVliea5HyE9O3hG2MZJp/+x/FAk5pD3u9Y5KCrchpRWGVY6pr+iyEEmT4F6e/MqTv0c3+Xv+BQ97O7JHpQnnVW10VW2Nx1zTI9uQuS592VojF7Wh2FK4kVuGLeBnxgfI5/McyZpZNGsXWyg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761901153; c=relaxed/simple; bh=14teRbdSNDZoo6LY1BdIEFiTD+Kt/E9bpeaMX41fhsM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KZk08QYqWhXa0Iul7ZAi5eIG2yvheSnxaqsj2LB2iMD9gvqeGQnhQur6miSyKi4JgCwLvKi9z/PVlimjek+SwwDcPVI+dJoWgkURCC4jWifbXKh1Pkz46xxX254hRqwLlxVQH7cTFYTBcjfs1v5cg+83jLZ11bSQvoT5OzU21S4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fACj2G1h; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fACj2G1h" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761901152; x=1793437152; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=14teRbdSNDZoo6LY1BdIEFiTD+Kt/E9bpeaMX41fhsM=; b=fACj2G1huC3BjSANlqRNVV6cQ6XESOtH1ut6OKV/gj0KHYJpqwNwYfHz J/bDKESFqWHxfwMAmxvjNp9CdZepgyXsYflyfacK+TP4Fo4BO7TLTBvBC vWhtPQF/IYTY4qr2/GNkJKD2IUlGTx24kwKl2czh7TgjvTxrSK1TerG/N l4btOrpy3Bnpha/S3avLt1RgyBWxw5dXvlD2I0UosoERogJj2iQ9X9Trx Tkc89Wo7tzGGcUy3WAHfbAMynoD6NVFJ7yYmoYsVOBxH5frpPY1bAhhRQ f+tUPHtzwLthsWOA7TsmU0pgdTcT2btPizSs2P9502+UiSPfGMRwZTTMi g==; X-CSE-ConnectionGUID: iyGEZkiySO2J8QCo9S2dRQ== X-CSE-MsgGUID: X4v4xmLTSb2dYrODUbj9UA== X-IronPort-AV: E=McAfee;i="6800,10657,11598"; a="67917207" X-IronPort-AV: E=Sophos;i="6.19,268,1754982000"; d="scan'208";a="67917207" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2025 01:59:11 -0700 X-CSE-ConnectionGUID: Qkn6DZO5Rceyyp8KD2OnrQ== X-CSE-MsgGUID: hAjIabqjQHemJifWFRIz7Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,269,1754982000"; d="scan'208";a="186119255" Received: from binbinwu-mobl.ccr.corp.intel.com (HELO [10.124.240.28]) ([10.124.240.28]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2025 01:59:02 -0700 Message-ID: <5eaab97d-30c3-46a5-8be2-2ea1ef28e71e@linux.intel.com> Date: Fri, 31 Oct 2025 16:58:59 +0800 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 18/28] KVM: TDX: Combine KVM_BUG_ON + pr_tdx_error() into TDX_BUG_ON() To: Sean Christopherson Cc: Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Madhavan Srinivasan , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Paolo Bonzini , "Kirill A. Shutemov" , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, Ira Weiny , Kai Huang , Michael Roth , Yan Zhao , Vishal Annapurve , Rick Edgecombe , Ackerley Tng References: <20251030200951.3402865-1-seanjc@google.com> <20251030200951.3402865-19-seanjc@google.com> Content-Language: en-US From: Binbin Wu In-Reply-To: <20251030200951.3402865-19-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/31/2025 4:09 AM, Sean Christopherson wrote: > Add TDX_BUG_ON() macros (with varying numbers of arguments) to deduplicate > the myriad flows that do KVM_BUG_ON()/WARN_ON_ONCE() followed by a call to > pr_tdx_error(). In addition to reducing boilerplate copy+paste code, this > also helps ensure that KVM provides consistent handling of SEAMCALL errors. > > Opportunistically convert a handful of bare WARN_ON_ONCE() paths to the > equivalent of KVM_BUG_ON(), i.e. have them terminate the VM. If a SEAMCALL > error is fatal enough to WARN on, it's fatal enough to terminate the TD. > > Reviewed-by: Rick Edgecombe > Signed-off-by: Sean Christopherson Reviewed-by: Binbin Wu