From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34B2F19D093 for ; Tue, 9 Jul 2024 15:02:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720537357; cv=none; b=ZDFmkxcyCNb2pQYqSwM5WwcnKY4xHM37PB4XzqWkgKyfFT37ZysTonLx0sE6kyuiAhY2/SseOUsEhOh5OdV9JMnMTzmvRGzG/viZlcuXCZXy1gKTUJBr2wuFzfDOTbzUY/f6C3FY9tqrUtcXvnqBHmWZSeFkcno3TqL2/Y6+NI0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720537357; c=relaxed/simple; bh=Pve8kD2qR5k9am//RgaYXCPw5RIktwMh8PvUr5OnbUM=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=Akxrw5EaGQFfzNXWEH4UtRzXK84k8d/BjuHo7yOmhwys3sneDkwS8M6eea8IvTEAm2/b98/gUJSKpyAmWtFPBW+GqbCkEaKe87NZNbj2WwzEY+rfKk1f9Nr8TaY2IDCmrg1P8WsyT1bLhdw41SxJtHg45xXcJfyqsUogede5+GY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=IpIVAZdU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="IpIVAZdU" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 469AX5Bj021735; Tue, 9 Jul 2024 15:00:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vrRha6v1MS8bhWVcMku5sIvVckGeI7S6pxyAygH9t40=; b=IpIVAZdU289FVNpJ tZYXIkp4i6652FCJtThP3Q+1S9qxa49qSkbCGQRBUJVKi8Qtuvqxud1xlSDKIpKd NwZ9fyFD0GhC8rmR/7YMm6JYPOlVqkuwkCwTv7zq5WZnwZuXdNSNH9Nvs+pPvYzS fry2xreqboUesoD9BsQ4GrL6F1zxSgGLLG/DJz1cQF/KLKigFdrHgGMwPGER626n iztoZr/HJpJs7aZxncaluxbjHKDzjaaqx/gPXehk++PqnOw2pqbPvSFFc+hLc1dy Rc9mqTpX3fmUklcqH5f9i1FH0+LPQIr+0iQXQjOaLqftU7blP9Sa1bfxD4US/M8H nZTOpg== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 406wgwprf7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jul 2024 15:00:57 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 469F0toM025538 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 9 Jul 2024 15:00:55 GMT Received: from [10.81.24.74] (10.49.16.6) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 9 Jul 2024 08:00:54 -0700 Message-ID: <647515b7-e5a2-46d8-9c03-a2b68c434070@quicinc.com> Date: Tue, 9 Jul 2024 08:00:54 -0700 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 07/18] spdm: Introduce library to authenticate devices Content-Language: en-US To: Lukas Wunner , Jonathan Cameron , Bjorn Helgaas , David Howells , Herbert Xu , "David S. Miller" , David Woodhouse , James Bottomley , , , , , CC: , David Box , Dan Williams , "Li, Ming" , Ilpo Jarvinen , Alistair Francis , Wilfred Mallawa , Damien Le Moal , Alexey Kardashevskiy , Dhaval Giani , Gobikrishna Dhanuskodi , Jason Gunthorpe , Peter Gonda , Jerome Glisse , Sean Christopherson , Alexander Graf , Samuel Ortiz , Eric Biggers , Stefan Berger References: From: Jeff Johnson In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: yjb8rUAeZdBFm13IhaXy-1T20LJa1kbO X-Proofpoint-ORIG-GUID: yjb8rUAeZdBFm13IhaXy-1T20LJa1kbO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-09_04,2024-07-09_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=787 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2406140001 definitions=main-2407090098 On 6/30/24 12:42, Lukas Wunner wrote: ... > diff --git a/lib/spdm/core.c b/lib/spdm/core.c > new file mode 100644 > index 000000000000..f06402f6d127 > --- /dev/null > +++ b/lib/spdm/core.c > @@ -0,0 +1,425 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * DMTF Security Protocol and Data Model (SPDM) > + * https://www.dmtf.org/dsp/DSP0274 > + * > + * Core routines for message exchange, message transcript, > + * signature verification and session state lifecycle > + * > + * Copyright (C) 2021-22 Huawei > + * Jonathan Cameron > + * > + * Copyright (C) 2022-24 Intel Corporation > + */ ... > + > +MODULE_LICENSE("GPL"); This is missing a MODULE_DESCRIPTION(). Building a module without a MODULE_DESCRIPTION() will result in a warning when building with make W=1.