From: Dan Williams <dan.j.williams@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Williams <dan.j.williams@intel.com>
Cc: <linux-coco@lists.linux.dev>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Dionna Amalie Glaze <dionnaglaze@google.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Peter Gonda <pgonda@google.com>,
Samuel Ortiz <sameo@rivosinc.com>, <peterz@infradead.org>,
<linux-kernel@vger.kernel.org>, <tglx@linutronix.de>
Subject: Re: [PATCH v3 2/5] configfs-tsm: Introduce a shared ABI for attestation reports
Date: Wed, 30 Aug 2023 13:57:01 -0700 [thread overview]
Message-ID: <64efad1d3b32a_29e2202949f@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <2023083029-wackiness-lilac-39dd@gregkh>
Greg Kroah-Hartman wrote:
[..]
> > +int register_tsm(const struct tsm_ops *ops, void *priv,
> > + const struct config_item_type *type);
> > +int unregister_tsm(const struct tsm_ops *ops);
>
> Usually it's "noun_verb" for stuff that you export to the global
> namespace these days.
>
> So perhaps tsm_register() and tsm_unregister()?
>
> Either way, it's your call:
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sure, noun_verb works for me, will make that change. Thanks Greg.
next prev parent reply other threads:[~2023-08-30 20:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 19:33 [PATCH v3 0/5] configfs-tsm: Attestation Report ABI Dan Williams
2023-08-30 19:33 ` [PATCH v3 1/5] virt: coco: Add a coco/Makefile and coco/Kconfig Dan Williams
2023-08-30 20:48 ` Kuppuswamy Sathyanarayanan
2023-08-30 19:33 ` [PATCH v3 2/5] configfs-tsm: Introduce a shared ABI for attestation reports Dan Williams
2023-08-30 20:45 ` Greg Kroah-Hartman
2023-08-30 20:57 ` Dan Williams [this message]
2023-08-30 22:08 ` Kuppuswamy Sathyanarayanan
2023-08-31 1:24 ` Dan Williams
2023-08-31 21:42 ` Dionna Amalie Glaze
2023-08-31 22:13 ` Dan Williams
2023-09-01 18:06 ` Thomas Gleixner
2023-09-01 18:47 ` Dan Williams
2023-09-01 19:06 ` Thomas Gleixner
2023-08-30 19:33 ` [PATCH v3 3/5] virt: sevguest: Prep for kernel internal {get, get_ext}_report() Dan Williams
2023-08-30 19:33 ` [PATCH v3 4/5] mm/slab: Add __free() support for kvfree Dan Williams
2023-08-30 20:46 ` Greg Kroah-Hartman
2023-09-07 8:59 ` Gupta, Pankaj
2023-08-30 19:33 ` [PATCH v3 5/5] virt: sevguest: Add TSM_REPORTS support for SNP_{GET, GET_EXT}_REPORT Dan Williams
2023-09-01 15:25 ` Jeremi Piotrowski
2023-09-01 16:38 ` Dan Williams
2023-09-04 2:14 ` Huang, Kai
2023-09-04 2:57 ` Kuppuswamy Sathyanarayanan
2023-09-05 23:21 ` Huang, Kai
2023-09-01 16:04 ` [PATCH v3 0/5] configfs-tsm: Attestation Report ABI Jeremi Piotrowski
2023-09-01 16:51 ` Dan Williams
2023-09-07 8:04 ` Samuel Ortiz
2023-09-25 19:26 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64efad1d3b32a_29e2202949f@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dionnaglaze@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=pgonda@google.com \
--cc=sameo@rivosinc.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).