From: Dave Hansen <dave.hansen@intel.com>
To: Xu Yilun <yilun.xu@linux.intel.com>,
dave.hansen@linux.intel.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Cc: kas@kernel.org, rick.p.edgecombe@intel.com, yilun.xu@intel.com,
linux-coco@lists.linux.dev
Subject: Re: [PATCH v4] x86/virt/tdx: Formalize SEAMCALL version encoding support
Date: Tue, 4 Aug 2026 09:49:36 -0700 [thread overview]
Message-ID: <64f02f52-434c-4733-8e9b-4dd5daa9e14b@intel.com> (raw)
In-Reply-To: <20260804085054.190847-1-yilun.xu@linux.intel.com>
On 8/4/26 01:50, Xu Yilun wrote:
> SEAMCALL invokes TDX module functions using a function number and
Maybe I'm just grumpy this morning, but I'm not a fan of this
description. It seems to just be growing complexity and not actually
explaining the situation better.
Also, this is going to be subtle but it starts talking (I think) about
the SEAMCALL _instruction_. The thing this patch should be talking about
is SEAMCALLs themselves. The instruction is a _part_ that, sure. But the
instruction itself actually has very little to do with the ABI.
I just feel like the whole explanation here is going off in a different
direction than we need.
prev parent reply other threads:[~2026-08-04 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 8:50 [PATCH v4] x86/virt/tdx: Formalize SEAMCALL version encoding support Xu Yilun
2026-08-04 16:49 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64f02f52-434c-4733-8e9b-4dd5daa9e14b@intel.com \
--to=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=kas@kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=x86@kernel.org \
--cc=yilun.xu@intel.com \
--cc=yilun.xu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox