Re: [PATCH resend v6 07/10] PCI/IDE: Add IDE establishment helpers

[<dan.j.williams@intel.com>]

Alexey Kardashevskiy wrote:
[..]
> > diff --git a/drivers/pci/ide.c b/drivers/pci/ide.c
> > index 05ab8c18b768..608ce79d830f 100644
> > --- a/drivers/pci/ide.c
> > +++ b/drivers/pci/ide.c
> > @@ -5,8 +5,12 @@
> >   
> >   #define dev_fmt(fmt) "PCI/IDE: " fmt
> >   #include <linux/bitfield.h>
> > +#include <linux/bitops.h>
> 
> Compiles without it.

As Bjorn pointed out in his review, the recommendation is include what
you use:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submit-checklist.rst?id=v6.17-rc7#n17

> > diff --git a/include/linux/pci-ide.h b/include/linux/pci-ide.h
> > new file mode 100644
> > index 000000000000..5a7ffb1d826f
> > --- /dev/null
> > +++ b/include/linux/pci-ide.h
> > @@ -0,0 +1,73 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/* Copyright(c) 2024 Intel Corporation. All rights reserved. */
> > +
> > +/* PCIe 6.2 section 6.33 Integrity & Data Encryption (IDE) */
> 
> A nit: may be refer to the version where it appeared first (r6.1).

Bjorn asked that I move all the specification references forward [1], and in
this case I missed moving this one to r7.

[1]: http://lore.kernel.org/20250807212716.GA62016@bhelgaas