Re: [PATCH v7 2/9] PCI/IDE: Enumerate Selective Stream IDE capabilities

dan.j.williams
2025-10-31T00:34:16Z

Alexey Kardashevskiy wrote:
[..]
> > I haven't been following this, but is there an advantage to referring
> > to r6.1 instead of r7.0? I assume newer revisions of the spec only
> > add useful things and don't remove anything.
>
> We are adding here a bunch of macros for all the flags defined in the spec but we are not using many of them yet (or ever). And we are not adding the XT _support_ (which came in r7.0) right now, only the flags.
>
> So what is the rule -
> 1) we add only bare minimum of the flags which we have the user for right now?
> 2) we add everything defined by the spec which the commit log refers to?
>
> Right now it is neither but if the commit log said "r6.1" - then this
> patch is a complete set of flags. I do not care all that much, just
> noticed some inconsistency when I recently touched "lspci" so feel
> free to ignore the above :) Thanks,

It is a good catch. If it were not for me trying to calm down the
changes on this base set so that we can call it "done" I would go add
the XT bits now.

In this case it is purely incremental with no near term user, so let it
arrive post base series.