From: <dan.j.williams@intel.com>
To: Li Ming <ming.li@zohomail.com>, <helgaas@kernel.org>,
<dan.j.williams@intel.com>
Cc: <linux-pci@vger.kernel.org>, <linux-coco@lists.linux.dev>,
<linux-kernel@vger.kernel.org>, Li Ming <ming.li@zohomail.com>
Subject: Re: [PATCH v2 1/1] PCI/IDE: Fix using wrong VF ID for RID range calculation
Date: Thu, 22 Jan 2026 17:35:50 -0800 [thread overview]
Message-ID: <6972d0762f71e_1d3310065@dwillia2-mobl4.notmuch> (raw)
In-Reply-To: <20260114111455.550984-1-ming.li@zohomail.com>
I will change this subject to "PCI/IDE: Fix off by one error calculating VF RID range"
Li Ming wrote:
> When allocate a new IDE stream for a PCI device in SR-IOV case, the RID
> range of the new IDE stream should cover all VFs of the device. VF ID
> range of a PCI device is [0, num_VFs - 1], so should use (num_VFs - 1)
> as the last VF's ID.
This can be even more succinct / to the point:
---
The VF ID range of an SR-IOV device is [0, num_VFs - 1].
pci_ide_stream_alloc() mistakenly uses num_VFs to represent the last ID.
Fix that off by one error to stay in bounds of the range.
---
...but otherwise this looks good to me. Thanks!
prev parent reply other threads:[~2026-01-23 1:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 11:14 [PATCH v2 1/1] PCI/IDE: Fix using wrong VF ID for RID range calculation Li Ming
2026-01-19 2:21 ` Xu Yilun
2026-01-23 1:35 ` dan.j.williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6972d0762f71e_1d3310065@dwillia2-mobl4.notmuch \
--to=dan.j.williams@intel.com \
--cc=helgaas@kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ming.li@zohomail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox