From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB3E120B20 for ; Tue, 8 Oct 2024 02:56:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728356210; cv=none; b=dA/dpd7BNMOxO+QADP8Ar7+ddvebnhCk8CJmnjp7XwJzSy+e84D16LjAZpedaTwQfUDtz1Ni0ZPXFddW/lgfTOWStJXy1JXMdmK9eCxcZW7I3mX2VFS/XrLDkg7WaQ1Pz9JrC5+fxr/ZHdasSQ2xsF/aI3DDMzr2n6zyv2usTYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728356210; c=relaxed/simple; bh=JD5rRprLSwx+mhh0teGCAAawEXaNzQDmovD5hjPdgJM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gcEuWkFpI/4sHyX3mXvuWmYPFI026fZKXWV/ccimQCdIF/0F8Z8VP05PEc5hj0qw226StUZwCEmnceX+t+Kh9EEwZJRHTnuwd9a9BYFUzYtHfrLJ90GX2SM/pWJiJ82iiPEpvR28vcvEI1XLZ+pCghNgdmHOrs0LRtKCMQEko2U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VxYFyvgV; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VxYFyvgV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728356207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KM6xf6sEqcjRtyhQgAbYMNmNaySSsAseblPrEZ4b2lY=; b=VxYFyvgVdWZll6kyvqSyTeWvEAZZp//sZf4PZ3mgki401BrxPU6xWVbTqyu84g8I7KZeyd GiI2+xDok2oVPk8t6CzX2GwKxggoTrdjPB9whs3lXXelYr8zzXercTatlkDXHp3XZHaUwY W7xHzKXoAvgMORw5NpnfoKVSGVCIKE0= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-483-Bc1E7cnTOVKNncw99-al1w-1; Mon, 07 Oct 2024 22:56:46 -0400 X-MC-Unique: Bc1E7cnTOVKNncw99-al1w-1 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-2e2859da7c2so191561a91.2 for ; Mon, 07 Oct 2024 19:56:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728356205; x=1728961005; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KM6xf6sEqcjRtyhQgAbYMNmNaySSsAseblPrEZ4b2lY=; b=qZiYbtvRG3ive7SKBZpoJA/PyCalAEPOW8XZWOT9HATO3MaQT9dLhGvSAT11jQIp7B FfuUU8PvebyQXLGYcLCCgVcewMM7F4jZmXMWjrfPNwUDn4li0AfCzqOeAgRc+50LijAp aNkrF9/KkXFq8na9kl4176YR0BS8qZIRXbSZJzRmQ6UuQEz+rUx/cxrW51GZtlUZn/U4 eggfV//IS53rSYhaWUhV5HwJNjzxoNWocGTVlnv6QfVv9dXqk3Ngm46UHhnluAOE72lM iDi7RuzTnO/asOPlFZnRqTKeX5U/VRrsQ7R4DqBUZh5lOEscSYf4bqszeE7co2qeumlg gL5A== X-Forwarded-Encrypted: i=1; AJvYcCUZmNMao6LVBPGBrQSdaiLqzfXsqw2HGpiIrUjHXEjAyszH6m6tDgi1svoMSZcs5WSiOpZSAkXkOqsz@lists.linux.dev X-Gm-Message-State: AOJu0YxEgTMFsfft3WUmuqbWVl+pEeSqwq7sHHyaA5ZF2+qIdmrNuWRP 2Kjd7xpzdSIVKXg0qsG0a/CK5ZTD1GskxQJBBivplLIr/4/NVV8TPhriPNB/vpzDCgI9yn88jRE 6ydJcqUurpbWOmzUumaRc17VZePJPXkedP2ba7jP0sJAwn/aAATLt/J5OQYk= X-Received: by 2002:a17:90b:3c87:b0:2da:905a:d893 with SMTP id 98e67ed59e1d1-2e1e636c83dmr16775529a91.31.1728356205262; Mon, 07 Oct 2024 19:56:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE0LUzICRMByd9uxAUa++9+87v1zVZqbecdEx3xdGyOmYX5ElCHosgfateZaUDyS8uZx+7XTA== X-Received: by 2002:a17:90b:3c87:b0:2da:905a:d893 with SMTP id 98e67ed59e1d1-2e1e636c83dmr16775512a91.31.1728356204947; Mon, 07 Oct 2024 19:56:44 -0700 (PDT) Received: from [192.168.68.54] ([103.210.27.132]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e1e85da3f0sm7939061a91.30.2024.10.07.19.56.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Oct 2024 19:56:44 -0700 (PDT) Message-ID: <6fda5d7d-4214-460c-a727-9bb3382aa78f@redhat.com> Date: Tue, 8 Oct 2024 12:56:36 +1000 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 09/11] arm64: Enable memory encrypt for Realms To: Steven Price , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Suzuki K Poulose , Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" References: <20241004144307.66199-1-steven.price@arm.com> <20241004144307.66199-10-steven.price@arm.com> From: Gavin Shan In-Reply-To: <20241004144307.66199-10-steven.price@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/5/24 12:43 AM, Steven Price wrote: > From: Suzuki K Poulose > > Use the memory encryption APIs to trigger a RSI call to request a > transition between protected memory and shared memory (or vice versa) > and updating the kernel's linear map of modified pages to flip the top > bit of the IPA. This requires that block mappings are not used in the > direct map for realm guests. > > Signed-off-by: Suzuki K Poulose > Co-developed-by: Steven Price > Signed-off-by: Steven Price > Reviewed-by: Catalin Marinas > --- > Changes since v5: > * Added comments and a WARN() in realm_set_memory_{en,de}crypted() to > explain that memory is leaked if the transition fails. This means the > callers no longer need to provide their own WARN. > Changed since v4: > * Reworked to use the new dispatcher for the mem_encrypt API > Changes since v3: > * Provide pgprot_{de,en}crypted() macros > * Rename __set_memory_encrypted() to __set_memory_enc_dec() since it > both encrypts and decrypts. > Changes since v2: > * Fix location of set_memory_{en,de}crypted() and export them. > * Break-before-make when changing the top bit of the IPA for > transitioning to/from shared. > --- > arch/arm64/Kconfig | 3 + > arch/arm64/include/asm/mem_encrypt.h | 9 +++ > arch/arm64/include/asm/pgtable.h | 5 ++ > arch/arm64/include/asm/set_memory.h | 3 + > arch/arm64/kernel/rsi.c | 16 +++++ > arch/arm64/mm/pageattr.c | 90 +++++++++++++++++++++++++++- > 6 files changed, 123 insertions(+), 3 deletions(-) > Reviewed-by: Gavin Shan