Re: [PATCH v7 09/22] x86/virt/seamldr: Introduce skeleton for TDX module updates

Edgecombe, Rick P
2026-04-11T01:23:56Z

On Tue, 2026-03-31 at 05:41 -0700, Chao Gao wrote:
> Potential alternative to stop_machine()
> =======================================
> An alternative approach is to lock all KVM entry points and kick all
> vCPUs. Here, KVM entry points refer to KVM VM/vCPU ioctl entry points,
> implemented in KVM common code (virt/kvm). Adding a locking mechanism
> there would affect all architectures KVM supports. And to lock only TDX
> vCPUs, new logic would be needed to identify TDX vCPUs, which the KVM
> common code currently lacks. This would add significant complexity and
> maintenance overhead to KVM for this TDX-specific use case.

I'd add a little imperative ending like ", so don't take this approach."

>
> Signed-off-by: Chao Gao <chao.gao@intel.com>
> Reviewed-by: Xu Yilun <yilun.xu@linux.intel.com>
> Reviewed-by: Tony Lindgren <tony.lindgren@linux.intel.com>
> Reviewed-by: Kai Huang <kai.huang@intel.com>
> Reviewed-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
> ---

Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>