From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE3293A9DA6 for ; Tue, 31 Mar 2026 10:38:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774953501; cv=none; b=tfAVKKfoZOd9QmejwA7GFh9JW4+1pxDP6AHOlwP12HK6tV2D66z/buENNiOAR6LwzwFLgxz/BxNWT8uVkXEhhAYuVSem+rrfzTqForR2UNy+Ki3Ajh8FqlFK8/D3Ik4BXSRrOvrUOFy1UdEgU1PY5xl6eo1K9+2dmQAeNQgmoYc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774953501; c=relaxed/simple; bh=EchK1OhTgSh8S7cgMHy7fOb1l+kJpOBAiQ+NkOjsT/I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kZ/v9WJGS4r+aEM2mJGLfAfwXxnCIwuvTa2DY/rb2lwQZUQJc18BHtZcvybv7MQZeHE06NF+3fK+ZurCZfpNgXthYy+A+nGzDI7mn4Gi7UG6I/dXUwiqNi4Zbukg0Vgz1waWY/Rpt4kaWadZ123knaufxtfWlJy935lg3SLLilc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Y1Fap1Cr; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Y1Fap1Cr" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4887fd35e60so1910665e9.2 for ; Tue, 31 Mar 2026 03:38:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774953498; x=1775558298; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=j1GwY5PsDoqBTLy6YsGXd3gbj61OJIiAY2NVv6n/DA0=; b=Y1Fap1Crd6hxrQHhHZnac8YaJEdT6hqfBdsvuckG437GixF8NRiAhEKsROEBvDEXNJ jmROaMt3MikzQMNB6kvIOBJHWRx0wzBdXXAvlM/Qher+cN/rwcOTLaPgHx/QFry0QiHC FVXU7Y2LjFokPDkOW7+7975xG+PefiK1NeeEC9NwUc1jKrpbk2GUS/5pIgJz2UckbVai wS6jrc0Z9SMUyzHPsiiXcb1LNwrtfwLBIdczCwrhWtY9tVHk5MgZPEdFslk05noCmxLN ZPhlp/QyETyJojc2UmdGOp7LNZf17dH8buQbU6EYd8MVSR4rn0gJnzfUr8lsWuXRI+Sk Bt5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774953498; x=1775558298; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j1GwY5PsDoqBTLy6YsGXd3gbj61OJIiAY2NVv6n/DA0=; b=fpzm2rcgxuByX5Jw38Jg2SpBmEJenoDvlW+Gylxen6E0TrB/77D0rOTZouLtHrL5JM Yq3p391vhVRh/WU9PgeBOHarm+c1OAitMfaoPQki5UoEUZUlGcrkXCxy4zJJTtp5bh6l 6ZvV9KS0m97skSGbRUYGSstO/7sADW2MZPY2S368LK70e9BgAexRBoQPiAYQW7gI1pyc 5iz0pKlo2zrWhin3Jn9uyOlFg9bOzNJQz/g73K5s8Wm/hOwf4L+ODpTslMtSUnw9m4KQ NALMSK/dy9lwX2T9xI/r+L9qAmXgWYhorFqQg9VN8e4Tq/oExF7Sv3qvjsGYwXgiTwbR V1ng== X-Forwarded-Encrypted: i=1; AJvYcCXJfooXsUIUhqbdK4uSjgTSg/TWXbOuXKaBZsDzfuRyIvmSlcKMxFx6Eymh+MWYoNFQH8tcd3Nzu00L@lists.linux.dev X-Gm-Message-State: AOJu0YxcJwVXzXXtc9jPeV4zQvRpnR7YO3Uh95Xn3PqBgt5U0AmuC4lO T4eERQbo9smWc5vf2erKbsI+5srrtxgjuCiPTrl3mj3O8hIbofktxH/NAjUfDq17BWA= X-Gm-Gg: ATEYQzyGnZsXFqJR6LorzGvqhN/C4iTCRCEARRkdk6CrHNVKYSWOWE1L+tBhrON5qyr BUcDxzqyDmZkaR9tOnuloulKKziUKGpUs77LBEHJIsQ2jaiPUXh4ASKoDarGYe8+dsd6modnqYE 5C7a8IowR+rD6rhi057RagVykWL5fVLG/QIM54KAo9b1yeBkEJWtyDzdUxKhUwmibIt5/KFzJWZ eJMUm/6q+xWdPDdxMyzUciFrh2CVdGWE06tl1Hwxmu1pxrEWoxE7wtpw6lNV3ksxOmD9jpRiJHy AQcvN9wOFMl3HzhTwmi3w3fxPIAJoSs2HQPZnMBstBE+rk1nAHy0RUQ5zjZ1wqxg6pl4tRDn/9I hP+pgPQ+mbbfeNIvt+Pm0XZ/ZIjKB1afIQ7D9+FWZECQ9GKk2uMpDeIjMDuxWkj9/rn8ni5zGuE gG2PNOI+Ph3SCpoWbyNXjMWBLBoA== X-Received: by 2002:a05:600c:a00e:b0:488:7b85:b16c with SMTP id 5b1f17b1804b1-4887b85b27dmr34221595e9.29.1774953498161; Tue, 31 Mar 2026 03:38:18 -0700 (PDT) Received: from [192.168.0.20] ([212.21.133.10]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e822078sm32745645e9.9.2026.03.31.03.38.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 03:38:17 -0700 (PDT) Message-ID: <730feb0b-7022-4d22-9ead-3efc4b4ab4ab@suse.com> Date: Tue, 31 Mar 2026 13:38:16 +0300 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/31] x86/virt/tdx: Configure TDX Module with optional TDX Connect feature To: Xu Yilun , linux-coco@lists.linux.dev, linux-pci@vger.kernel.org, dan.j.williams@intel.com, x86@kernel.org Cc: chao.gao@intel.com, dave.jiang@intel.com, baolu.lu@linux.intel.com, yilun.xu@intel.com, zhenzhong.duan@intel.com, kvm@vger.kernel.org, rick.p.edgecombe@intel.com, dave.hansen@linux.intel.com, kas@kernel.org, xiaoyao.li@intel.com, vishal.l.verma@intel.com, linux-kernel@vger.kernel.org References: <20260327160132.2946114-1-yilun.xu@linux.intel.com> <20260327160132.2946114-9-yilun.xu@linux.intel.com> From: Nikolay Borisov Content-Language: en-US Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: <20260327160132.2946114-9-yilun.xu@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 27.03.26 г. 18:01 ч., Xu Yilun wrote: > TDX Module supports optional TDX features (e.g. TDX Connect & TDX Module > Extensions) that won't be enabled by default. It extends TDH.SYS.CONFIG > for host to choose to enable them on bootup. > > Call TDH.SYS.CONFIG with a new bitmap input parameter to specify which > features to enable. The bitmap uses the same definitions as > TDX_FEATURES0. But note not all bits in TDX_FEATURES0 are valid for > configuration, e.g. TDX Module Extensions is a service that supports TDX > Connect, it is implicitly enabled when TDX Connect is enabled. Setting > TDX_FEATURES0_EXT in the bitmap has no effect. > > TDX Module advances the version of TDH.SYS.CONFIG for the change, so > use the latest version (v1) for optional feature enabling. But > supporting existing Modules which only support v0 is still necessary > until they are deprecated, enumerate via TDX_FEATURES0 to decide which > version to use. > > TDX Module updates global metadata when optional features are enabled. > Host should update the cached tdx_sysinfo to reflect these changes. > > Co-developed-by: Zhenzhong Duan > Signed-off-by: Zhenzhong Duan > Signed-off-by: Xu Yilun > --- > arch/x86/virt/vmx/tdx/tdx.h | 3 ++- > arch/x86/virt/vmx/tdx/tdx.c | 16 +++++++++++++++- > 2 files changed, 17 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/virt/vmx/tdx/tdx.h b/arch/x86/virt/vmx/tdx/tdx.h > index e5a9331df451..870bb75da3ba 100644 > --- a/arch/x86/virt/vmx/tdx/tdx.h > +++ b/arch/x86/virt/vmx/tdx/tdx.h > @@ -58,7 +58,8 @@ > #define TDH_PHYMEM_CACHE_WB 40 > #define TDH_PHYMEM_PAGE_WBINVD 41 > #define TDH_VP_WR 43 > -#define TDH_SYS_CONFIG 45 > +#define TDH_SYS_CONFIG_V0 45 > +#define TDH_SYS_CONFIG SEAMCALL_LEAF_VER(TDH_SYS_CONFIG_V0, 1) Since newer versions of tdx module apis are backwards compatible with older ones, and v0 are actually deprecated why have both definitions?