Re: [PATCH v7 13/22] x86/virt/seamldr: Install a new TDX module

Chao Gao
2026-04-14T10:19:46Z

>> +static int seamldr_install(const struct seamldr_params *params)
>> +{
>> + struct tdx_module_args args = { .rcx = __pa(params) };
>
>In an earlier patch you have a wrapper as:
>struct tdx_module_args args = = {};
>args.rxx = foo;
>
>Why the style difference? It would be good to standardize, but the existing code
>isn't standardized. What do you think about going with this style through the
>series for the one arg ones?

Sure, happy to standardize. To confirm, you prefer this style?

struct tdx_module_args args = { .rcx = __pa(params) };

it looks more common than the other way.