From: Dave Hansen <dave.hansen@intel.com>
To: Vishal Annapurve <vannapurve@google.com>,
Jeremi Piotrowski <jpiotrowski@linux.microsoft.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
pbonzini@redhat.com, rientjes@google.com, seanjc@google.com,
erdemaktas@google.com, ackerleytng@google.com, jxgao@google.com,
sagis@google.com, oupton@google.com, peterx@redhat.com,
vkuznets@redhat.com, dmatlack@google.com, pgonda@google.com,
michael.roth@amd.com, kirill@shutemov.name,
thomas.lendacky@amd.com, dave.hansen@linux.intel.com,
linux-coco@lists.linux.dev, chao.p.peng@linux.intel.com,
isaku.yamahata@gmail.com, andrew.jones@linux.dev, corbet@lwn.net,
hch@lst.de, m.szyprowski@samsung.com, rostedt@goodmis.org,
iommu@lists.linux.dev
Subject: Re: [RFC V1 5/5] x86: CVMs: Ensure that memory conversions happen at 2M alignment
Date: Fri, 2 Feb 2024 08:35:58 -0800 [thread overview]
Message-ID: <746d2448-3adc-467b-a39c-5585f33bd740@intel.com> (raw)
In-Reply-To: <CAGtprH9X0Yz_Z+QaYcLpLNXtY_Ye68aqvx-G1pOWZxv9SiRRoQ@mail.gmail.com>
On 2/2/24 08:22, Vishal Annapurve wrote:
>> If you must - focus on getting swiotlb conversions to happen at the desired
>> granularity but don't try to force every single conversion to be >4K.
> If any conversion within a guest happens at 4K granularity, then this
> will effectively cause non-hugepage aligned EPT/NPT entries. This
> series is trying to get all private and shared memory regions to be
> hugepage aligned to address the problem statement.
Yeah, but the series is trying to do that by being awfully myopic at
this stage and without being _declared_ to be so myopic.
Take a look at all of the set_memory_decrypted() calls. How many of
them even operate on the part of the guest address space rooted in the
memfd where splits matter? They're not doing conversions. They're just
setting up shared mappings in the page tables of gunk that was never
private in the first place.
next prev parent reply other threads:[~2024-02-02 16:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 5:52 [RFC V1 0/5] x86: CVMs: Align memory conversions to 2M granularity Vishal Annapurve
2024-01-12 5:52 ` [RFC V1 1/5] swiotlb: Support allocating DMA memory from SWIOTLB Vishal Annapurve
2024-02-14 14:49 ` Kirill A. Shutemov
2024-02-15 3:33 ` Vishal Annapurve
2024-02-15 9:44 ` Alexander Graf
2024-02-15 20:26 ` Michael Kelley
2024-02-24 17:07 ` Vishal Annapurve
2024-02-24 22:02 ` Michael Kelley
2024-03-05 17:19 ` Vishal Annapurve
2024-01-12 5:52 ` [RFC V1 2/5] swiotlb: Allow setting up default alignment of SWIOTLB region Vishal Annapurve
2024-01-12 5:52 ` [RFC V1 3/5] x86: CVMs: Enable dynamic swiotlb by default for CVMs Vishal Annapurve
2024-02-01 12:20 ` Jeremi Piotrowski
2024-02-02 4:40 ` Vishal Annapurve
2024-01-12 5:52 ` [RFC V1 4/5] x86: CVMs: Allow allocating all DMA memory from SWIOTLB Vishal Annapurve
2024-01-31 16:17 ` Dave Hansen
2024-02-01 3:41 ` Vishal Annapurve
2024-01-12 5:52 ` [RFC V1 5/5] x86: CVMs: Ensure that memory conversions happen at 2M alignment Vishal Annapurve
2024-01-31 16:33 ` Dave Hansen
2024-02-01 3:46 ` Vishal Annapurve
2024-02-01 12:02 ` Jeremi Piotrowski
2024-02-02 5:08 ` Vishal Annapurve
2024-02-02 8:00 ` Jeremi Piotrowski
2024-02-02 16:22 ` Vishal Annapurve
2024-02-02 16:35 ` Dave Hansen [this message]
2024-02-03 5:19 ` Vishal Annapurve
2024-01-30 16:42 ` [RFC V1 0/5] x86: CVMs: Align memory conversions to 2M granularity Vishal Annapurve
2024-01-31 16:52 ` Dave Hansen
2024-02-01 5:44 ` Vishal Annapurve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=746d2448-3adc-467b-a39c-5585f33bd740@intel.com \
--to=dave.hansen@intel.com \
--cc=ackerleytng@google.com \
--cc=andrew.jones@linux.dev \
--cc=chao.p.peng@linux.intel.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=dmatlack@google.com \
--cc=erdemaktas@google.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=isaku.yamahata@gmail.com \
--cc=jpiotrowski@linux.microsoft.com \
--cc=jxgao@google.com \
--cc=kirill@shutemov.name \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=michael.roth@amd.com \
--cc=oupton@google.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=pgonda@google.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sagis@google.com \
--cc=seanjc@google.com \
--cc=thomas.lendacky@amd.com \
--cc=vannapurve@google.com \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).