From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74ECD1F18A for ; Mon, 12 Jun 2023 16:27:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686587221; x=1718123221; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Uat8NMUncmqciNyRT9NRmiG7E1sO/Fvnt3OOx8fsnxw=; b=PUZ8qYk+WInlr6/mB4KPZvqQCtDK1rGBA6f18uhlNpNRp2KQmhJiBm3h 3/5LWE5Xo5BJ05Sv9jj1mx7mkbQvYquK0go8Nq4GFKrW3trzdutgIWUkn MEVFAdOlyQQuhgxmDm/PvHxzALbEp3P5eChr7wcDnYlqW4bJO8NvialNx U86KQ3SDXBeuTb9JyNGffAQOW1p5jp7L704ZSERV895bGA+AGZsLm/rdg OY4tHfcq+dW1bWmhBDUHWNeZ5rkakSvWCYOn1B0mlT10RmoaOxdnBq1TY m8UAKaRlbR3ltxskL1afA+y0+1dMpj3lHQ4fiRVN0fE1lXkQLPAd4jBW1 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="358089510" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="358089510" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 09:26:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="661638856" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="661638856" Received: from spmantha-mobl1.amr.corp.intel.com (HELO [10.209.43.2]) ([10.209.43.2]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 09:26:58 -0700 Message-ID: <7bf4b9a6-d75b-8e96-14cf-79df2fae8694@intel.com> Date: Mon, 12 Jun 2023 09:26:58 -0700 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH RFC v9 11/51] x86/traps: Define RMP violation #PF error code Content-Language: en-US To: Michael Roth , kvm@vger.kernel.org Cc: linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh References: <20230612042559.375660-1-michael.roth@amd.com> <20230612042559.375660-12-michael.roth@amd.com> From: Dave Hansen In-Reply-To: <20230612042559.375660-12-michael.roth@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/11/23 21:25, Michael Roth wrote: > From: Brijesh Singh > > Bit 31 in the page fault-error bit will be set when processor encounters > an RMP violation. > > While at it, use the BIT_ULL() macro. ... > enum x86_pf_error_code { > - X86_PF_PROT = 1 << 0, > - X86_PF_WRITE = 1 << 1, > - X86_PF_USER = 1 << 2, > - X86_PF_RSVD = 1 << 3, > - X86_PF_INSTR = 1 << 4, > - X86_PF_PK = 1 << 5, > - X86_PF_SGX = 1 << 15, > + X86_PF_PROT = BIT(0), > + X86_PF_WRITE = BIT(1), > + X86_PF_USER = BIT(2), > + X86_PF_RSVD = BIT(3), > + X86_PF_INSTR = BIT(4), > + X86_PF_PK = BIT(5), > + X86_PF_SGX = BIT(15), > + X86_PF_RMP = BIT(31), > }; It would be nice if the changelog "BIT_ULL()" matched the code "BIT()". :) With that fixed, Acked-by: Dave Hansen