SVSM draft specification v0.62 / GHCB draft specification v2.03

SVSM draft specification v0.62 / GHCB draft specification v2.03

[Tom Lendacky]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Attached is an updated draft version of the SVSM specification with 
feedback incorporated from the previous review.

Also attached is a draft GHCB specification with updates for APIC ID 
retrieval and VMPL/VMSA level execution (and an SEV-ES enhancement to use 
the SNP Page State Change support for working with UPM).

Please take a look and reply with any feedback you may have.

Thanks,
Tom

[-- Attachment #2: Draft-SVSM-v0.62.pdf --]
[-- Type: application/pdf, Size: 703290 bytes --]

[-- Attachment #3: Draft-GHCB-v2.03.pdf --]
[-- Type: application/pdf, Size: 1034523 bytes --]

Re: SVSM draft specification v0.62 / GHCB draft specification v2.03

[Tom Dohrmann]

On Tue, Mar 14, 2023 at 05:08:17PM -0500, Tom Lendacky wrote:
> Attached is an updated draft version of the SVSM specification with feedback
> incorporated from the previous review.
>
> Also attached is a draft GHCB specification with updates for APIC ID
> retrieval and VMPL/VMSA level execution (and an SEV-ES enhancement to use
> the SNP Page State Change support for working with UPM).

AFAICT the new GHCB spec explains how to run a vCPU at another VMPL,
but doesn't contain any information about how to registers a new VMSA
for a specific VMPL. From looking at some of the patches used for SVSM
it seems that a new field in the AP Creation NAE was added, but the
specification wasn't yet updated accordingly.

Regards,
Tom

> Please take a look and reply with any feedback you may have.
>
> Thanks,
> Tom

Re: SVSM draft specification v0.62 / GHCB draft specification v2.03

[Tom Lendacky]

On 3/16/23 15:31, Tom Dohrmann wrote:
> On Tue, Mar 14, 2023 at 05:08:17PM -0500, Tom Lendacky wrote:
>> Attached is an updated draft version of the SVSM specification with feedback
>> incorporated from the previous review.
>>
>> Also attached is a draft GHCB specification with updates for APIC ID
>> retrieval and VMPL/VMSA level execution (and an SEV-ES enhancement to use
>> the SNP Page State Change support for working with UPM).
> 
> AFAICT the new GHCB spec explains how to run a vCPU at another VMPL,
> but doesn't contain any information about how to registers a new VMSA
> for a specific VMPL. From looking at some of the patches used for SVSM
> it seems that a new field in the AP Creation NAE was added, but the
> specification wasn't yet updated accordingly.

Ah, you are correct. I missed pulling that change into this version of the 
document. Thanks for pointing that out.

Thanks,
Tom

> 
> Regards,
> Tom
> 
>> Please take a look and reply with any feedback you may have.
>>
>> Thanks,
>> Tom
> 
> 
> 

Re: SVSM draft specification v0.62 / GHCB draft specification v2.03

[Tom Lendacky]

On 3/16/23 16:12, Tom Lendacky wrote:
> On 3/16/23 15:31, Tom Dohrmann wrote:
>> On Tue, Mar 14, 2023 at 05:08:17PM -0500, Tom Lendacky wrote:
>>> Attached is an updated draft version of the SVSM specification with 
>>> feedback
>>> incorporated from the previous review.
>>>
>>> Also attached is a draft GHCB specification with updates for APIC ID
>>> retrieval and VMPL/VMSA level execution (and an SEV-ES enhancement to use
>>> the SNP Page State Change support for working with UPM).
>>
>> AFAICT the new GHCB spec explains how to run a vCPU at another VMPL,
>> but doesn't contain any information about how to registers a new VMSA
>> for a specific VMPL. From looking at some of the patches used for SVSM
>> it seems that a new field in the AP Creation NAE was added, but the
>> specification wasn't yet updated accordingly.
> 
> Ah, you are correct. I missed pulling that change into this version of the 
> document. Thanks for pointing that out.

And just as an FYI until the next draft, bit positions 16-19 of 
SW_EXITINFO1 on the AP Create NAE event will indicate the VMPL for which 
the VMSA is being created/deleted.

Thanks,
Tom

> 
> Thanks,
> Tom
> 
>>
>> Regards,
>> Tom
>>
>>> Please take a look and reply with any feedback you may have.
>>>
>>> Thanks,
>>> Tom
>>
>>
>>

Re: SVSM draft specification v0.62 / GHCB draft specification v2.03

[Tom Lendacky]

[-- Attachment #1: Type: text/plain, Size: 1508 bytes --]

On 3/17/23 11:49, Tom Lendacky wrote:
> On 3/16/23 16:12, Tom Lendacky wrote:
>> On 3/16/23 15:31, Tom Dohrmann wrote:
>>> On Tue, Mar 14, 2023 at 05:08:17PM -0500, Tom Lendacky wrote:
>>>> Attached is an updated draft version of the SVSM specification with 
>>>> feedback
>>>> incorporated from the previous review.
>>>>
>>>> Also attached is a draft GHCB specification with updates for APIC ID
>>>> retrieval and VMPL/VMSA level execution (and an SEV-ES enhancement to use
>>>> the SNP Page State Change support for working with UPM).
>>>
>>> AFAICT the new GHCB spec explains how to run a vCPU at another VMPL,
>>> but doesn't contain any information about how to registers a new VMSA
>>> for a specific VMPL. From looking at some of the patches used for SVSM
>>> it seems that a new field in the AP Creation NAE was added, but the
>>> specification wasn't yet updated accordingly.
>>
>> Ah, you are correct. I missed pulling that change into this version of 
>> the document. Thanks for pointing that out.

Attached is the updated GHCB specification with the previously missing 
changes required for creating non-zero VMPL APs.

Thanks,
Tom

> 
> And just as an FYI until the next draft, bit positions 16-19 of 
> SW_EXITINFO1 on the AP Create NAE event will indicate the VMPL for which 
> the VMSA is being created/deleted.
> 
> Thanks,
> Tom
> 
>>
>> Thanks,
>> Tom
>>
>>>
>>> Regards,
>>> Tom
>>>
>>>> Please take a look and reply with any feedback you may have.
>>>>
>>>> Thanks,
>>>> Tom
>>>
>>>
>>>

[-- Attachment #2: 56421-Guest_Hypervisor_Communication_Block_Standardization-v2.03.pdf --]
[-- Type: application/pdf, Size: 1041679 bytes --]