From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 062D730D40E; Mon, 6 Jul 2026 13:35:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783344939; cv=none; b=o7Cw+NcTbkMB1+hj2X8bYzpD+BPC2AijYFq3jOX1BHclvBt1RuS9MNaXkebQNSGpldymCHN0YD+C2djJhXrJ2M3lzp0e8z9IQ5tXM1A61GXLtAb5n3vyBxuXE1tfpihpa0+iFJDo9Mh9IPDi/cRFcj+cWwqiw35E5sS2hqAPwvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783344939; c=relaxed/simple; bh=HAycXe+MfpMNdchGrwsUlrqXGbbbQRWH5KqS86pkVPI=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=R7vPmeP7PnlwBg0NLiq9nloAWeCJQQrjrb6golN0Nm+UPTKRepw7u3wu39awoiSr2r+ARxM+rcPmo5OTn5PF0qBtnOh4ZD3UFSqUckvujeyrtXv+2t5+qYfkYLShH2owjNrV+ATiOUA5TJT5+jyBv2G6+A5RG+ttdxdSKE/dFww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=W8mktv82; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="W8mktv82" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A14D01F000E9; Mon, 6 Jul 2026 13:35:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783344937; bh=uLviVLYgT3tLYFzYiI6Zru82tyxHPobIeBJDsXCYEGE=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=W8mktv82qSURqSaR4khAQUk7rv+HF7NlRSLA73tWAmclaNwHXS+dyT8h0BbeTLW0C IXGQIHoi2kXpNIfZ6FMDRgPPHMAED6HnuJsb54jXSgdLzf1f/N6BkJH2uxa7wyHhAF ae6RJ6bfyviz/WHMgMJvpzqwht6LnYKSSzPufbKA65RL1MgU/lt8wtduUw+vXyMiQf wUWTR1RWuUh4hLbeNPgaSaCumyKdkLkFnF/yFAf4jSipK2FJST7DJlYo8OtxANoWWn Q8DvCEmW1TfJecSDxSkbRbLpcwqNRIFqUCsXgqYOyl68zhSonQh4CakRGWKadO6rU2 WoBbUPcDWwiJQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wgjTz-00000001xgl-2Wl5; Mon, 06 Jul 2026 13:35:35 +0000 Date: Mon, 06 Jul 2026 14:35:35 +0100 Message-ID: <86ik6sp7fc.wl-maz@kernel.org> From: Marc Zyngier To: "Aneesh Kumar K.V (Arm)" Cc: linux-coco@lists.linux.dev, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, Catalin Marinas , Jason Gunthorpe , Marek Szyprowski , Robin Murphy , Steven Price , Suzuki K Poulose , Thomas Gleixner , Will Deacon Subject: Re: [PATCH v5 02/10] irqchip/gic-v3-its: Align shared ITS allocations to the CoCo shared granule size In-Reply-To: <20260706060432.1375570-3-aneesh.kumar@kernel.org> References: <20260706060432.1375570-1-aneesh.kumar@kernel.org> <20260706060432.1375570-3-aneesh.kumar@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: aneesh.kumar@kernel.org, linux-coco@lists.linux.dev, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, catalin.marinas@arm.com, jgg@ziepe.ca, m.szyprowski@samsung.com, robin.murphy@arm.com, steven.price@arm.com, suzuki.poulose@arm.com, tglx@kernel.org, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 06 Jul 2026 07:04:24 +0100, "Aneesh Kumar K.V (Arm)" wrote: > > ITS tables allocated by the coco guest are shared with the hypervisor. > These allocations must satisfy the host shared-buffer granule size so that > the full converted range is safe for host access. > > Allocate ITS pages using a size rounded up to the shared granule size and > use the same allocation order when encrypting, decrypting and freeing the > memory. Also grow the ITT cache in shared-granule sized chunks instead of > assuming PAGE_SIZE is sufficient. > > Signed-off-by: Aneesh Kumar K.V (Arm) > --- > drivers/irqchip/irq-gic-v3-its.c | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index b57d81ad33a0..5d6d38aa0dae 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -213,16 +213,17 @@ static gfp_t gfp_flags_quirk; > static struct page *its_alloc_pages_node(int node, gfp_t gfp, > unsigned int order) > { > + unsigned int alloc_order; > struct page *page; > int ret = 0; > > - page = alloc_pages_node(node, gfp | gfp_flags_quirk, order); > - > + alloc_order = get_order(mem_cc_align_to_shared_granule(PAGE_SIZE << order)); > + page = alloc_pages_node(node, gfp | gfp_flags_quirk, alloc_order); > if (!page) > return NULL; > > ret = set_memory_decrypted((unsigned long)page_address(page), > - 1 << order); > + 1 << alloc_order); > /* > * If set_memory_decrypted() fails then we don't know what state the > * page is in, so we can't free it. Instead we leak it. > @@ -241,13 +242,16 @@ static struct page *its_alloc_pages(gfp_t gfp, unsigned int order) > > static void its_free_pages(void *addr, unsigned int order) > { > + int alloc_order; > + > + alloc_order = get_order(mem_cc_align_to_shared_granule(PAGE_SIZE << order)); > /* > * If the memory cannot be encrypted again then we must leak the pages. > * set_memory_encrypted() will already have WARNed. > */ > - if (set_memory_encrypted((unsigned long)addr, 1 << order)) > + if (set_memory_encrypted((unsigned long)addr, 1 << alloc_order)) > return; > - free_pages((unsigned long)addr, order); > + free_pages((unsigned long)addr, alloc_order); The comments I had in [1] are still applicable. M. [1] https://lore.kernel.org/all/86zf2ozrb8.wl-maz@kernel.org/ -- Without deviation from the norm, progress is not possible.