From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30F2C3806A3; Thu, 21 May 2026 10:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779358745; cv=none; b=r15WbF3z7AulXl8wMUPCmovYsF1OXc6I/jMAHCM/1L+f+EsuQnr/O8JeyIC3ZKygdcFlKAWI9DN2IMFJFlIFTdLPCOzfNmaTVvPe/PiY4Gn4O/IzfZE5A7hDrMvXwb0ydGO+ych+0G72i9TVh5MelM2HXI/Twnp/8vGcZENcM00= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779358745; c=relaxed/simple; bh=YiLyi6oIvvHU1tPc4gIss8TQOdQBqAr412XPlezh/So=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=GiczCVNj21/BrARhoL1fyPbaeiU3iiYh9ph4slbadwS59/0G3j/A1N+lupFb/MpaFSHiGdnykvXhPsvbNWeAL1e2XTdQcbUUb8VqETWrRE/BdIr3re/zvhEY39+FdW5NuSuGE0/SNNW+JkNuNzcoM/bR9PYwW827MhzljAcGgDE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LlzMutfv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LlzMutfv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C97EA1F000E9; Thu, 21 May 2026 10:19:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779358743; bh=qfM82z3BHmVFU110xOhDnN73f2JicISYXk83H5AhObU=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=LlzMutfvy8MAr6JgeXqIIc7RUQZwsc04MN6EdMvWVRty5YTkiehbKFfqqw37+6iga gJoMLV5OWS4O2EwwOVt2hDqaJijKSfg/KrPA35M05IKt6CwQsrjWJSyg0gds0m9nFi fya7uX2xCr85GIG7VpStByHEXh8nQYUoazks2wd5HbDkUrKeEQkSSETALSSVG+KcyI ctcJVxRxPE12NzuFW0bqG5y5ZH62RRH/3yYv7f6ACq7lYn6Syoy981s+MCfEVEreKr kY7Jyif//GoEqyhigpXFA1hvMUGG9DNklgbwYJDFCTT/CSlGydS5VJe10w0c79aQax rbZPGuMoV3g/Q== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wQ0UX-00000004liO-2gGN; Thu, 21 May 2026 10:19:01 +0000 Date: Thu, 21 May 2026 11:19:01 +0100 Message-ID: <86jysxvze2.wl-maz@kernel.org> From: Marc Zyngier To: Steven Price Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, Suzuki K Poulose , Catalin Marinas , Will Deacon , James Morse , Oliver Upton , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" , Emi Kisanuki , Vishal Annapurve , WeiLin.Chang@arm.com, Lorenzo.Pieralisi2@arm.com Subject: Re: [PATCH v14 01/44] kvm: arm64: Include kvm_emulate.h in kvm/arm_psci.h In-Reply-To: <20260513131757.116630-2-steven.price@arm.com> References: <20260513131757.116630-1-steven.price@arm.com> <20260513131757.116630-2-steven.price@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: steven.price@arm.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, james.morse@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, joey.gouly@arm.com, alexandru.elisei@arm.com, christoffer.dall@arm.com, tabba@google.com, linux-coco@lists.linux.dev, gankulkarni@os.amperecomputing.com, gshan@redhat.com, sdonthineni@nvidia.com, alpergun@google.com, aneesh.kumar@kernel.org, fj0570is@fujitsu.com, vannapurve@google.com, WeiLin.Chang@arm.com, Lorenzo.Pieralisi2@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 13 May 2026 14:17:09 +0100, Steven Price wrote: >=20 > From: Suzuki K Poulose >=20 > Fix a potential build error (like below, when asm/kvm_emulate.h gets > included after the kvm/arm_psci.h) by including the missing header file > in kvm/arm_psci.h: >=20 > ./include/kvm/arm_psci.h: In function =E2=80=98kvm_psci_version=E2=80=99: > ./include/kvm/arm_psci.h:29:13: error: implicit declaration of function > =E2=80=98vcpu_has_feature=E2=80=99; did you mean =E2=80=98cpu_have_fea= ture=E2=80=99? [-Werror=3Dimplicit-function-declaration] > 29 | if (vcpu_has_feature(vcpu, KVM_ARM_VCPU_PSCI_0_2)) { > | ^~~~~~~~~~~~~~~~ > | cpu_have_feature >=20 > Reviewed-by: Gavin Shan > Signed-off-by: Suzuki K Poulose > Signed-off-by: Steven Price Unrelated to this patch, but really easy to fix: the standard prefix for patches targeting KVM/arm64 is: "KVM: arm64: [opt subsys:] Something starting with a capital letter" where "opt subsys" could be "CCA" where applicable. It'd be good to have some consistency. Thanks, M. --=20 Without deviation from the norm, progress is not possible.