From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8105296BC1 for ; Thu, 29 Jan 2026 16:59:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769705983; cv=none; b=Fmi6Ir/zLb5sT/2+D/E7srZ1gHIJCcHMnllmioFzEe20HK4dZKg9kplUp8N5+KjWldXnRgXDlsIuluNT9Idq0Fwb/VJvlGCJ5OQE5ViS5EDYCCF+M5bedAH9COW0eQkjuNErB2bE7yipCvPc1ElRXvDrEsIBtwzlJbDT9dmjNpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769705983; c=relaxed/simple; bh=0dIcviYJ2gXblPSTLhA8NoRVcDEaYcGPNfZwUngwERA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jWxzPO2oQw7Mmj1Bjv/W2JG4sSTFLDtEuIbYO8vRdDbIQ/i6NTotqlhpNFki723iZWDObsIVkwy/dVv4q4PyBOXqj/kHD2zt/ca+BruUtntHRaXB72kufgN/F2BLWWloqD6AsuoY0YkHfAOkxfgi1NWXde4cQscogRt9ETPjsyo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nJn5Cg8s; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nJn5Cg8s" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769705982; x=1801241982; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=0dIcviYJ2gXblPSTLhA8NoRVcDEaYcGPNfZwUngwERA=; b=nJn5Cg8skKfYThBfMjXXs6vkmQg31Aw8TH3dhNNZEv6H2KL2Xu6c++1R 84jfaFsv1IEWyIth/GDFpo8tsYzPFtE1jUen/rAv9EU5fUiiPC/X0LZqe Ow85OPp+C9sblNNvdiJg6aGN8PeT2Y++63wCPaDx+KLA542rr/sRdLSmQ KPyOu5kuMiOqw0EdmBAHDsLWXRdBXbB3rXDQfJtlQjE9bzx5/toI5yvLN vbKFkMH2DNhu7fs0J7Hvcqc00CpYH/RUTOQ54ULwaQN3roy81IJYc51sI 55ZTTktgkEVTtUm2X1wlJZY3CtdKRmXvMpBJsdULhjD3v+V9d/ynqFmpN Q==; X-CSE-ConnectionGUID: YXpkJH8YQUyh1aqBy18WIQ== X-CSE-MsgGUID: 9PSI0lMLTtmPBktz1P6NTw== X-IronPort-AV: E=McAfee;i="6800,10657,11686"; a="73546563" X-IronPort-AV: E=Sophos;i="6.21,261,1763452800"; d="scan'208";a="73546563" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2026 08:59:16 -0800 X-CSE-ConnectionGUID: JxhRMEbMQGKyepJHRqMnRg== X-CSE-MsgGUID: TsvCFEs+T6+qfmmz19/0ig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,261,1763452800"; d="scan'208";a="213121435" Received: from rchatre-mobl4.amr.corp.intel.com (HELO [10.125.110.19]) ([10.125.110.19]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2026 08:59:15 -0800 Message-ID: <8aa96131-c719-411b-92c2-1c3b121d89e6@intel.com> Date: Thu, 29 Jan 2026 08:59:14 -0800 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 06/26] x86/virt/tdx: Prepare to support P-SEAMLDR SEAMCALLs To: Chao Gao Cc: linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org, reinette.chatre@intel.com, ira.weiny@intel.com, kai.huang@intel.com, dan.j.williams@intel.com, yilun.xu@linux.intel.com, sagis@google.com, vannapurve@google.com, paulmck@kernel.org, nik.borisov@suse.com, zhenzhong.duan@intel.com, seanjc@google.com, rick.p.edgecombe@intel.com, kas@kernel.org, dave.hansen@linux.intel.com, vishal.l.verma@intel.com, Farrah Chen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" References: <20260123145645.90444-1-chao.gao@intel.com> <20260123145645.90444-7-chao.gao@intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/29/26 06:55, Chao Gao wrote: > On Wed, Jan 28, 2026 at 03:03:14PM -0800, Dave Hansen wrote: ... > Thanks. This is much clearer than my version. > > One tiny nit: NP-SEAMLDR isn't SEAM mode software. It is an authenticated code > module (ACM). Ahhh, thanks for the correction! >> Then do this part: >> >>> P-SEAMLDR SEAMCALLs differ from SEAMCALLs of the TDX module in terms of >>> error codes and the handling of the current VMCS. >> Except I don't even know how the TDX module handles the current VMCS. >> That probably needs to be in there. Or, it should be brought up in the >> patch itself that implements this. Or, uplifted to the cover letter. > > My logic was: > > 1. The kernel communicates with P-SEAMLDR via SEAMCALL, just like with the TDX > Module. > 2. But P-SEAMLDR SEAMCALLs and TDX Module SEAMCALLs are slightly different. > > So we need some tweaks to the low-level helpers to add separate wrappers for > P-SEAMLDR SEAMCALLs. > > To me, without mentioning #2, these tweaks in this patch (for separate wrappers > in the next patch) aren't justified. My objection is that you talk about the VMCS handling in here but there's no actual VMCS handling. This is the changelog for patch 06/26, not 07/26. Don't talk about the VMCS handling here. When you do, make sure you give enough background. >>> static __always_inline u64 sc_retry(sc_func_t func, u64 fn, >>> struct tdx_module_args *args) >>> { >>> + u64 retry_code = TDX_RND_NO_ENTROPY; >>> int retry = RDRAND_RETRY_LOOPS; >>> u64 ret; >>> >>> + if (unlikely(is_seamldr_call(fn))) >>> + retry_code = SEAMLDR_RND_NO_ENTROPY; >> >> (un)likey() has two uses: >> >> 1. It's in performance critical code and compilers have been >> demonstrated to be generating bad code. >> 2. It's in code where it's not obvious what the fast path is >> and (un)likey() makes the code more readable. >> >> Which one is this? > > I think #2 although I am happy to drop "unlikely". But why does it *MATTER*? Is it important to understand that SEAMLDR calls are rarer than TDX module calls?