From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 202003E1233 for ; Fri, 26 Jun 2026 07:43:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782459833; cv=none; b=AZnNxzn/FLk/ghnhosIGrMXZvKwGiZJQYgGSeMHtuMTJFa4SeKSKdUD/2ylQwfPwnAXxMiXXhV6IZZ8oY9Dgn5vZHoAp0B1KrT69pS3tWLFQv0tBxBHbuGT4/AmXMpU/3vxRagbZ8m12JGGTkDeEwOpzb0Gd1n0zBm7sQynZKRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782459833; c=relaxed/simple; bh=s0U6052cZS8r73pCwXoBgHD40+SRrB/8u/7DqNhuwIY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g4kAGpuiM/p1TkFGpqipwJTCmAAoNwRChiE1C6unBKxMp41UPvVdVnzUEuX39Ng39UQdV6w9RRvAlcwwv7Kcpmze1lPGmPKvbEpgLnAGEieLy8mwGHSH49CZPasJNK4srTA22NY5v65r353n0FLfy96uYQiT/+TCopq7pOeCn9c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JKOYpLp3; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JKOYpLp3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782459831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xt7ue9HwiPWHFMmu1Qr+INx7bk2xLViK4an0U84LPO8=; b=JKOYpLp3yaUHS6OE+l7CdtKCDwB3J3pYCh/OUVijt8TyFRAe0BXve7iXXcTzLTaSOc/UT+ +IZqq3qk5g21fAXlOtZCGRFkUPwdWs+V7Qq8kNQ9uOqqLI6YWakT/4RJ37J1Fjm+mTmISU MG+EvR9aBd+ZNDH94zpidrDRcze/IGY= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-194-Zprj7Tw6NtiiivrZfyb9BQ-1; Fri, 26 Jun 2026 03:43:49 -0400 X-MC-Unique: Zprj7Tw6NtiiivrZfyb9BQ-1 X-Mimecast-MFC-AGG-ID: Zprj7Tw6NtiiivrZfyb9BQ_1782459829 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2c6bbd0afffso11402595ad.0 for ; Fri, 26 Jun 2026 00:43:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782459829; x=1783064629; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Xt7ue9HwiPWHFMmu1Qr+INx7bk2xLViK4an0U84LPO8=; b=HrL8fIxHAEpeM6fMf43JKnWeJfsOF7B9xUg3Q6iCNk0rFegyNXM1/gDH+X7gMUO/C0 iH9vzITpARrl/mPiJVONHrw3G7CRxcpYm8v6v3HQDBJy9UJBs2vk6dRM2JVZ/d59jBU3 +/n31aIaMTSkapMi0ByeuStofHxaIeUpimrvmQXHHe/a3t7X1SnHOgbLyB0pyl3gvc70 RT5110s9aLjflusGRskr80i5I+6wUNhbNlqGr+tg13X2Cxcwx1K3i46GIt857kMkYcA4 1uJW60XeYDXjxKJzluUIoIMfKcvAaQeHmR5kC/LH1gaWkXopg4yLg6ItIXEiVZmxCQlK +0BA== X-Forwarded-Encrypted: i=1; AHgh+RoXEnLPsGJbOrcaBYitdtgqir6wcYXcznC4yeaFiNeD/UgkJKxGXKGlFggjCcWmVQYUkgQYullzZobB@lists.linux.dev X-Gm-Message-State: AOJu0YxORDidL/KKVdHY6LbCQzVt9VDvpJgXVEqU3nE4yIC6Q3xnJsSE gTLuR0QGyclG1amkcgErDoIpLDi7jK8vRqnkMT8Q3EWRMJ9xQ7hoZKuFU2K42kHA0w9MYAAky+6 sOu9yw23a2n8bTkD8Pw7jDxOhnn9jtS7NKwjd1zpchFwtr91B5nZ9UiYaUKu1Wlo= X-Gm-Gg: AfdE7clIEpKdTiBQWif3Oy4ki9odO7qZTWenEOf5Ry5qquHz4lnEQXqWstaJBaZeUCT 0EuK9oEZcaK2T8VSGHlcRnqD2YVk5eRuxDTvROJ1NJTEs8WVnKNVVf3FTm2ujy7Lb1vWSSCOSab Ht/BkYIvjkH6VizoPJo2Vf8FyzgcydNWLX24mYcJOm9W+kt5LmUh/zqNs49ykxO6ntSM5jM80HK G8BGzH5P3zwI+7GKxJ6schy79BQk90W1sAS/LOK9AOJoEFcJdjog9beO7aB5eeysUOPmMevY2W6 MeARYeSIcXNGrLAXBfEGNXYZNK/uaoKD7sBX8XQRasV8H7djqGs0CfkENrd9my3c3it9++pq5uH WizuAoPwtzDYRCHecjnUXRNPBWidKbbj16AHhQ+/etaBCSH5XlpjENQ== X-Received: by 2002:a17:902:d510:b0:2c7:f233:3df8 with SMTP id d9443c01a7336-2c7fc8ab880mr56064635ad.31.1782459828703; Fri, 26 Jun 2026 00:43:48 -0700 (PDT) X-Received: by 2002:a17:902:d510:b0:2c7:f233:3df8 with SMTP id d9443c01a7336-2c7fc8ab880mr56064265ad.31.1782459828076; Fri, 26 Jun 2026 00:43:48 -0700 (PDT) Received: from [192.168.68.51] (n175-34-8-244.mrk21.qld.optusnet.com.au. [175.34.8.244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c7f63b27f4sm34866665ad.53.2026.06.26.00.43.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jun 2026 00:43:47 -0700 (PDT) Message-ID: <8da87878-2a5d-478a-a280-60dbed7ad1b9@redhat.com> Date: Fri, 26 Jun 2026 17:43:34 +1000 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 29/44] arm64: RMI: Runtime faulting of memory To: Suzuki K Poulose , Lorenzo Pieralisi Cc: Steven Price , kvm@vger.kernel.org, kvmarm@lists.linux.dev, Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" , Emi Kisanuki , Vishal Annapurve , WeiLin.Chang@arm.com, Lorenzo.Pieralisi2@arm.com References: <20260513131757.116630-1-steven.price@arm.com> <20260513131757.116630-30-steven.price@arm.com> <3359f788-07fa-41a1-9ac7-45c58577c1fa@redhat.com> <1e39094f-7fa3-4ef1-be54-53d7a8643506@redhat.com> <98d2a0f3-b831-466a-8212-5bcf97ad9d8b@arm.com> From: Gavin Shan In-Reply-To: <98d2a0f3-b831-466a-8212-5bcf97ad9d8b@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: b3r4bu3t6aIE_C-5dh4AByXV76Q7zXOOraeRHCmPDO0_1782459829 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/26/26 1:58 AM, Suzuki K Poulose wrote: > On 25/06/2026 14:53, Gavin Shan wrote: >> On 6/6/26 12:35 AM, Lorenzo Pieralisi wrote: >>> On Fri, Jun 05, 2026 at 06:11:11PM +1000, Gavin Shan wrote: >>>> On 6/5/26 5:28 PM, Lorenzo Pieralisi wrote: >>>>> On Fri, Jun 05, 2026 at 04:23:15PM +1000, Gavin Shan wrote: [...] >>>> >>>> I tried to rebase Jean's latest QEMU series [1] to upstream QEMU, and found >>>> that memory slots backed by THP are broken. With THP disabled on the host and >>>> other fixes (mentioned in my prevous replies) applied on the top of this (v14) >>>> series, I'm able to boot a realm guest with rebased QEMU series [2], plus more >>>> fxies on the top. >>>> >>>> [1] https://git.codelinaro.org/linaro/dcap/qemu.git  (branch: cca/ latest) >>>> [2] https://git.qemu.org/git/qemu.git                (branch: cca/gavin) >>>> >>>> Lorenzo, You may be saying there is someone making QEMU to support ARM/CCA? >>> >>> Mathieu and I are working on that yes and with Steven/Suzuki to fix the THP >>> issues you pointed out above. >>> >>>> If so, I'm not sure if there is a QEMU repository for me to try? >>> >>> We should be able to submit patches by end of June - we shall let you know >>> whether we can make something available earlier. >>> >> >> Not sure if there are other known issues in this series. It seems the stage2 >> page fault handling on the shared space isn't working well. In my test, the >> vring (struct vring_desc) of virtio-net-pci is updated by the guest, and the >> data isn't seen by QEMU, I'm suspecting if the host-page-frame-number is properly >> resolved in the s2 page fault handler for shared (unprotected) space. >> >> - I rebased Jean's latest qemu branch to the upstream qemu; >> >> - On the host, which is emulated by qemu/tcg, the THP (transparent huge page) is >>    disabled. >> >> - On the guest, I can see the virtio vring (struct vring_desc) is updated. The >>    S1 page-table entry looks correct because the corresponding physical address >>    0x10046880000 is a sane shared (unprotected) space address. >> >>    [   52.094143] software IO TLB: Memory encryption is active and system is using DMA bounce buffers >>    [   52.289746] virtqueue_add_desc_split: desc[0]@0xffff000006880000, [00000100b983f000  00000640  0002  0001] >>    [   52.432150] PTE 0x00e8010046880707 at address 0xffff000006880000 >> >> - On the host, the s2 page-table-entry is unmapped due to attribute transition (private -> shared). >>    A subsequent S2 page fault is raised against the adress and the s2 page-table-entry is built. >> >>    [  109.259077] ====> realm_unmap_shared_range: tracked_unprot_addr=0x10046880000 >>    [  109.260249] realm_unmap_shared_range: unmapped shared range at 0x10046880000 >>    [  109.317786] realm_unmap_shared_range: unmapped shared range at 0x10046880000 >>    [  109.629939] ====> kvm_handle_guest_abort: fault_ipa=0x10046880000, esr=0x92000007 >>    [  109.630245] realm_map_non_secure: ipa=0x10046880000, pfn=0xb8b59, size=0x1000, prot=0xf >>    [  109.630331] realm_map_non_secure: ipa=0x10046880000, ipa_top=0x10046881000, flags=0x1e0001, range_desc=0xb8b59004 > > Are you able to correlate the order of the transitions and the Guest > access with RMM log ? We haven't seen this from our end. We are aware > of permission fault issues with Unprotected IPA when backing the memslot > with MAP_PRIVATE areas. But this looks different. > > Lorenzo, have you run into this ? > It's hard to correlate the order since the logs are collected from two separate consoles. For the write permission, I add code to the host where the permission is always added for all s2 page faults in the shared space. Otherwise, qemu can be killed by -EFAULT or similar error. There are more findings after more experiments: this virtio-net-pci device has 3 queues or vrings (Rx/Tx/Ctrl). The Rx/Tx/Ctrl queue are populated in order one after one. In the guest kernel, I intentionally write fixed data (0x0123456789abcdef) to the first 8 bytes of the queue when it gets populated, and stop the guest at random points to see if the data is gone. I found that the data written to Rx/Tx queue are lost after Ctrl queue is allocated. The data written to Rx/Tx queue is lost if the guest stops (B). The data written to Rx/Tx queue isn't lost if the guest stops at (A). I can see the pattern (0x0123...cdef) by dumping the physcial memory through 'pmemsave' command in qemu. DMA allocation ============== dma_alloc_coherent dma_alloc_attrs dma_direct_alloc __dma_direct_alloc_pages dma_set_decrypted // (A) No data lost if being stopped here for the Ctrl queue memset(ret, 0, size) // (B) Data lost after being stopped after memset() for the Ctrl queue The memset() on the Ctrl queue should trigger a stage2 page fault. It seems the page fault enforces the shared pages for Rx/Tx queue to be dropped? I need to add more debugging code and track it down. > Suzuki > > >> >> - On QEMU, the updated vring (struct vring_desc) at GPA 0x46880000 isn't seen. All the >>    data in that adress are zeros. >> >>    ====> virtqueue_split_pop: vdev=, sz=0x38, queue_index=0x0, vq->vring.num=0x100 >>    virtqueue_split_pop: last_avail_idx=0x0, head=0x0 >>    address_space_read_cached_slow: cache@0xffff1c036440, addr=0x0, buf=0xffffeee34880, len=0x10 >>    address_space_read_cached_slow: cache: ptr=0x0, xlat=0x10046880000, len=0x1000, mrs=, is_write=no >>    address_space_read_cached_slow: translated to mr=, mr_addr=0x6880000, l=0x10 >>    flatview_read_continue_step: mr=, host=0xffff23e00000, mr_addr=0x6880000, ram_ptr=0xffff2a680000 >>    virtqueue_split_pop: desc: 0000000000000000 - 00000000 - 00000000 - 00000000 >>    qemu-system-aarch64: virtio: zero sized buffers are not allowed >> >> Thanks, Gavin