From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"seanjc@google.com" <seanjc@google.com>
Cc: "linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"jpoimboe@kernel.org" <jpoimboe@kernel.org>,
"Hansen, Dave" <dave.hansen@intel.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"haiyangz@microsoft.com" <haiyangz@microsoft.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"kys@microsoft.com" <kys@microsoft.com>,
"Cui, Dexuan" <decui@microsoft.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"hpa@zytor.com" <hpa@zytor.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"bp@alien8.de" <bp@alien8.de>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] x86/tdx: Enhance code generation for TDCALL and SEAMCALL wrappers
Date: Wed, 28 Aug 2024 13:34:54 +0000 [thread overview]
Message-ID: <8e3146250f31db92fa42a29a892858c9ec33aeab.camel@intel.com> (raw)
In-Reply-To: <Zl9sXGj890yerBPJ@google.com>
On Tue, 2024-06-04 at 12:34 -0700, Sean Christopherson wrote:
>
> If we're willing to suffer a few gnarly macros, I think we get a satisfactory
> mix
> of standardized arguments and explicit operands, and generate vastly better
> code.
Hi Sean,
We are kind of stuck on improving the code generation for the existing calls.
x86 maintainers don't seem to be enthusiastic about tackling this urgently and
there is not consensus on how to weigh source code clarity with code generation
sanity [0]. I think we are going to table it for the time being, unless it's a
showstopper for you.
An option is still to have a separate helper infrastructure for KVM's calls, but
as discussed originally this duplicates code.
Rick
[0] https://lore.kernel.org/all/3a210286-7d0f-4404-ad79-c8eab1514381@intel.com/
next prev parent reply other threads:[~2024-08-28 13:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-02 11:54 [PATCH] x86/tdx: Enhance code generation for TDCALL and SEAMCALL wrappers Kirill A. Shutemov
2024-06-03 13:37 ` Dave Hansen
2024-06-04 11:37 ` Kirill A. Shutemov
2024-06-04 19:34 ` Sean Christopherson
2024-08-28 13:34 ` Edgecombe, Rick P [this message]
2024-09-11 23:31 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e3146250f31db92fa42a29a892858c9ec33aeab.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kys@microsoft.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).