From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4F6E3AB269 for ; Tue, 1 Sep 2026 04:29:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788236979; cv=none; b=gUuRGCX+8sVkmy4V5pUkyOh1TVSsH3BJIM2KXp06yeuRT3fySYr1ci3IX3eo9u9u9YFieDMfTNC6VYj1UaA+R8j5WJy6mBkbKnGr/tMPa+5KdgjBoHzZt251S74xNQEojYOBe3iRMPm0Nq9Hc3F+w2IF0r9eR+Q7+oYNYjrhVxI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788236979; c=relaxed/simple; bh=b/q72RLD9lBRxi2VmlFM4dWbgfCb6GrTRD2Ri5Ba41s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MUUjaiSR1nGT1tUephBZQNVBm1D5Zv8T1F7NW7DhBtqU/mqOrX0Tcb/gGpy2h7e603gdpL/O8gNYA0WlPh5XKG2TBCDD+cfrpiyyu25kU32XvwBB4j6EH2zK7QWQDwngNVpaxPeqFl0hvANkMyN5kN+rxCg0NK4q4vReUOtRrp8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MCINri1g; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MCINri1g" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788236976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YCQU+V95xqEH8EbNTciL/CsMqe3BTX/wUO0rCYM10FE=; b=MCINri1gBAl2Y5AU/X1mZ1x7bpSitYjHljQdXJiSZq3VhDLv16nW4uOgMIg0gucgFmYE2u ZXrQNABPzwOxj4wWUEqxn5MnaSRFbYVPufXMYTuH8SEiKNxoP3vtUYDpWP9sGz9s/qvbnj 1eq4Xl+xPebXwsoQlVbu5Zo9z8oLTAU= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-bzyjO7fWO5-TXfG3N7Zvig-1; Tue, 01 Sept 2026 00:29:35 -0400 X-MC-Unique: bzyjO7fWO5-TXfG3N7Zvig-1 X-Mimecast-MFC-AGG-ID: bzyjO7fWO5-TXfG3N7Zvig_1788236975 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2d7293f13c6so56013905ad.2 for ; Mon, 31 Aug 2026 21:29:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788236974; x=1788841774; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YCQU+V95xqEH8EbNTciL/CsMqe3BTX/wUO0rCYM10FE=; b=FfnH0IA07iyuSW5p33Y/OLYuAkgNmsh+7ADB6MEgGsgUsc65L9v/pbG/qKuxrfLA+G P3uwXqTsF35XXPi+yOTOo6woYGvPoVjGHC9EpKS6NCl27JpXEwuSbTVHPIMmdmA9fsly Fza1mKtqljbNC5BqRH++W6v/a+pDQrY61ixO3YjS6a/0LLpE1eECm1lc849jv/WMNsHM fqTEzc5u6sDN3/tzweqpOWtzjKLIrXoge6bzz3eNdj/uPBu6lNq52DZwRxFIMiHgj+yI LpwNQ082//Ah66kE+5cOYWlYNoRnhf1SKGxFejF5KGpKC1y/BXclxUSCdey9XXSk8sUL Jwyg== X-Forwarded-Encrypted: i=1; AKwUvBx0iMsooIdOApA2wAdZdCsXXKxON0Fyqxk2ePk05cd/AATC1LCCrisMq8JSk5pI0ngpTpPbFXrckvUb@lists.linux.dev X-Gm-Message-State: AFuF++l2CAAyYUDZ2LuQ5oSMEZQQ4igYh3ZYOZZRhkcJ/6XjxYSyhbO2 YCts62zTlkl5CEU5I034wSdNavLzojttoI8wkuFasO28Ue/HWRONLuGufi2+6xpP8wiFUgwVDG/ er3tzBl/0FqrZ1VuK1M5d0s+Li/R8DSYTievpoBYs5TX0eXDrkEi///yh5NcEVzM= X-Gm-Gg: AYBFou1hA/0Kc5qyyE6LZHdFrB/IsuvQ8lzapgGTANVFH2+24kVTHa4ZYJul0VtQMGK HIAHtZNGcKqNW/kNmdibVCR/icwUHEgK0wpP2WdhHjFWvVQPjr9bZ9ik9gmHlbX/hUuJyCwIQkZ F3iz8ULmykcXTRn5vRDLgo/T4V1Eh210MWwAemt/qbsqq7KHrCyoVu7JE21QXyzX2MzyNLPFb0O 8qsRw/NPp/2U28SCGUGl+HsyEvhNVJ1PvlC6Mri5NcihcmNtBoLgiA8hKFRERN2aalIBvM4nmTM q1LgZP+88NY/UwSLGhp/ww/d+gWp/zvnuTFTax0zgDWFPEc9fiyj255tFh8DjKUN/1H+ubwP3HX 4TUynpTMalwADivmgAivETC9+OuPDFudLDMh11Dsa+A== X-Received: by 2002:a17:903:2acb:b0:2d9:1c02:5a19 with SMTP id d9443c01a7336-2d94a956b48mr72440165ad.22.1788236974485; Mon, 31 Aug 2026 21:29:34 -0700 (PDT) X-Received: by 2002:a17:903:2acb:b0:2d9:1c02:5a19 with SMTP id d9443c01a7336-2d94a956b48mr72439155ad.22.1788236973766; Mon, 31 Aug 2026 21:29:33 -0700 (PDT) Received: from [192.168.68.51] (n175-34-8-244.mrk21.qld.optusnet.com.au. [175.34.8.244]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3286f95a847sm30663601eec.17.2026.08.31.21.29.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Aug 2026 21:29:33 -0700 (PDT) Message-ID: <8e699e2d-c04c-4ff7-98a3-c01e573ee817@redhat.com> Date: Tue, 1 Sep 2026 14:29:22 +1000 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v16 15/45] KVM: arm64: CCA: Don't expose unsupported capabilities for realm guests To: Steven Price , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Suzuki K Poulose , Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" , Emi Kisanuki , Vishal Annapurve , WeiLin.Chang@arm.com, Lorenzo Pieralisi References: <20260803134403.80630-1-steven.price@arm.com> <20260803134403.80630-16-steven.price@arm.com> From: Gavin Shan In-Reply-To: <20260803134403.80630-16-steven.price@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 0wxW7UmsBlOfEObI9DByzxMxJegdiA-Oi1xvLSnZuYY_1788236975 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Steve, On 8/3/26 11:43 PM, Steven Price wrote: > From: Suzuki K Poulose > > RMM v2.0 provides no mechanism for the host to perform debug operations > on the guest. So limit the extensions that are visible to an allowlist > so that only those capabilities we can support are advertised. > > Signed-off-by: Suzuki K Poulose > Signed-off-by: Steven Price > --- > Changes since v13: > * Add missing check in kvm_vm_ioctl_enable_cap(). > Changes since v10: > * Add a kvm_realm_ext_allowed() function which limits which extensions > are exposed to an allowlist. This removes the need for special casing > various extensions. > Changes since v7: > * Remove the helper functions and inline the kvm_is_realm() check with > a ternary operator. > * Rewrite the commit message to explain this patch. > --- > arch/arm64/kvm/arm.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index c4d906861736..6f39831dcf5d 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -135,6 +135,26 @@ int kvm_arch_vcpu_should_kick(struct kvm_vcpu *vcpu) > return kvm_vcpu_exiting_guest_mode(vcpu) == IN_GUEST_MODE; > } > > +static bool kvm_realm_ext_allowed(long ext) > +{ > + switch (ext) { > + case KVM_CAP_IRQCHIP: > + case KVM_CAP_ARM_PSCI: > + case KVM_CAP_ARM_PSCI_0_2: > + case KVM_CAP_NR_VCPUS: > + case KVM_CAP_MAX_VCPUS: > + case KVM_CAP_MAX_VCPU_ID: > + case KVM_CAP_MSI_DEVID: > + case KVM_CAP_ARM_VM_IPA_SIZE: > + case KVM_CAP_ARM_PTRAUTH_ADDRESS: > + case KVM_CAP_ARM_PTRAUTH_GENERIC: > + case KVM_CAP_ARM_RMI: > + case KVM_CAP_SYNC_MMU: > + return true; > + } > + return false; > +} > + Nitpick: The code can be simplified a bit if @kvm is passed to kvm_realm_ext_allowed(). In this way, kvm_realm_ext_allowed() looks similar to kvm_pkvm_ext_allowed(). static bool kvm_realm_ext_allowed(struct kvm *kvm, long ext) { if (!kvm || !kvm_is_realm(kvm)) return true; switch (ext) { case KVM_CAP_IRQCHIP: : case KVM_CAP_SYNC_MMU: return true; } return false; } > int kvm_vm_ioctl_enable_cap(struct kvm *kvm, > struct kvm_enable_cap *cap) > { > @@ -146,6 +166,9 @@ int kvm_vm_ioctl_enable_cap(struct kvm *kvm, > if (is_protected_kvm_enabled() && !kvm_pkvm_ext_allowed(kvm, cap->cap)) > return -EINVAL; > > + if (kvm && kvm_is_realm(kvm) && !kvm_realm_ext_allowed(cap->cap)) > + return -EINVAL; > + if (!kvm_realm_ext_allowed(kvm, cap->cap)) return -EINVAL; > switch (cap->cap) { > case KVM_CAP_ARM_NISV_TO_USER: > r = 0; > @@ -380,6 +403,9 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) > if (is_protected_kvm_enabled() && !kvm_pkvm_ext_allowed(kvm, ext)) > return 0; > > + if (kvm && kvm_is_realm(kvm) && !kvm_realm_ext_allowed(ext)) > + return 0; > + if (!kvm_realm_ext_allowed(kvm, ext)) return 0; > switch (ext) { > case KVM_CAP_IRQCHIP: > r = vgic_present; Thanks, Gavin