From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEBCA22D4DC for ; Fri, 26 Sep 2025 07:31:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758871891; cv=none; b=c39DrMIPaCNVJMOWeeDOABMjUuepUhJmLv+FvbT39WN3tj89UCmbSPhcIgfpX/ehd0fryMzvF3PVpiQPsO/kfVE3ZdABH69QoGtupnpcs5OZdS0LxzGWxptd8xWBXS9B8ayBUSABTyExbWL/9g/Rn9kam53WwYghTDF+HoNUXkc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758871891; c=relaxed/simple; bh=KufU9ZWO/kLUGrCXDHaZph7HljBItyQP4ERJy1huuTc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YYkYZpAoB3SiZBAUvxvz49lNZwz5tCQm01Z4z1ADncjdsKiIyb1V4bNW4zeYGD/tHzLEJeeQqBLD08gB2bbkPssJvOwyNHwSSv1wgILMFF27DY5SlSpkISiJRrC2WlhfbVwdBVvPp2AruV4zsXZT5QZo/9KKlY6EqQ4+GfPNdJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CQejgPi4; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CQejgPi4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758871888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zN4peVxWL0zSknKb/nxU8BZxb2xqfgd1C45ub1DITH8=; b=CQejgPi4wzHkxrgftL9b2/zM5OiRYeb3/RMe7iSnnhrWVqfp3W+AeC79TSJl1a7il6R+P/ kO8PvnlixWp1yuRye4kzHBgBTtr8D5yRATbYCO+yPRouh+OKwVE7k7+ThFx7j8d7gTGUOm sxOkzi5P1M28jQexKkCM2ywtk5/pT/8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-196-9XZFP4tGN1SYXkUbW0ivBg-1; Fri, 26 Sep 2025 03:31:26 -0400 X-MC-Unique: 9XZFP4tGN1SYXkUbW0ivBg-1 X-Mimecast-MFC-AGG-ID: 9XZFP4tGN1SYXkUbW0ivBg_1758871885 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-46da436df64so19390415e9.0 for ; Fri, 26 Sep 2025 00:31:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758871885; x=1759476685; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zN4peVxWL0zSknKb/nxU8BZxb2xqfgd1C45ub1DITH8=; b=XKVWlJWfcbbGjGaxtDslrI9MwFq0WDI3Y8rgRou3moFgONTmjvC8IgqRG4CWmZsjFd KlfoW1FqObx/ROrznt0AZ8hBMoqCJkbkQF3VK04jgr49QOwKgP604b+9DV1Mpc6vlyS5 uXtQkXpQlOMXdzNTMFPQ/8XhmPlSwRi8UoR018IZmjfySVvy510AuhfUZbFBFuxPtEHx 6HOf2JAH+E9tWobuZsKNXyIeF6NIM+V61T1lO9Naa1S6ABy2BYRySoQoVW7pn6vgIaN0 qlbMbYMj7kly/m2i2ZMoRhFXkPcSU2zRxIsWZ2QbRmGT0b+9R2Dzzs3VUe4OLhow98Zp WBFw== X-Forwarded-Encrypted: i=1; AJvYcCUmx+sK2Fsv1uNldj24umP6hMYAINHQCsDUSs8lp054Km4PUCNOWrFjOeXVSdi7mQbSwlLaagvsetRS@lists.linux.dev X-Gm-Message-State: AOJu0YwTcYGhfJFe1NtpXvpvtv+5W0vuNhhRuuajaJO37urIzTw9bolE LZm+WSNKPoJ8QPiBvRy39k6tVVrORez2SnninGw30bC9XsZzVzX6uewpth/jPJVlqb+iidn9B8T N/Jm3gxGNhMBE/K1lT8g+g+EM/30L3acUIQJKpLGXV7kitg3fUgTa/pib2+pW2AE= X-Gm-Gg: ASbGnctj75w/ryZGmETzdqfkPCUcDZuiTFwvAM5Zpt/5xuAa/ENihP9eg7x0piwF7e/ TPanVKmhOSrL1Umf3FcqVliMwPX1QpbnPq+0kgzHf9UJ4LTo5LckpOhwxV4ZIHxgdH/3Pr/8Quh OQNXjlswNbPbaBsdgbWAGLhG8gI6H+qG5QyBjFMXEMyDpg9n107xKDYOvL8plXFW565sKIMGfu/ ZmstLlA4vwaAvr7inJfD8moulQMwPNI6ylqvYl4UNnJk+R+xfJWuQwT997hEoU/W5218HhnTCPs 9dQAbsHhKyrtFS0ahTBa4wCxFmJc0w+Li1nQ7WNr0Q15LvYMaogBEdu7o2L1yUZdyENWgeZEaBb PEVrF/Y4uSPKdYQ2OFQik0n0jfHQuUmv2u08SuV4dXlrh6z/UFFlmdylcOt1ATozGmrCx X-Received: by 2002:a05:600c:3ba9:b0:45d:d2d2:f081 with SMTP id 5b1f17b1804b1-46e329f9c61mr65568355e9.20.1758871884739; Fri, 26 Sep 2025 00:31:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEdCFTWN0OMV/8re7i7X1C3LDq1oeLqj0b7w/lVtU1L4ASh3eR7s8IXfpyY0kZjgB5RF7jO9w== X-Received: by 2002:a05:600c:3ba9:b0:45d:d2d2:f081 with SMTP id 5b1f17b1804b1-46e329f9c61mr65567615e9.20.1758871884155; Fri, 26 Sep 2025 00:31:24 -0700 (PDT) Received: from ?IPV6:2003:d8:2f34:c100:5d3c:50c0:398a:3ac9? (p200300d82f34c1005d3c50c0398a3ac9.dip0.t-ipconnect.de. [2003:d8:2f34:c100:5d3c:50c0:398a:3ac9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e2ab61eecsm105756545e9.20.2025.09.26.00.31.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Sep 2025 00:31:23 -0700 (PDT) Message-ID: <95ace421-36d2-48af-b527-7e799722eb17@redhat.com> Date: Fri, 26 Sep 2025 09:31:19 +0200 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH kvm-next V11 7/7] KVM: guest_memfd: selftests: Add tests for mmap and NUMA policy support To: Sean Christopherson , Shivank Garg Cc: willy@infradead.org, akpm@linux-foundation.org, pbonzini@redhat.com, shuah@kernel.org, vbabka@suse.cz, brauner@kernel.org, viro@zeniv.linux.org.uk, dsterba@suse.com, xiang@kernel.org, chao@kernel.org, jaegeuk@kernel.org, clm@fb.com, josef@toxicpanda.com, kent.overstreet@linux.dev, zbestahu@gmail.com, jefflexu@linux.alibaba.com, dhavale@google.com, lihongbo22@huawei.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, surenb@google.com, mhocko@suse.com, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com, apopple@nvidia.com, tabba@google.com, ackerleytng@google.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, pvorel@suse.cz, bfoster@redhat.com, vannapurve@google.com, chao.gao@intel.com, bharata@amd.com, nikunj@amd.com, michael.day@amd.com, shdhiman@amd.com, yan.y.zhao@intel.com, Neeraj.Upadhyay@amd.com, thomas.lendacky@amd.com, michael.roth@amd.com, aik@amd.com, jgg@nvidia.com, kalyazin@amazon.com, peterx@redhat.com, jack@suse.cz, hch@infradead.org, cgzones@googlemail.com, ira.weiny@intel.com, rientjes@google.com, roypat@amazon.co.uk, chao.p.peng@intel.com, amit@infradead.org, ddutile@redhat.com, dan.j.williams@intel.com, ashish.kalra@amd.com, gshan@redhat.com, jgowans@amazon.com, pankaj.gupta@amd.com, papaluri@amd.com, yuzhao@google.com, suzuki.poulose@arm.com, quic_eberman@quicinc.com, linux-bcachefs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-coco@lists.linux.dev References: <20250827175247.83322-2-shivankg@amd.com> <20250827175247.83322-10-shivankg@amd.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CTWgRHJvIpdaIFIfBvZmmFOvhlXrBZs7Nh2o789vYHE_1758871885 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 25.09.25 23:35, Sean Christopherson wrote: > On Wed, Aug 27, 2025, Shivank Garg wrote: >> Add tests for NUMA memory policy binding and NUMA aware allocation in >> guest_memfd. This extends the existing selftests by adding proper >> validation for: >> - KVM GMEM set_policy and get_policy() vm_ops functionality using >> mbind() and get_mempolicy() >> - NUMA policy application before and after memory allocation >> >> These tests help ensure NUMA support for guest_memfd works correctly. >> >> Signed-off-by: Shivank Garg >> --- >> tools/testing/selftests/kvm/Makefile.kvm | 1 + >> .../testing/selftests/kvm/guest_memfd_test.c | 121 ++++++++++++++++++ >> 2 files changed, 122 insertions(+) >> >> diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm >> index 90f03f00cb04..c46cef2a7cd7 100644 >> --- a/tools/testing/selftests/kvm/Makefile.kvm >> +++ b/tools/testing/selftests/kvm/Makefile.kvm >> @@ -275,6 +275,7 @@ pgste-option = $(call try-run, echo 'int main(void) { return 0; }' | \ >> $(CC) -Werror -Wl$(comma)--s390-pgste -x c - -o "$$TMP",-Wl$(comma)--s390-pgste) >> >> LDLIBS += -ldl >> +LDLIBS += -lnuma > > Hrm, this is going to be very annoying. I don't have libnuma-dev installed on > any of my systems, and I doubt I'm alone. Installing the package is > trivial, but I'm a little wary of foisting that requirement on all KVM developers > and build bots. > > I'd be especially curious what ARM and RISC-V think, as NUMA is likely a bit less > prevelant there. We unconditionally use it in the mm tests for ksm and migration tests, so it's not particularly odd to require it here as well. What we do with liburing in mm selftests is to detect presence at compile time and essentially make the tests behave differently based on availability (see check_config.sh). -- Cheers David / dhildenb