* [PATCH -next] x86/virt/tdx: Remove duplicated include in tdx.c
@ 2023-12-12 0:38 Yang Li
2023-12-12 1:05 ` Huang, Kai
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yang Li @ 2023-12-12 0:38 UTC (permalink / raw)
To: mingo, tglx, x86
Cc: hpa, kirill.shutemov, dave.hansen, linux-coco, linux-kernel,
Yang Li, Abaci Robot
The header files linux/acpi.h and asm/cpufeature.h are both
included twice in C, so one inclusion of each can be removed.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7713
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
arch/x86/virt/vmx/tdx/tdx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c
index 13df68ef40b5..49a1c6890b55 100644
--- a/arch/x86/virt/vmx/tdx/tdx.c
+++ b/arch/x86/virt/vmx/tdx/tdx.c
@@ -27,14 +27,12 @@
#include <linux/log2.h>
#include <linux/acpi.h>
#include <linux/suspend.h>
-#include <linux/acpi.h>
#include <asm/page.h>
#include <asm/special_insns.h>
#include <asm/msr-index.h>
#include <asm/msr.h>
#include <asm/cpufeature.h>
#include <asm/tdx.h>
-#include <asm/cpufeature.h>
#include <asm/intel-family.h>
#include <asm/processor.h>
#include <asm/mce.h>
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] x86/virt/tdx: Remove duplicated include in tdx.c
2023-12-12 0:38 [PATCH -next] x86/virt/tdx: Remove duplicated include in tdx.c Yang Li
@ 2023-12-12 1:05 ` Huang, Kai
2023-12-12 10:33 ` kirill.shutemov
2023-12-12 18:59 ` Dave Hansen
2 siblings, 0 replies; 4+ messages in thread
From: Huang, Kai @ 2023-12-12 1:05 UTC (permalink / raw)
To: tglx@linutronix.de, mingo@redhat.com, yang.lee@linux.alibaba.com,
x86@kernel.org
Cc: hpa@zytor.com, kirill.shutemov@linux.intel.com,
linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org,
abaci@linux.alibaba.com, dave.hansen@linux.intel.com
On Tue, 2023-12-12 at 08:38 +0800, Yang Li wrote:
> The header files linux/acpi.h and asm/cpufeature.h are both
> included twice in C, so one inclusion of each can be removed.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7713
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Kai Huang <kai.huang@intel.com>
> ---
> arch/x86/virt/vmx/tdx/tdx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c
> index 13df68ef40b5..49a1c6890b55 100644
> --- a/arch/x86/virt/vmx/tdx/tdx.c
> +++ b/arch/x86/virt/vmx/tdx/tdx.c
> @@ -27,14 +27,12 @@
> #include <linux/log2.h>
> #include <linux/acpi.h>
> #include <linux/suspend.h>
> -#include <linux/acpi.h>
> #include <asm/page.h>
> #include <asm/special_insns.h>
> #include <asm/msr-index.h>
> #include <asm/msr.h>
> #include <asm/cpufeature.h>
> #include <asm/tdx.h>
> -#include <asm/cpufeature.h>
> #include <asm/intel-family.h>
> #include <asm/processor.h>
> #include <asm/mce.h>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] x86/virt/tdx: Remove duplicated include in tdx.c
2023-12-12 0:38 [PATCH -next] x86/virt/tdx: Remove duplicated include in tdx.c Yang Li
2023-12-12 1:05 ` Huang, Kai
@ 2023-12-12 10:33 ` kirill.shutemov
2023-12-12 18:59 ` Dave Hansen
2 siblings, 0 replies; 4+ messages in thread
From: kirill.shutemov @ 2023-12-12 10:33 UTC (permalink / raw)
To: Yang Li
Cc: mingo, tglx, x86, hpa, dave.hansen, linux-coco, linux-kernel,
Abaci Robot
On Tue, Dec 12, 2023 at 08:38:25AM +0800, Yang Li wrote:
> The header files linux/acpi.h and asm/cpufeature.h are both
> included twice in C, so one inclusion of each can be removed.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7713
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kiryl Shutsemau / Kirill A. Shutemov
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] x86/virt/tdx: Remove duplicated include in tdx.c
2023-12-12 0:38 [PATCH -next] x86/virt/tdx: Remove duplicated include in tdx.c Yang Li
2023-12-12 1:05 ` Huang, Kai
2023-12-12 10:33 ` kirill.shutemov
@ 2023-12-12 18:59 ` Dave Hansen
2 siblings, 0 replies; 4+ messages in thread
From: Dave Hansen @ 2023-12-12 18:59 UTC (permalink / raw)
To: Yang Li, mingo, tglx, x86
Cc: hpa, kirill.shutemov, dave.hansen, linux-coco, linux-kernel,
Abaci Robot
On 12/11/23 16:38, Yang Li wrote:
> The header files linux/acpi.h and asm/cpufeature.h are both
> included twice in C, so one inclusion of each can be removed.
Thanks for the report. I've just squashed this back into the culprit patch.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-12 19:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-12 0:38 [PATCH -next] x86/virt/tdx: Remove duplicated include in tdx.c Yang Li
2023-12-12 1:05 ` Huang, Kai
2023-12-12 10:33 ` kirill.shutemov
2023-12-12 18:59 ` Dave Hansen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).