From: Dionna Amalie Glaze <dionnaglaze@google.com>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Joerg Roedel <jroedel@suse.de>,
Michael Roth <michael.roth@amd.com>,
Nikunj A Dadhania <nikunj@amd.com>,
Peter Gonda <pgonda@google.com>,
Tom Lendacky <Thomas.Lendacky@amd.com>,
linux-coco@lists.linux.dev, x86@kernel.org
Subject: Re: [PATCH 03/11] virt/coco/sev-guest: Simplify extended guest request handling
Date: Thu, 16 Feb 2023 08:43:54 -0800 [thread overview]
Message-ID: <CAAH4kHaMCP0-=D1-QnsXa7wAtt22ZdTJD999hphKTpEQuM18aA@mail.gmail.com> (raw)
In-Reply-To: <20230216124120.26578-4-bp@alien8.de>
> if (ghcb->save.sw_exit_info_2) {
> /* Number of expected pages are returned in RBX */
> if (exit_code == SVM_VMGEXIT_EXT_GUEST_REQUEST &&
> - ghcb->save.sw_exit_info_2 == SNP_GUEST_REQ_INVALID_LEN)
> + ghcb->save.sw_exit_info_2 == SNP_GUEST_REQ_INVALID_LEN) {
> input->data_npages = ghcb_get_rbx(ghcb);
> + ret = -ENOSPC;
> + } else {
> + ret = -EIO;
> + }
>
> *fw_err = ghcb->save.sw_exit_info_2;
> -
> - ret = -EIO;
> }
I think *fw_err still needs to be hoisted out of this if block so that
a 0 fw_err gets written back to user space rather than the 0xff
placeholder. The 0 would more correctly indicate the lack of an error.
--
-Dionna Glaze, PhD (she/her)
next prev parent reply other threads:[~2023-02-16 16:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 12:41 [PATCH 00/11] SEV: Cleanup sev-guest a bit and add throttling Borislav Petkov
2023-02-16 12:41 ` [PATCH 01/11] crypto: ccp - Name -1 return value as SEV_RET_NO_FW_CALL Borislav Petkov
2023-02-16 12:41 ` [PATCH 02/11] virt/coco/sev-guest: Check SEV_SNP attribute at probe time Borislav Petkov
2023-02-16 12:41 ` [PATCH 03/11] virt/coco/sev-guest: Simplify extended guest request handling Borislav Petkov
2023-02-16 16:43 ` Dionna Amalie Glaze [this message]
2023-02-16 12:41 ` [PATCH 04/11] virt/coco/sev-guest: Remove the disable_vmpck label in handle_guest_request() Borislav Petkov
2023-02-16 12:41 ` [PATCH 05/11] virt/coco/sev-guest: Carve out the request issuing logic into a helper Borislav Petkov
2023-02-16 12:45 ` [PATCH 06/11] virt/coco/sev-guest: Do some code style cleanups Borislav Petkov
2023-02-16 12:45 ` [PATCH 07/11] virt/coco/sev-guest: Convert the sw_exit_info_2 checking to a switch-case Borislav Petkov
2023-02-16 12:45 ` [PATCH 08/11] virt/coco/sev-guest: Add throttling awareness Borislav Petkov
2023-02-16 12:46 ` [PATCH 09/11] virt/coco/sev-guest: Double-buffer messages Borislav Petkov
2023-02-16 12:46 ` [PATCH 10/11] crypto: ccp: Get rid of __sev_platform_init_locked()'s local function pointer Borislav Petkov
2023-02-16 12:46 ` [PATCH 11/11] x86/sev: Change snp_guest_issue_request()'s fw_err argument Borislav Petkov
2023-02-16 16:59 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAH4kHaMCP0-=D1-QnsXa7wAtt22ZdTJD999hphKTpEQuM18aA@mail.gmail.com' \
--to=dionnaglaze@google.com \
--cc=Thomas.Lendacky@amd.com \
--cc=bp@alien8.de \
--cc=jroedel@suse.de \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=nikunj@amd.com \
--cc=pgonda@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).