linux-coco.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Dionna Amalie Glaze <dionnaglaze@google.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-coco@lists.linux.dev, Borislav Petkov <bp@alien8.de>,
	 Tom Lendacky <thomas.lendacky@amd.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	peterz@infradead.org,  x86@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] virt: sevguest: Prep for kernel internal {get, get_ext}_report()
Date: Mon, 14 Aug 2023 09:58:10 -0700	[thread overview]
Message-ID: <CAAH4kHbRkFdmdQyPHjOjnnyuYXPLT2GKmQTE8fU9aDFMtri8ew@mail.gmail.com> (raw)
In-Reply-To: <169199900677.1782217.12516417657696965559.stgit@dwillia2-xfh.jf.intel.com>

>
>         switch (ioctl) {
>         case SNP_GET_REPORT:
> -               ret = get_report(snp_dev, &input);
> +               ret = get_report(snp_dev, &input, SNP_UARG);
>                 break;
>         case SNP_GET_DERIVED_KEY:
>                 ret = get_derived_key(snp_dev, &input);
>                 break;

Do we have an agreement around the continued existence of sev-guest
for supporting derived keys, is that similarly slated for the chopping
block, or is it left undecided?
It appears your choice to not include the uarg/karg extension here is
deliberate.

>         case SNP_GET_EXT_REPORT:
> -               ret = get_ext_report(snp_dev, &input);
> +               ret = get_ext_report(snp_dev, &input, SNP_UARG);
>                 break;
>         default:
>                 break;
>

Reviewed-by: Dionna Glaze <dionnaglaze@google.com>

-- 
-Dionna Glaze, PhD (she/her)

  reply	other threads:[~2023-08-14 16:58 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-14  7:43 [PATCH v2 0/5] tsm: Attestation Report ABI Dan Williams
2023-08-14  7:43 ` [PATCH v2 1/5] virt: coco: Add a coco/Makefile and coco/Kconfig Dan Williams
2023-08-14  7:43 ` [PATCH v2 2/5] tsm: Introduce a shared ABI for attestation reports Dan Williams
2023-08-14  8:24   ` Jeremi Piotrowski
2023-08-14 16:21     ` Dan Williams
2023-08-14 15:38   ` Greg Kroah-Hartman
2023-08-14 16:43     ` Dan Williams
2023-08-14 18:43       ` Greg Kroah-Hartman
2023-08-15 19:51   ` Tom Lendacky
2023-08-16 14:44   ` Tom Lendacky
2023-08-16 15:12     ` Dan Williams
2023-08-22  7:29   ` Roy Hopkins
2023-08-23 13:49   ` Samuel Ortiz
2023-08-28 10:46     ` Dr. Greg
2023-08-14  7:43 ` [PATCH v2 3/5] virt: sevguest: Prep for kernel internal {get, get_ext}_report() Dan Williams
2023-08-14 16:58   ` Dionna Amalie Glaze [this message]
2023-08-14 23:24     ` Dan Williams
2023-08-15 20:11       ` Tom Lendacky
2023-08-15 21:03         ` Dan Williams
2023-08-16 19:38           ` Dionna Amalie Glaze
2023-08-15 20:20   ` Tom Lendacky
2023-08-15 21:37     ` Dan Williams
2023-08-14  7:43 ` [PATCH v2 4/5] mm/slab: Add __free() support for kvfree Dan Williams
2023-08-14 15:31   ` Greg Kroah-Hartman
2023-08-14 16:17     ` Peter Zijlstra
2023-08-14 18:44       ` Greg Kroah-Hartman
2023-08-14 18:45         ` Greg Kroah-Hartman
2024-01-04  6:57       ` Lukas Wunner
2024-01-04 18:29         ` Dan Williams
2023-08-14  7:43 ` [PATCH v2 5/5] virt: sevguest: Add TSM_REPORTS support for SNP_{GET, GET_EXT}_REPORT Dan Williams
2023-08-14  8:30   ` Jeremi Piotrowski
2023-08-14 16:22     ` Dan Williams
2023-08-14 11:21   ` Peter Zijlstra
2023-08-14 16:25     ` Dan Williams
2023-08-14 16:48       ` Peter Zijlstra
2023-08-14 22:15         ` Peter Zijlstra
2023-08-15  8:37           ` Peter Zijlstra
2023-08-15 20:50   ` Tom Lendacky
2023-08-15 21:40     ` Dan Williams
2023-08-14  9:04 ` [PATCH v2 0/5] tsm: Attestation Report ABI Jeremi Piotrowski
2023-08-14 17:12   ` Dan Williams
2023-08-15 14:27     ` Peter Gonda
2023-08-15 17:16       ` Dionna Amalie Glaze
2023-08-15 21:13         ` Dan Williams
2023-08-15 18:13       ` Dan Williams
2023-08-16  9:42     ` Jeremi Piotrowski
2023-08-23 11:21   ` Dr. Greg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAH4kHbRkFdmdQyPHjOjnnyuYXPLT2GKmQTE8fU9aDFMtri8ew@mail.gmail.com \
    --to=dionnaglaze@google.com \
    --cc=bp@alien8.de \
    --cc=brijesh.singh@amd.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).