From: Chong Cai <chongc@google.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Qinkun Bao <qinkun@google.com>,
linux-coco@lists.linux.dev,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Dionna Amalie Glaze <dionnaglaze@google.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Peter Gonda <pgonda@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Samuel Ortiz <sameo@rivosinc.com>,
Thomas Gleixner <tglx@linutronix.de>,
Tom Lendacky <thomas.lendacky@amd.com>,
peterz@infradead.org, Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, kmoy@google.com
Subject: Re: [PATCH v7 3/7] configfs-tsm: Introduce a shared ABI for attestation reports
Date: Thu, 26 Oct 2023 18:30:10 -0700 [thread overview]
Message-ID: <CALRH0CjCu+11qMV90x5ZmkjeU3SybFTwbY1puTctd7bFRyxEaw@mail.gmail.com> (raw)
In-Reply-To: <65397556ee5cc_7258329495@dwillia2-xfh.jf.intel.com.notmuch>
Hi Dan,
Thank you for your effort to get this important patch ready to unblock
various user cases including ours.
Sorry for any confusion our reply may have caused. Just to clarify,
the goal of the previous reply from Qinkun was not to push back/delay
this patch. We have already tested the patch internally for both
SEV-SNP and TDX, and have no intention to add more complication to the
kernel.
We discussed the synchronization issue internally and with you and
others before, and we understand what is required from userspace to
adopt this patch, which is reasonable. The previous reply simply
serves the purpose for other users to be aware which user space care
they need to provide, since they may not be involved in the previous
discussions.
Chong
On Wed, Oct 25, 2023 at 1:06 PM Dan Williams <dan.j.williams@intel.com> wrote:
>
> Qinkun Bao wrote:
> [..]
> > The patch raised some internal discussions at Google. Some have concerns
> > about the potential collision problems. We have reached out to Dan. Dan
> > mentioned that “configfs puts some onus on userspace to avoid collisions”.
> > I have listed the changes in the userspace here to ensure that we have the
> > correct understanding and that the complexity for the userspace is necessary.
>
> I am disappointed this conversation continues to be revisited. Configfs
> is an established ABI mechanism that requires well behaved userspace.
> Configfs is not alone in this requirement which is why mechanisms like
> D-Bus exist to broker a service for multiple clients. Configfs at least
> allows each container to have its own broker which was a concession in
> this effort to balance cross-container management complexity.
>
> Yes, userspace care is necessary for configfs. On balance, I would
> choose to spend my time building a userspace broker before entertaining
> an idea to onboard more complication to the kernel.
next prev parent reply other threads:[~2023-10-27 1:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 1:16 [PATCH v7 0/7] configfs-tsm: Attestation Report ABI Dan Williams
2023-10-20 1:16 ` [PATCH v7 1/7] virt: sevguest: Fix passing a stack buffer as a scatterlist target Dan Williams
2023-10-20 1:16 ` [PATCH v7 2/7] virt: coco: Add a coco/Makefile and coco/Kconfig Dan Williams
2023-10-20 1:16 ` [PATCH v7 3/7] configfs-tsm: Introduce a shared ABI for attestation reports Dan Williams
2023-10-25 4:14 ` Qinkun Bao
2023-10-25 20:06 ` Dan Williams
2023-10-27 1:30 ` Chong Cai [this message]
2023-10-20 1:16 ` [PATCH v7 4/7] virt: sevguest: Prep for kernel internal get_ext_report() Dan Williams
2023-10-20 1:16 ` [PATCH v7 5/7] mm/slab: Add __free() support for kvfree Dan Williams
2023-10-20 1:17 ` [PATCH v7 6/7] virt: sevguest: Add TSM_REPORTS support for SNP_GET_EXT_REPORT Dan Williams
2023-10-20 3:25 ` Alexey Kardashevskiy
2023-10-20 1:17 ` [PATCH v7 7/7] virt: tdx-guest: Add Quote generation support using TSM_REPORTS Dan Williams
2023-10-24 17:08 ` Dan Williams
2023-12-21 1:50 ` Xiaoyao Li
2024-01-08 2:55 ` Kuppuswamy Sathyanarayanan
2024-01-09 2:13 ` Xiaoyao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALRH0CjCu+11qMV90x5ZmkjeU3SybFTwbY1puTctd7bFRyxEaw@mail.gmail.com \
--to=chongc@google.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dionnaglaze@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kmoy@google.com \
--cc=linux-coco@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=pgonda@google.com \
--cc=qinkun@google.com \
--cc=sameo@rivosinc.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).