From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F16E1A931 for ; Thu, 9 Feb 2023 19:48:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675972095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JLB/j3TkDxPe2Ifjg9f2yoKGkddHFcQGKgP3GFg7Ob0=; b=K9T2hSeCrw5gQUN4kDBbnf+iHfrJyBbNnsioIJN7uPyufg4ifdekGp1GU/Ym0ja6+t6RxB XXLqy6f/lUN47S0BoupOh7tPjDSexnAqzv+LLof9OM/iWc3mX9AQqUIp3hPHOpdlPPYPkA 1B5mk+jBeNlSF/716oU/3TdieG7ZCIo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-74-9h0_ISabOTGVmNrjWCC58A-1; Thu, 09 Feb 2023 14:48:12 -0500 X-MC-Unique: 9h0_ISabOTGVmNrjWCC58A-1 Received: by mail-wm1-f71.google.com with SMTP id e38-20020a05600c4ba600b003dc434dabbdso3332024wmp.6 for ; Thu, 09 Feb 2023 11:48:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JLB/j3TkDxPe2Ifjg9f2yoKGkddHFcQGKgP3GFg7Ob0=; b=BV8WQ68zrF+0bRgifRsLs5n6VoyFhQW8zdmveqdmkDYjsRuMN8l6D0YIiG4PfR6C4A 5rgGi6JSHwAwb9/493XN/smS9S6Z6nbZvFZFRTxjomDVnsaFuKQ/7/BChy18Sfjd3AG9 Ewa7mFTKRuqjFrPectGmj/kN5+/3RnHtGmQzBI201KGO/lX2l7bVOdpFt58yLEEEWrVE tFSjAZ0rQLtHPo9SO7BhYqOg8NLF0WIz/CGs7emhK6nCN1wm9rv42a9QJ6nInHWviRcv CLC55BDEqKd22HW5LhNNNTP1g2ljnxhUDpNur9TFQQt86hm8b7XPyk1hygnlAmwhfzoZ 7ARA== X-Gm-Message-State: AO0yUKUsz7oEPMOUepmMQlhyYUsjOOSb/1nq29tBQ+vLSrhR0kV3ZU0O FvE8QzQ39CAwlSnqqwWKb2vrDWUMrlEU7ri0gctUxAuA81qmpO/VveOvowiTGEET1vgwBtSSKg7 RXPv+8T1I20IF4j+w2+0S9A== X-Received: by 2002:a5d:67c6:0:b0:2c5:3fcb:6830 with SMTP id n6-20020a5d67c6000000b002c53fcb6830mr1864354wrw.47.1675972091367; Thu, 09 Feb 2023 11:48:11 -0800 (PST) X-Google-Smtp-Source: AK7set+aKA0QFjwLg+f0HQfDEKr3EdsNsL3InfWZ+QlzyoWSFZjoaZBLuxj82eEY7MzaXa5mi/1g3Q== X-Received: by 2002:a5d:67c6:0:b0:2c5:3fcb:6830 with SMTP id n6-20020a5d67c6000000b002c53fcb6830mr1864345wrw.47.1675972091202; Thu, 09 Feb 2023 11:48:11 -0800 (PST) Received: from work-vm (ward-16-b2-v4wan-166627-cust863.vm18.cable.virginm.net. [81.97.203.96]) by smtp.gmail.com with ESMTPSA id t2-20020adfe102000000b002c3f280bdc7sm1988622wrz.96.2023.02.09.11.48.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 11:48:10 -0800 (PST) Date: Thu, 9 Feb 2023 19:48:08 +0000 From: "Dr. David Alan Gilbert" To: Thomas Gleixner Cc: Greg Kroah-Hartman , Christophe de Dinechin , "Reshetova, Elena" , "Michael S. Tsirkin" , Theodore Ts'o , Carlos Bilbao , "Shishkin, Alexander" , "Shutemov, Kirill" , "Kuppuswamy, Sathyanarayanan" , "Kleen, Andi" , "Hansen, Dave" , Peter Zijlstra , "Wunner, Lukas" , Mika Westerberg , Jason Wang , "Poimboe, Josh" , "aarcange@redhat.com" , Cfir Cohen , Marc Orr , "jbachmann@google.com" , "pgonda@google.com" , "keescook@chromium.org" , James Morris , Michael Kelley , "Lange, Jon" , "linux-coco@lists.linux.dev" , Linux Kernel Mailing List Subject: Re: Linux guest kernel threat model for Confidential Computing Message-ID: References: <20044cae-4fab-7ef6-02a0-5955a56e5767@amd.com> <20230208041913-mutt-send-email-mst@kernel.org> <87bkm42dcs.ffs@tglx> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <87bkm42dcs.ffs@tglx> User-Agent: Mutt/2.2.9 (2022-11-12) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline * Thomas Gleixner (tglx@linutronix.de) wrote: > On Wed, Feb 08 2023 at 18:02, David Alan Gilbert wrote: > > * Greg Kroah-Hartman (gregkh@linuxfoundation.org) wrote: > >> Anyway, you all are just spinning in circles now. I'll just mute this > >> thread until I see an actual code change as it seems to be full of > >> people not actually sending anything we can actually do anything with. > > There have been random patchs posted which finally caused this > discussion to start. Wrong order obviously :) > > > I think the challenge will be to come up with non-intrusive, minimal > > changes; obviously you don't want stuff shutgunned everywhere. > > That has been tried by doing random surgery, e.g. caching some > particular PCI config value. While that might not look intrusive on the > first glance, these kind of punctual changes are the begin of a whack a > mole game and will end up in an uncoordinated maze of tiny mitigations > which make the code harder to maintain. > > The real challenge is to come up with threat classes and mechanisms > which squash the whole class. Done right, e.g. caching a range of config > space values (or all of it) might give a benefit even for the bare metal > or general virtualization case. Yeh, reasonable. > That's quite some work, but its much more palatable than a trickle of > "fixes" when yet another source of trouble has been detected by a tool > or human inspection. > > It's also more future proof because with the current approach of > scratching the itch of the day the probability that the just "mitigated" > issue comes back due to unrelated changes is very close to 100%. > > It's not any different than any other threat class problem. I wonder if trying to group/categorise the output of Intel's tool would allow common problematic patterns to be found to then try and come up with more concrete fixes for whole classes of issues. Dave > Thanks, > > tglx > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK