* [PATCH] virt: sev-guest: Add MODULE_ALIAS
@ 2022-11-04 20:42 Cole Robinson
2022-11-04 20:53 ` Borislav Petkov
2022-11-07 22:10 ` Tom Lendacky
0 siblings, 2 replies; 5+ messages in thread
From: Cole Robinson @ 2022-11-04 20:42 UTC (permalink / raw)
To: linux-coco, linux-kernel
Cc: thomas.lendacky, brijesh.singh, bp, Cole Robinson
This fixes driver autoloading
Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
drivers/virt/coco/sev-guest/sev-guest.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/sev-guest/sev-guest.c
index f422f9c58ba7..4c426dbcd166 100644
--- a/drivers/virt/coco/sev-guest/sev-guest.c
+++ b/drivers/virt/coco/sev-guest/sev-guest.c
@@ -744,3 +744,4 @@ MODULE_AUTHOR("Brijesh Singh <brijesh.singh@amd.com>");
MODULE_LICENSE("GPL");
MODULE_VERSION("1.0.0");
MODULE_DESCRIPTION("AMD SEV Guest Driver");
+MODULE_ALIAS("platform:sev-guest");
--
2.37.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] virt: sev-guest: Add MODULE_ALIAS
2022-11-04 20:42 [PATCH] virt: sev-guest: Add MODULE_ALIAS Cole Robinson
@ 2022-11-04 20:53 ` Borislav Petkov
2022-11-05 16:08 ` Cole Robinson
2022-11-07 22:10 ` Tom Lendacky
1 sibling, 1 reply; 5+ messages in thread
From: Borislav Petkov @ 2022-11-04 20:53 UTC (permalink / raw)
To: Cole Robinson; +Cc: linux-coco, linux-kernel, thomas.lendacky, brijesh.singh
On Fri, Nov 04, 2022 at 04:42:45PM -0400, Cole Robinson wrote:
> This fixes driver autoloading
What is the scenario where this needs to be autoloaded?
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman
(HRB 36809, AG Nürnberg)
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] virt: sev-guest: Add MODULE_ALIAS
2022-11-04 20:53 ` Borislav Petkov
@ 2022-11-05 16:08 ` Cole Robinson
2022-11-07 14:09 ` Tom Lendacky
0 siblings, 1 reply; 5+ messages in thread
From: Cole Robinson @ 2022-11-05 16:08 UTC (permalink / raw)
To: Borislav Petkov; +Cc: linux-coco, linux-kernel, thomas.lendacky, brijesh.singh
On 11/4/22 4:53 PM, Borislav Petkov wrote:
> On Fri, Nov 04, 2022 at 04:42:45PM -0400, Cole Robinson wrote:
>> This fixes driver autoloading
>
> What is the scenario where this needs to be autoloaded?
>
Any use case that needs /dev/sev-guest, I guess. Saves software from
having to do the modprobe manually. For example, nothing I can find in
https://github.com/AMDESE/sev-guest loads the driver, it expects
/dev/sev-guest to be there already
Mostly I assumed lack of autoloading was an oversight. Was it
intentionally omitted?
Thanks,
Cole
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] virt: sev-guest: Add MODULE_ALIAS
2022-11-05 16:08 ` Cole Robinson
@ 2022-11-07 14:09 ` Tom Lendacky
0 siblings, 0 replies; 5+ messages in thread
From: Tom Lendacky @ 2022-11-07 14:09 UTC (permalink / raw)
To: Cole Robinson, Borislav Petkov; +Cc: linux-coco, linux-kernel, brijesh.singh
On 11/5/22 11:08, Cole Robinson wrote:
> On 11/4/22 4:53 PM, Borislav Petkov wrote:
>> On Fri, Nov 04, 2022 at 04:42:45PM -0400, Cole Robinson wrote:
>>> This fixes driver autoloading
>>
>> What is the scenario where this needs to be autoloaded?
>>
>
> Any use case that needs /dev/sev-guest, I guess. Saves software from
> having to do the modprobe manually. For example, nothing I can find in
> https://github.com/AMDESE/sev-guest loads the driver, it expects
> /dev/sev-guest to be there already
>
> Mostly I assumed lack of autoloading was an oversight. Was it
> intentionally omitted?
It probably was an oversight. To me, it makes sense to auto-load the
module if the SNP support created the platform device as part of SNP
initialization.
Thanks,
Tom
>
> Thanks,
> Cole
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] virt: sev-guest: Add MODULE_ALIAS
2022-11-04 20:42 [PATCH] virt: sev-guest: Add MODULE_ALIAS Cole Robinson
2022-11-04 20:53 ` Borislav Petkov
@ 2022-11-07 22:10 ` Tom Lendacky
1 sibling, 0 replies; 5+ messages in thread
From: Tom Lendacky @ 2022-11-07 22:10 UTC (permalink / raw)
To: Cole Robinson, linux-coco, linux-kernel; +Cc: brijesh.singh, bp
On 11/4/22 15:42, Cole Robinson wrote:
> This fixes driver autoloading
>
> Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> drivers/virt/coco/sev-guest/sev-guest.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/sev-guest/sev-guest.c
> index f422f9c58ba7..4c426dbcd166 100644
> --- a/drivers/virt/coco/sev-guest/sev-guest.c
> +++ b/drivers/virt/coco/sev-guest/sev-guest.c
> @@ -744,3 +744,4 @@ MODULE_AUTHOR("Brijesh Singh <brijesh.singh@amd.com>");
> MODULE_LICENSE("GPL");
> MODULE_VERSION("1.0.0");
> MODULE_DESCRIPTION("AMD SEV Guest Driver");
> +MODULE_ALIAS("platform:sev-guest");
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-11-07 22:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-04 20:42 [PATCH] virt: sev-guest: Add MODULE_ALIAS Cole Robinson
2022-11-04 20:53 ` Borislav Petkov
2022-11-05 16:08 ` Cole Robinson
2022-11-07 14:09 ` Tom Lendacky
2022-11-07 22:10 ` Tom Lendacky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).