From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B6CD168 for ; Mon, 19 Jul 2021 20:13:33 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id 37so20374101pgq.0 for ; Mon, 19 Jul 2021 13:13:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=r/EnTR5HRnLRPbtfmcrWf34QUCEOk8jn8W/r6abFvvg=; b=Ci3kpL9CZ6X85DeWmauzm5v8gjjaCLEZN36CGhMDHs3xJ1XgcgIVr1r10GUzNeok1u 3VOID1uAgVhMS8ZqHPnAsbO8+6eyv0+7DwTiK+vFJp2bfdDHPCOiv9oHGyS35/Xsllmj N7HnSARfQZcqzTFqUj4+6mSFyU/XGyTHkLI4q57WF29r38IawgIRHzyHhaARFyQ2d9yW N2HAEM+SVmc7JmTshyFQYOGyG7ir1hhM8bFiyPCSmLeMDb4G0e9SchZ4xRZaTEn+LbNg sjXTjzfjIP+m8cFGo5Z4VyTOADc3bNSFapplT4SotCIq6/ogCksebNf2sUcLSswRH0DO aoOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=r/EnTR5HRnLRPbtfmcrWf34QUCEOk8jn8W/r6abFvvg=; b=DQ/6GdAZ8R3jPGuSlBp8WKFtGgK4G0OcUAaMywAsOd+wKfWYxbh9IrpHhoWKB9UU3r 0+edu6Uda+q81KFItooEKg8BfYPaSlsLw8LIX4vJlxSEzR6YcdOnC+x65yxYDOVxlFRX S9+Tu7nDXwqPAlVAQb7Mrov8TU0sehACjRrWBO7oKbn6LLs3OQeeQktw0fAcp04623Ag kiL0DLUnH/NN3gyWeEzFNGzofyaM0Y90P8SKAUCOPGf/vxbMiXyxKGXnv0CniDuc40eR Q9lDDXZZSH7jlC5aW9Pi0ZfkoX9Pp1lvzvmQGESqwr4hv+4FZuAk0tx/41vTZr0i0e7j /GcA== X-Gm-Message-State: AOAM530CiDqEE2G03v+PyV63LT1NY5JRmbtfrYe1kLwlyZGqgT+Dbw1N fC0xN3tvHGEOfKZfgeIG/p7ywg== X-Google-Smtp-Source: ABdhPJw6c0LUvD49cuzprQ9WIbuUefstwL+8gGNos16WYz12XvCL7/lToKmBY8QygLEtkXZ0mGyYVA== X-Received: by 2002:a63:4e4d:: with SMTP id o13mr12139870pgl.300.1626725612500; Mon, 19 Jul 2021 13:13:32 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id q17sm24791033pgd.39.2021.07.19.13.13.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jul 2021 13:13:32 -0700 (PDT) Date: Mon, 19 Jul 2021 20:13:28 +0000 From: Sean Christopherson To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Borislav Petkov , Michael Roth , Vlastimil Babka , tony.luck@intel.com, npmccallum@redhat.com, brijesh.ksingh@gmail.com Subject: Re: [PATCH Part2 RFC v4 26/40] KVM: SVM: Add KVM_SEV_SNP_LAUNCH_FINISH command Message-ID: References: <20210707183616.5620-1-brijesh.singh@amd.com> <20210707183616.5620-27-brijesh.singh@amd.com> <9ee5a991-3e43-3489-5ee1-ff8c66cfabc1@amd.com> <379fd4da-3ca9-3205-535b-8d1891b3a75a@amd.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jul 19, 2021, Brijesh Singh wrote: > > On 7/19/21 2:14 PM, Sean Christopherson wrote: > > > > Where? I feel like I'm missing something. The only change to sev_free_vcpu() I > > see is that addition of the rmpupdate(), I don't see any reclaim path. > > Clearing of the immutable bit (aka reclaim) is done by the firmware after > the command was successful. Ah, which is why the failure path has to do manual reclaim of the immutable page. Thanks!