From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2FCF72 for ; Mon, 15 Nov 2021 18:44:29 +0000 (UTC) Received: from zn.tnic (p200300ec2f0b5600329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:5600:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 786911EC0298; Mon, 15 Nov 2021 19:44:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1637001857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=dw18rrJWiFMio+f81TkozWlG8A/iKVxyS5zqokyoOIY=; b=Dd/Fwrtnl1uGZiaWkMGZr+MuIA+r4cXwdAOsGb4gW5L9WCr54FaUiBJ6ijdhzKVchrkwr7 H2euF1CH6Z7Kw63ePiaRIve/VdIpKgUibVEL+06FxH1ktfvFsacTnl/2rzuuM9NPWXUv9f gHdYxW8TqNvuMpNY3T7pHtvAcVRdXpY= Date: Mon, 15 Nov 2021 19:44:14 +0100 From: Borislav Petkov To: Joerg Roedel Cc: x86@kernel.org, Eric Biederman , kexec@lists.infradead.org, Joerg Roedel , hpa@zytor.com, Andy Lutomirski , Dave Hansen , Peter Zijlstra , Jiri Slaby , Dan Williams , Tom Lendacky , Juergen Gross , Kees Cook , David Rientjes , Cfir Cohen , Erdem Aktas , Masami Hiramatsu , Mike Stunes , Sean Christopherson , Martin Radev , Arvind Sankar , linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v2 09/12] x86/sev: Use AP Jump Table blob to stop CPU Message-ID: References: <20210913155603.28383-1-joro@8bytes.org> <20210913155603.28383-10-joro@8bytes.org> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210913155603.28383-10-joro@8bytes.org> On Mon, Sep 13, 2021 at 05:56:00PM +0200, Joerg Roedel wrote: > diff --git a/arch/x86/include/asm/sev.h b/arch/x86/include/asm/sev.h > index 134a7c9d91b6..cd14b6e10f12 100644 > --- a/arch/x86/include/asm/sev.h > +++ b/arch/x86/include/asm/sev.h > @@ -81,12 +81,19 @@ static __always_inline void sev_es_nmi_complete(void) > __sev_es_nmi_complete(); > } > extern int __init sev_es_efi_map_ghcbs(pgd_t *pgd); > +void __sev_es_stop_this_cpu(void); > +static __always_inline void sev_es_stop_this_cpu(void) What's that for? IOW, the below seems to build too: --- diff --git a/arch/x86/include/asm/sev.h b/arch/x86/include/asm/sev.h index 1f16fc907636..398105580862 100644 --- a/arch/x86/include/asm/sev.h +++ b/arch/x86/include/asm/sev.h @@ -87,12 +87,7 @@ extern enum es_result sev_es_ghcb_hv_call(struct ghcb *ghcb, struct es_em_ctxt *ctxt, u64 exit_code, u64 exit_info_1, u64 exit_info_2); -void __sev_es_stop_this_cpu(void); -static __always_inline void sev_es_stop_this_cpu(void) -{ - if (static_branch_unlikely(&sev_es_enable_key)) - __sev_es_stop_this_cpu(); -} +void sev_es_stop_this_cpu(void); #else static inline void sev_es_ist_enter(struct pt_regs *regs) { } static inline void sev_es_ist_exit(void) { } diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c index 39378357dc5a..7a74b3273f1a 100644 --- a/arch/x86/kernel/sev.c +++ b/arch/x86/kernel/sev.c @@ -694,8 +694,11 @@ void __noreturn sev_jumptable_ap_park(void) } STACK_FRAME_NON_STANDARD(sev_jumptable_ap_park); -void __sev_es_stop_this_cpu(void) +void sev_es_stop_this_cpu(void) { + if (!static_branch_unlikely(&sev_es_enable_key)) + return; + /* Only park in the AP Jump Table when the code has been installed */ if (!sev_ap_jumptable_blob_installed) return; --- And as previously mentioned s/sev_es/sev/ if those are going to be used on SNP guests too. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette