Re: [PATCH v7 00/45] Add AMD Secure Nested Paging (SEV-SNP) Guest Support

Brijesh Singh
2021-11-16T16:03:16Z

On 11/16/21 9:45 AM, Venu Busireddy wrote:
> On 2021-11-15 10:55:32 -0600, Venu Busireddy wrote:
>> On 2021-11-15 10:45:48 -0600, Brijesh Singh wrote:
>>>
>>>
>>> On 11/15/21 10:37 AM, Venu Busireddy wrote:
>>>> On 2021-11-15 10:02:24 -0600, Brijesh Singh wrote:
>>>>>
>>>>>
>>>>> On 11/15/21 9:56 AM, Venu Busireddy wrote:
>>>>> ...
>>>>>
>>>>>>> The series is based on tip/master
>>>>>>> ea79c24a30aa (origin/master, origin/HEAD, master) Merge branch 'timers/urgent'
>>>>>>
>>>>>> I am looking at
>>>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git&amp;data=04%7C01%7Cbrijesh.singh%40amd.com%7C527b875208904981677108d9a9183dba%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637726744508270539%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=hfqoF4d95hWAY8%2BKW4t5UyrWIPAUuHOTvzTQGXyxQik%3D&amp;reserved=0,
>>>>>> and I cannot find the commit ea79c24a30aa there. Am I looking at the
>>>>>> wrong tree?
>>>>>>
>>>>>
>>>>> Yes.
>>>>>
>>>>> You should use the tip [1] tree .
>>>>>
>>>>> [1] https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftip%2Ftip.git%2F&amp;data=04%7C01%7Cbrijesh.singh%40amd.com%7C527b875208904981677108d9a9183dba%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637726744508270539%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=TDbL2dnzCp%2FlFHv6Tr%2Fn6QhFKL2kL3DFWj5BT6Abcms%3D&amp;reserved=0
>>>>
>>>> Same problem with tip.git too.
>>>>
>>>> bash-4.2$ git remote -v
>>>> origin https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftip%2Ftip.git&amp;data=04%7C01%7Cbrijesh.singh%40amd.com%7C527b875208904981677108d9a9183dba%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637726744508270539%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=0qPjqphHSBSnpxOrPGDyJ7BF5O3fnTJtXQgnO0ZwCXY%3D&amp;reserved=0 (fetch)
>>>> origin https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftip%2Ftip.git&amp;data=04%7C01%7Cbrijesh.singh%40amd.com%7C527b875208904981677108d9a9183dba%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637726744508270539%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=0qPjqphHSBSnpxOrPGDyJ7BF5O3fnTJtXQgnO0ZwCXY%3D&amp;reserved=0 (push)
>>>> bash-4.2$ git branch
>>>> * master
>>>> bash-4.2$ git log --oneline | grep ea79c24a30aa
>>>> bash-4.2$
>>>>
>>>> Still missing something?
>>>>
>>>
>>> I can see the base commit on my local clone and also on web interface
>>
>> But can you see the commit ea79c24a30aa if you clone
>> git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git?
>>
>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftip%2Ftip.git%2Fcommit%2F%3Fid%3Dea79c24a30aa27ccc4aac26be33f8b73f3f1f59c&amp;data=04%7C01%7Cbrijesh.singh%40amd.com%7C527b875208904981677108d9a9183dba%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637726744508270539%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=mG4i3ZNHgyrS3Xkdxw%2BhkmfxvzFkS%2FpX0B3xHlxN0Nc%3D&amp;reserved=0
>>
>> The web interface has the weird warning "Notice: this object is not
>> reachable from any branch." Don't know what to make of that.
>
> Just wanted to clarify. I am not interested in the commit ea79c24a30aa
> per se. I am trying to apply this patch series to a local copy of the
> tip. I tried applying to the top of the tree, and that failed. I tried
> to apply on top of commit ca7752caeaa7 (which appeared to be the closest
> commit to your description), and that also failed. I just need a commit
> on which I can successfully apply this series.
>

At the time I pulled the tip, the said commit was valid and my entire
series was generated against it. Its possible that commit is no longer
valid in the recent tip (maybe due to force push). You can grab a
staging tree from here https://github.com/AMDESE/linux/tree/snp-part1-v7.

> Thanks,
>
> Venu
>
>>
>> Venu
>>
>>>
>>> thanks