Re: [PATCH v8 12/40] x86/sev: Add helper for validating pages in early enc attribute changes

Venu Busireddy
2022-01-11T22:43:35Z

On 2022-01-11 15:57:13 -0600, Brijesh Singh wrote:
>
>
> On 1/11/22 3:51 PM, Venu Busireddy wrote:
> > On 2022-01-11 15:22:01 -0600, Brijesh Singh wrote:
> > > Hi Venu,
> > >
> > >
> > > On 1/3/22 5:28 PM, Venu Busireddy wrote:
> > > ...
> > >
> > > > > +
> > > > > + /*
> > > > > + * Ask the hypervisor to mark the memory pages as private in the RMP
> > > > > + * table.
> > > > > + */
> > > >
> > > > Indentation is off. While at it, you may want to collapse it into a one
> > > > line comment.
> > > >
> > >
> > > Based on previous review feedback I tried to keep the comment to 80
> > > character limit.
> >
> > Isn't the line length limit 100 now? Also, there are quite a few lines
> > that are longer than 80 characters in this file, and elsewhere.
> >
> > But you can ignore my comment.
> >
>
> Yes, the actual line limit is 100, but I was asked to keep the comments to
> 80 cols [1] to keep it consistent with other comments in this file.

Well, now that you mention it, the comment that immediately precedes this
one in the file is 91 characters long, and the comment that immediately
follows this one is 82 characters long! And both those lines are also
added as part of this patch.

Venu

>
> https://lore.kernel.org/lkml/f9a69ad8-54bb-70f1-d606-6497e5753bb0@amd.com/
>
> thanks