Re: [PATCH v8 12/40] x86/sev: Add helper for validating pages in early enc attribute changes

Brijesh Singh
2022-01-04T15:33:31Z

On 12/23/21 5:50 AM, Borislav Petkov wrote:
>> While at it, add a helper snp_prep_memory() that can be used outside
>> the sev specific files to change the page state for a specified memory
>
> "outside of the sev specific"? What is that trying to say?
>
> /me goes and looks at the whole patchset...
>
> Right, so that is used only in probe_roms(). So that should say:
>
> "Add a helper ... which will be used in probe_roms(), in a later patch."
>

Currently the helper is used for the probe_roms() only but it can be
used by others in future. I will go ahead and spell out saying that it
is for the probe_roms().

>
> Yeah, looking at this again, I don't really like this multiplexing.
> Let's do this instead, diff ontop:
>

thanks, I will apply your diff.