From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2B862CA3 for ; Wed, 19 Jan 2022 12:55:55 +0000 (UTC) Received: from zn.tnic (dslb-088-067-202-008.088.067.pools.vodafone-ip.de [88.67.202.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D72F91EC0373; Wed, 19 Jan 2022 13:55:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1642596950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=9NkeC38NDHwqMNmxnwshSdaG9bUxrwB91bS9TAMfKIo=; b=mvKNWpbjdzVyfWHExAFnc1xVkLATCq/T1K8CYTEeU6EwlfTl9kSRmHZYPFhwrMLQttQYgY 6rwufaIxMOl+zcMlA5jrKc8lXE6+rzNAwnTFN8xA2JqegyVg3ba9ZHrP6RrFQxQTGUxiDg kgxZ7yzL+s2twDYiUNBTluU/8XLV2mA= Date: Wed, 19 Jan 2022 13:55:43 +0100 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , "Dr . David Alan Gilbert" , tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH v8 31/40] x86/compressed: add SEV-SNP feature detection/setup Message-ID: References: <20211210154332.11526-1-brijesh.singh@amd.com> <20211210154332.11526-32-brijesh.singh@amd.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211210154332.11526-32-brijesh.singh@amd.com> On Fri, Dec 10, 2021 at 09:43:23AM -0600, Brijesh Singh wrote: > +/* > + * TODO: These are exported only temporarily while boot/compressed/sev.c is > + * the only user. This is to avoid unused function warnings for kernel/sev.c > + * during the build of kernel proper. > + * > + * Once the code is added to consume these in kernel proper these functions > + * can be moved back to being statically-scoped to units that pull in > + * sev-shared.c via #include and these declarations can be dropped. > + */ > +struct cc_blob_sev_info *snp_find_cc_blob_setup_data(struct boot_params *bp); You don't need any of that - just add the function with the patch which uses it. > +/* > + * Search for a Confidential Computing blob passed in as a setup_data entry > + * via the Linux Boot Protocol. > + */ > +struct cc_blob_sev_info * > +snp_find_cc_blob_setup_data(struct boot_params *bp) Please break lines like that only if absolutely necessary. Which doesn't look like it here. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette