From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C35C6C7C for ; Fri, 4 Mar 2022 16:14:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C9CF521124; Fri, 4 Mar 2022 16:14:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646410490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hVjR4hysznRwrUxtJgHAocuPgnjBEhcnFcR0O4FIRQ0=; b=n/xdvL3/9MTXsecXD6MdYlE2rvjdGu7d4tOUWGfZazmXdY76ILCpn9XXCJ0GSP7v14QGQ8 emT4+sE+ikSgZfPwKQGui73oMbi/j/PBuNgZY5MkZlEHn7nKyMFlTtRXcimj6xj1CmuBbY HSDmuF6h/1jiog23LplTS2SBQi+vhok= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646410490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hVjR4hysznRwrUxtJgHAocuPgnjBEhcnFcR0O4FIRQ0=; b=qdxVqY+Z/CaiL0j2x88N2NyADO/NmFC7DaNIH7Ni/khhCaLosW3DfIz1VHIRYuSB8zO17P y6QacTszv+j3OmDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 861C713B64; Fri, 4 Mar 2022 16:14:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id LiO0Hfo6ImI5RQAAMHmgww (envelope-from ); Fri, 04 Mar 2022 16:14:50 +0000 Date: Fri, 4 Mar 2022 17:14:54 +0100 From: Borislav Petkov To: Brijesh Singh Cc: Borislav Petkov , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , "Dr . David Alan Gilbert" , brijesh.ksingh@gmail.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH v11 44/45] virt: sevguest: Add support to get extended report Message-ID: References: <20220224165625.2175020-1-brijesh.singh@amd.com> <20220224165625.2175020-45-brijesh.singh@amd.com> <7c562d34-27cd-6e63-a0fb-35b13104d41f@amd.com> <0241967f-b2e6-7db4-7e54-be665e12ebb6@amd.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0241967f-b2e6-7db4-7e54-be665e12ebb6@amd.com> On Fri, Mar 04, 2022 at 10:03:52AM -0600, Brijesh Singh wrote: > I did added a text in Documentation/virt/coco/sevguest.rst (section 2.3) > that user need to look the GHCB spec for further detail. If you mean this: "See GHCB specification for further detail on how to parse the certificate blob." that ain't even scratching the surface. You need to explain that magic "certs_len == 0" condition in that textm how it is handled and what that causes the HV to do. You need to realize that because it is clear to you, it ain't that clear to others. -- Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Ivo Totev, HRB 36809, AG Nürnberg