From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82F021375 for ; Mon, 25 Jul 2022 13:02:56 +0000 (UTC) Received: from zn.tnic (p200300ea972976f8329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9729:76f8:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id AC7D11EC066E; Mon, 25 Jul 2022 15:02:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1658754170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=sg9QEcRa1MfRVFIbCkiOWE7hE+M2YmvA70MYII4fxdg=; b=ClhNtHScdoG8Y5fyZ2k/x94410/Qs23KCbUM+qrzXtS6kzCj1WAwBU31plS1ksqGHVHF7u 0f38hv6VwQDEPorch8AA6dKTLZ+myaMuboUrTBI7Vsbs878fDiRmN+IkGi44zmCtR87b5e cElxaQ9wb1Rkzx4qWtSldGDlVoPYhvw= Date: Mon, 25 Jul 2022 15:02:50 +0200 From: Borislav Petkov To: "Kirill A. Shutemov" Cc: Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Varad Gautam , Dario Faggioli , Dave Hansen , Mike Rapoport , David Hildenbrand , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv7 04/14] efi/x86: Get full memory map in allocate_e820() Message-ID: References: <20220614120231.48165-1-kirill.shutemov@linux.intel.com> <20220614120231.48165-5-kirill.shutemov@linux.intel.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220614120231.48165-5-kirill.shutemov@linux.intel.com> On Tue, Jun 14, 2022 at 03:02:21PM +0300, Kirill A. Shutemov wrote: > Currently allocate_e820() only interested in the size of map and size of ^ is > memory descriptor to determine how many e820 entries the kernel needs. > > UEFI Specification version 2.9 introduces a new memory type -- > unaccepted memory. To track unaccepted memory kernel needs to allocate > a bitmap. The size of the bitmap is dependent on the maximum physical > address present in the system. A full memory map is required to find > the maximum address. > > Modify allocate_e820() to get a full memory map. > > This is preparation for the next patch that implements handling of > unaccepted memory in EFI stub. As already pointed out, the concept of "next patch" is ambiguous in git. Just drop the whole sentence. > Signed-off-by: Kirill A. Shutemov > --- > drivers/firmware/efi/libstub/x86-stub.c | 28 +++++++++++-------------- > 1 file changed, 12 insertions(+), 16 deletions(-) With the above addressed: Reviewed-by: Borislav Petkov Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette