linux-coco.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Stefano Garzarella <sgarzare@redhat.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	linux-integrity@vger.kernel.org,
	Dov Murik <dovmurik@linux.ibm.com>,
	Dionna Glaze <dionnaglaze@google.com>,
	linux-coco@lists.linux.dev,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	Claudio Carvalho <cclaudio@linux.ibm.com>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH v3 1/4] x86/sev: add SVSM vTPM probe/send_command functions
Date: Sat, 22 Mar 2025 22:17:03 +0200	[thread overview]
Message-ID: <Z98av2cbURhSy6Rk@kernel.org> (raw)
In-Reply-To: <20250321220520.GFZ93ioO0JtfhXCb1n@fat_crate.local>

On Fri, Mar 21, 2025 at 11:05:20PM +0100, Borislav Petkov wrote:
> On Fri, Mar 21, 2025 at 10:01:17AM +0100, Stefano Garzarella wrote:
> > Just a note, patch 2 adds `include/linux/svsm_vtpm.h`, that file is
> > basically a translation of the AMD SVSM specification into structures and
> > functions used to communicate with SVSM in the way it is defined by the
> > specification.
> > 
> > I realized that the file does not fall under any section of MAINTAINERS.
> > How do you suggest we proceed?
> > 
> > Should we create an SVSM section to maintain it, including the TPM driver
> > and future other drivers,etc.?
> 
> This all belongs to the TPM drivers, right?
> 
> I.e., drivers/char/tpm/
> 
> So I guess add that header to the TPM DEVICE DRIVER section if the gents there
> are fine with it...

It's fine for me but I'd suggest to rename the header as "tpm_svsm.h".
Then this will already provide coverage:

https://web.git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?id=a2fbcecc7027944a2ce447d4dd72725c5822321f


> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette
> 

BR, Jarkko

  reply	other threads:[~2025-03-22 20:17 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-11  9:42 [PATCH v3 0/4] Enlightened vTPM support for SVSM on SEV-SNP Stefano Garzarella
2025-03-11  9:42 ` [PATCH v3 1/4] x86/sev: add SVSM vTPM probe/send_command functions Stefano Garzarella
2025-03-11  9:56   ` Jarkko Sakkinen
2025-03-12 10:56     ` Stefano Garzarella
2025-03-14 15:04       ` Jarkko Sakkinen
2025-03-14 15:27   ` Tom Lendacky
2025-03-17 13:36     ` Jarkko Sakkinen
2025-03-18 10:07       ` Stefano Garzarella
2025-03-20 15:03         ` Jarkko Sakkinen
2025-03-20 17:16           ` Borislav Petkov
2025-03-20 17:30             ` Jarkko Sakkinen
2025-03-21  9:01               ` Stefano Garzarella
2025-03-21 22:05                 ` Borislav Petkov
2025-03-22 20:17                   ` Jarkko Sakkinen [this message]
2025-03-24  9:00                     ` Stefano Garzarella
2025-03-11  9:42 ` [PATCH v3 2/4] svsm: add header with SVSM_VTPM_CMD helpers Stefano Garzarella
2025-03-11 10:07   ` Jarkko Sakkinen
2025-03-12 11:47     ` Stefano Garzarella
2025-03-11  9:42 ` [PATCH v3 3/4] tpm: add SNP SVSM vTPM driver Stefano Garzarella
2025-03-14 16:48   ` Tom Lendacky
2025-03-17 13:43     ` Jarkko Sakkinen
2025-03-18 10:38       ` Stefano Garzarella
2025-03-18 14:54         ` Tom Lendacky
2025-03-18 16:18           ` Stefano Garzarella
2025-03-19 23:44             ` Jason Gunthorpe
2025-03-20 11:18               ` Stefano Garzarella
2025-03-20 15:00               ` Jarkko Sakkinen
2025-03-20 14:56         ` Jarkko Sakkinen
2025-03-11  9:42 ` [PATCH v3 4/4] x86/sev: register tpm-svsm platform device Stefano Garzarella
2025-03-14 16:56   ` Tom Lendacky
2025-03-17 13:34     ` Jarkko Sakkinen
2025-03-18 10:44       ` Stefano Garzarella
2025-03-20 15:02         ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z98av2cbURhSy6Rk@kernel.org \
    --to=jarkko@kernel.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=bp@alien8.de \
    --cc=cclaudio@linux.ibm.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=dionnaglaze@google.com \
    --cc=dovmurik@linux.ibm.com \
    --cc=hpa@zytor.com \
    --cc=jgg@ziepe.ca \
    --cc=jroedel@suse.de \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterhuewe@gmx.de \
    --cc=sgarzare@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).