From: Joerg Roedel <joro@8bytes.org>
To: Liam Merwick <liam.merwick@oracle.com>
Cc: x86@kernel.org, hpa@zytor.com,
Tom Lendacky <thomas.lendacky@amd.com>,
Nikunj A Dadhania <nikunj@amd.com>,
Larry.Dewey@amd.com, linux-kernel@vger.kernel.org,
linux-coco@lists.linux.dev, Juergen Gross <jgross@suse.com>,
kirill.shutemov@linux.intel.com, alexey.gladkov@intel.com,
Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH 1/2] x86/coco/sev: Move SEV SYSFS group to /sys/hypervisor/
Date: Wed, 12 Mar 2025 16:43:46 +0100 [thread overview]
Message-ID: <Z9GrsoIP_NWjPPC-@8bytes.org> (raw)
In-Reply-To: <e6046eff-0b16-4ae7-a8f5-0f765a7e2836@oracle.com>
On Wed, Mar 12, 2025 at 03:32:04PM +0000, Liam Merwick wrote:
> one suggestion below but either way,
>
> Reviewed-by: Liam Merwick <liam.merwick@oracle.com>
Thanks!
> > + sev_kobj = kobject_create_and_add("sev", hypervisor_kobj);
>
> Given hypervisor_kobj is created elsewhere, and the caller of
> hypervisor_init() doesn't check for ENOMEM, would it be worth
> adding a check here that it exists before using it?
Hmm, dunno, I guess it would make things slightly more robust. On the
other side all existing users of this object already assume a successful
initialization.
Regards,
Joerg
next prev parent reply other threads:[~2025-03-12 15:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 14:41 [PATCH 0/2 v2] Move SEV sysfs information and expose MSR_SEV_STATUS Joerg Roedel
2025-03-12 14:41 ` [PATCH 1/2] x86/coco/sev: Move SEV SYSFS group to /sys/hypervisor/ Joerg Roedel
2025-03-12 15:11 ` Tom Lendacky
2025-03-12 15:13 ` Joerg Roedel
2025-03-12 15:32 ` Liam Merwick
2025-03-12 15:43 ` Joerg Roedel [this message]
2025-03-12 14:41 ` [PATCH 2/2] x86/sev: Make SEV_STATUS available via SYSFS Joerg Roedel
2025-03-12 14:46 ` Tom Lendacky
2025-03-12 14:56 ` Joerg Roedel
2025-03-12 14:57 ` Dave Hansen
2025-03-12 15:07 ` Joerg Roedel
2025-03-12 16:04 ` Dave Hansen
2025-03-12 16:19 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9GrsoIP_NWjPPC-@8bytes.org \
--to=joro@8bytes.org \
--cc=Larry.Dewey@amd.com \
--cc=alexey.gladkov@intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jroedel@suse.de \
--cc=kirill.shutemov@linux.intel.com \
--cc=liam.merwick@oracle.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=nikunj@amd.com \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).