From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5D896ADC for ; Wed, 26 Apr 2023 19:53:54 +0000 (UTC) Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-24b6a888085so5774394a91.0 for ; Wed, 26 Apr 2023 12:53:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682538834; x=1685130834; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=UcyBowT/7snrKRgrt26A0bjGirGSsCbvk5IYXN32HYY=; b=CuidvLgO7z5aVRbyi2cxF8vMwPPNTmcByG3DJ8NEOcVe3pCT0eXWZCsKQGraTkbjGb 4hbjD82vdnbjArnYR0vPXmtn/K2NYzEIa6GZk3RYRZcQ86pEsJEOILpvt0zH+DdIh86M ffZ931f+gaGp84zpzHvRMCo3GvNBJkjL+UCbYgWEmDmR7lYZ+8mTq1o6ejVruQisWeC9 lRVgdjaN7rDBJhYqvaod9OTfpzYSt3rTCMpPj1f8ZXA0CQIkcinSLPYutZ8SgksXJbS5 TllB/S+PKzuHiyv/7x/yV/hviGV1R0FcgfZ0iJ3AFMVJ/2sK/o88ygPxT19/fSVM6uxR bwjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682538834; x=1685130834; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UcyBowT/7snrKRgrt26A0bjGirGSsCbvk5IYXN32HYY=; b=ReqeUDKnmBWJjy7JPIGwEgISRrTy7j76GlImX0omyQLN71qjHV7yuOs6Q3YypbLy4S gNJ2ktvJc/+EVR30Lmz/WRKM4z8JOmGKmTH+wxVn4fTlHHl62DBzGP3yJgbrAyzWsUPR Z21ax4A7o6zUhKLZT+0ReHb2ImE5A1JdbsTxOy8ANdbebRDI5yujJO5QcDBwv9mgpmXN KmdadngfcnZigCvIKTuuPCdQif1jid8qzSjRKqwnLzXhx+Iz0BFJ4Y1Lwueym+Y/OI4M +qVqYNikU1buYLd82gaVlKcSqJZhpfmvanlR8W9iTu4MzpQDb3XFuWqj59REDnRvJaaw oaqA== X-Gm-Message-State: AC+VfDziMEsCD776iw0bDMQVW0wbPrGH0yA7lL1P2Eau6bbUuuRZA5S+ g4MdRolViC61ydMKFZa5UImk3YIJRjo= X-Google-Smtp-Source: ACHHUZ7RI4MX7FcPrIeTC5Ho80NQDYQuerP8eAeDqvdf0/r1i6zP/B09U0lrSgLPqQyKFDHUPKT0f/XOgrU= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90a:2c82:b0:24b:dbeb:d3b4 with SMTP id n2-20020a17090a2c8200b0024bdbebd3b4mr1869198pjd.0.1682538834276; Wed, 26 Apr 2023 12:53:54 -0700 (PDT) Date: Wed, 26 Apr 2023 12:53:52 -0700 In-Reply-To: <9021d861-cde6-a51a-7d8c-b3f67eaa01d8@amd.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20230327141816.2648615-1-carlos.bilbao@amd.com> <9fa5ce43-584d-878d-227a-fb458254c00a@amd.com> <9021d861-cde6-a51a-7d8c-b3f67eaa01d8@amd.com> Message-ID: Subject: Re: [PATCH] docs: security: Confidential computing intro and threat model From: Sean Christopherson To: Carlos Bilbao Cc: Elena Reshetova , "corbet@lwn.net" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "ardb@kernel.org" , "kraxel@redhat.com" , "dovmurik@linux.ibm.com" , "dave.hansen@linux.intel.com" , "Dhaval.Giani@amd.com" , "michael.day@amd.com" , "pavankumar.paluri@amd.com" , "David.Kaplan@amd.com" , "Reshma.Lal@amd.com" , "Jeremy.Powell@amd.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "alexander.shishkin@linux.intel.com" , "thomas.lendacky@amd.com" , "tglx@linutronix.de" , "dgilbert@redhat.com" , "gregkh@linuxfoundation.org" , "dinechin@redhat.com" , "linux-coco@lists.linux.dev" , "berrange@redhat.com" , "mst@redhat.com" , "tytso@mit.edu" , "jikos@kernel.org" , "joro@8bytes.org" , "leon@kernel.org" , "richard.weinberger@gmail.com" , "lukas@wunner.de" , "jejb@linux.ibm.com" , "cdupontd@redhat.com" , "jasowang@redhat.com" , "sameo@rivosinc.com" , "bp@alien8.de" , "security@kernel.org" , Andrew Bresticker , Rajnesh Kanwal , Dylan Reid , Ravi Sahita Content-Type: text/plain; charset="us-ascii" On Wed, Apr 26, 2023, Carlos Bilbao wrote: > On 4/26/23 10:51 AM, Sean Christopherson wrote: > > This document is named confidential-computing.rst, not tdx-and-snp.rst. Not > > explicitly mentioning SEV doesn't magically warp reality to make descriptions like > > this one from security/secrets/coco.rst disappear: > > > > Introduction > > ============ > > > > Confidential Computing (coco) hardware such as AMD SEV (Secure Encrypted > > Virtualization) allows guest owners to inject secrets into the VMs > > memory without the host/hypervisor being able to read them. > > > > My complaint about this document being too Intel/AMD centric isn't that it doesn't > > mention other implementations, it's that the doc describes CoCo purely from the > > narrow viewpoint of Intel TDX and AMD SNP, and to be blunt, reads like a press > > release and not an objective overview of CoCo. > > Be specific about the parts of the document that you feel are too > AMD/Intel centric, and we will correct them. The whole thing? There aren't specific parts that are too SNP/TDX centric, the entire tone and approach of the document is wrong. As I responded to Dave, I would feel differently if the document were named tdx-and-snp-threat-model.rst, but this patch proposes a generic confidential-computing.rst and presents the SNP+TDX confidential VM use case as if it's the *only* confidential computing use case.