From: Jason Gunthorpe <jgg@ziepe.ca>
To: Christoph Hellwig <hch@lst.de>
Cc: Kim Phillips <kim.phillips@amd.com>,
joro@8bytes.org, suravee.suthikulpanit@amd.com,
iommu@lists.linux.dev, Michael Roth <michael.roth@amd.com>,
"Kalra, Ashish" <Ashish.Kalra@amd.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
linux-coco@lists.linux.dev
Subject: Re: [PATCH] iommu/amd: remove amd_iommu_snp_enable
Date: Wed, 6 Sep 2023 10:36:19 -0300 [thread overview]
Message-ID: <ZPiAUx9Qysw0AKNq@ziepe.ca> (raw)
In-Reply-To: <20230901055020.GA31908@lst.de>
On Fri, Sep 01, 2023 at 07:50:20AM +0200, Christoph Hellwig wrote:
> On Thu, Aug 31, 2023 at 01:03:53PM -0500, Kim Phillips wrote:
> > +Mike Roth, Ashish
> >
> > On 8/31/23 7:31 AM, Christoph Hellwig wrote:
> >> amd_iommu_snp_enable is unused and has been since it was added in commit
> >> fb2accadaa94 ("iommu/amd: Introduce function to check and enable SNP").
> >>
> >> Signed-off-by: Christoph Hellwig <hch@lst.de>
> >> ---
> >
> > It is used by the forthcoming host SNP support:
> >
> > https://lore.kernel.org/lkml/20230612042559.375660-8-michael.roth@amd.com/
>
> Then resend it with that support, but don't waste resources and everyones
> time now.
+1
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
I've said this many times lately. There are other things in this
driver that have no upstream justification too, like nesting
"support".
Please organize this SNP support into series that makes sense and are
self complete :( I'm not sure a 51 patch series is a productive way to
approach this..
Jason
next prev parent reply other threads:[~2023-09-06 13:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230831123107.280998-1-hch@lst.de>
2023-08-31 18:03 ` [PATCH] iommu/amd: remove amd_iommu_snp_enable Kim Phillips
2023-09-01 5:50 ` Christoph Hellwig
2023-09-06 13:36 ` Jason Gunthorpe [this message]
2023-09-07 9:55 ` Suthikulpanit, Suravee
2023-09-07 16:10 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPiAUx9Qysw0AKNq@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=Ashish.Kalra@amd.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kim.phillips@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=michael.roth@amd.com \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).