From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F29631662E7; Mon, 19 Aug 2024 11:50:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724068254; cv=none; b=ORMYli5edU1/Q1RBDSVAxMTD5Pah/aEgkZIsHJBo7X3kM4ct0CALWlF96DcSyp4xZQ1VTrQuH1bFYT0wrSpyu+LlxZiQr1V3I6BqgXuMng+BS1gleimugoNDBJP+rNpS8CK+yrLyPtCspAgSdenRgPpB0ILhezM2lKBxLvJSXok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724068254; c=relaxed/simple; bh=620CqvVhgEg8yAKm2hSicXxxTSPtUohR0aIsNsb7RzE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CT/Q56tmknOtdOikVogwKGiqV0hw34jVgbqYSaTSUEYrqWaESYzJlxYU/eklDxYf8BIYRcfboBrSvBNdibGdqkD3myar9PYTCYHhL1AHOomkzqDHZed8OresdUqWiBxxppVKQMLDkyWgBpMJiFH86PldXgZ+DaPVLP1Jq2KLVt4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nH7yaaGP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nH7yaaGP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C69E4C32782; Mon, 19 Aug 2024 11:50:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724068253; bh=620CqvVhgEg8yAKm2hSicXxxTSPtUohR0aIsNsb7RzE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nH7yaaGPw0HJC4yk91YY/FnupXtb/Gi/wXc7UV3gQSNw/QEe3VrlAVKy/ksLlYh4s pSJaBPezIl6IbeITHf+VHSXGDM23Nvw1X6z0ANpe4JQBW+iet9GCxAy7XMcsH4r+9V xf+18cTw3rplHMNAdoAnsf0r6cauMhZA9O9qcta0fIVzIW7mqNz8fRDu8+dZsezVIZ oIb7YocEGhdV8q79AwYqU2hvyXxhbKF4EWXeDgBxPKGZ/1GQfoORr3NO8uFeAY7P9d G2LJ580EjNIX+mhdpgD/o12RoNX/61a7GllsrSicslJuNZjYJVSZMW0NvkNiMxV7jb LyKvo3nFMauLg== Date: Mon, 19 Aug 2024 13:50:46 +0200 From: Alexey Gladkov To: "Kirill A. Shutemov" Cc: linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andrew Morton , Yuan Yao , Geert Uytterhoeven , Yuntao Wang , Kai Huang , Baoquan He , Oleg Nesterov , cho@microsoft.com, decui@microsoft.com, John.Starks@microsoft.com Subject: Re: [PATCH v3 03/10] x86/tdx: Allow MMIO from userspace Message-ID: References: <2a79d86c268d934644b8e4a5a8c59b4699fa0015.1723807851.git.legion@kernel.org> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Aug 19, 2024 at 01:46:34PM +0300, Kirill A. Shutemov wrote: > On Fri, Aug 16, 2024 at 03:43:53PM +0200, Alexey Gladkov wrote: > > From: "Alexey Gladkov (Intel)" > > > > The MMIO emulation is only allowed for kernel space code. It is carried > > out through a special API, which uses only certain instructions. > > > > This does not allow userspace to work with virtual devices. > > > > Allow userspace to use the same instructions as kernel space to access > > MMIO. So far, no additional checks have been made. > > > > Signed-off-by: Alexey Gladkov (Intel) > > Reviewed-by: Kirill A. Shutemov > > And you seem to lost Reviewed-by from Thomas: > > https://lore.kernel.org/all/874j867mnd.ffs@tglx No. I removed it because the patch changed a lot after his review. I didn't want to mislead anyone. -- Rgrds, legion