From: Catalin Marinas <catalin.marinas@arm.com>
To: Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Sudeep Holla <sudeep.holla@arm.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Suzuki Poulose <suzuki.poulose@arm.com>,
Steven Price <steven.price@arm.com>,
Oliver Upton <oliver.upton@linux.dev>,
Marc Zyngier <maz@kernel.org>,
linux-coco@lists.linux.dev
Subject: Re: [PATCH v2 5/7] arm64: mm: Add confidential computing hook to ioremap_prot()
Date: Mon, 2 Sep 2024 20:08:45 +0100 [thread overview]
Message-ID: <ZtYNPQnP5_YEiLy5@arm.com> (raw)
In-Reply-To: <20240830130150.8568-6-will@kernel.org>
On Fri, Aug 30, 2024 at 02:01:48PM +0100, Will Deacon wrote:
> @@ -16,7 +28,16 @@ void __iomem *ioremap_prot(phys_addr_t phys_addr, size_t size,
> if (WARN_ON(pfn_is_map_memory(__phys_to_pfn(phys_addr))))
> return NULL;
>
> - return generic_ioremap_prot(phys_addr, size, __pgprot(prot));
> + /*
> + * If a hook is registered (e.g. for confidential computing
> + * purposes), call that now and barf if it fails.
> + */
> + if (unlikely(ioremap_prot_hook) &&
> + WARN_ON(ioremap_prot_hook(phys_addr, size, &pgprot))) {
> + return NULL;
> + }
> +
> + return generic_ioremap_prot(phys_addr, size, pgprot);
> }
> EXPORT_SYMBOL(ioremap_prot);
I mentioned on the CCA series, the patch is all good but we may need
something similar for io_remap_pfn_range() which uses
pgprot_decrypted() (I think it mostly matters for the pKVM case).
--
Catalin
next prev parent reply other threads:[~2024-09-02 19:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 13:01 [PATCH v2 0/7] Support for running as a pKVM protected guest Will Deacon
2024-08-30 13:01 ` [PATCH v2 1/7] firmware/smccc: Call arch-specific hook on discovering KVM services Will Deacon
2024-08-30 13:01 ` [PATCH v2 2/7] drivers/virt: pkvm: Add initial support for running as a protected guest Will Deacon
2024-08-30 13:01 ` [PATCH v2 3/7] arm64: mm: Add top-level dispatcher for internal mem_encrypt API Will Deacon
2024-08-30 13:01 ` [PATCH v2 4/7] drivers/virt: pkvm: Hook up mem_encrypt API using pKVM hypercalls Will Deacon
2024-08-30 13:01 ` [PATCH v2 5/7] arm64: mm: Add confidential computing hook to ioremap_prot() Will Deacon
2024-09-02 19:08 ` Catalin Marinas [this message]
2024-09-04 12:29 ` Will Deacon
2024-08-30 13:01 ` [PATCH v2 6/7] drivers/virt: pkvm: Intercept ioremap using pKVM MMIO_GUARD hypercall Will Deacon
2024-08-30 13:01 ` [PATCH v2 7/7] arm64: smccc: Reserve block of KVM "vendor" services for pKVM hypercalls Will Deacon
2024-08-30 13:42 ` [PATCH v2 0/7] Support for running as a pKVM protected guest Marc Zyngier
2024-08-30 13:52 ` Steven Price
2024-08-30 16:12 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtYNPQnP5_YEiLy5@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-coco@lists.linux.dev \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=steven.price@arm.com \
--cc=sudeep.holla@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).